View Issue Details

This bug affects 2 person(s).
 20
IDProjectCategoryView StatusLast Update
17906Bug reportsLabel setspublic2022-03-14 12:45
ReporterEinkauf.ZIT Assigned Togabrieljenik  
PriorityhighSeverityblock 
Status closedResolutionfixed 
Product Version5.2.x 
Summary17906: Label set doesn't load
Description

When I try to load a label set in - for example - a Matrix question, the label set is not loading.
It dosn't matter, which label set.

Steps To Reproduce

Steps to reproduce

Create a new question, Matrix type, click on "Load label set", choose a label set.

Expected result

Label set should be loaded and be able to import in the answers for the question

Actual result

Label set doesn't load

TagsNo tags attached.
Attached Files
Bug heat20
Complete LimeSurvey version number (& build)5.2.14+220214
I will donate to the project if issue is resolvedNo
BrowserEvery browser
Database type & versionMySQL 5.7.12
Server OS (if known)Windows Server 2012 R2 Standard Edition
Webserver software & version (if known)IIS 8.5
PHP Version7.3.20

Relationships

related to 17843 closedgalads Loading Label Sets not possible 

Users monitoring this issue

There are no users monitoring this issue.

Activities

Einkauf.ZIT

Einkauf.ZIT

2022-03-03 09:26

reporter   ~68531

Any news?

gabrieljenik

gabrieljenik

2022-03-04 15:40

manager   ~68542

We couldn't reproduce it.
Can I ask you to try reproduce it here?
https://demo.limesurvey.org/index.php?r=questionAdministration/view&surveyid=496863&gid=75&qid=2227#

Einkauf.ZIT

Einkauf.ZIT

2022-03-07 11:01

reporter   ~68555

No, I cannot reproduce it on your demo site, but that doesn't help me.
I also updated to Version 5.3.3+220307, didn't change anything.

But I also get this error (in German), when I click on "ComfortUpdate":
500: Interner Serverfehler
Weder Update noch zugehörige Behavior haben einen Scope "showHeaders".
Ein interner Fehler ist aufgetreten, während der Webserver Ihre Anfrage bearbeitet hat.
Bitte kontaktieren Sie Helpdesk, um dieses Problem zu melden.

What is that?

Kind regards,

Klaus

gabrieljenik

gabrieljenik

2022-03-07 13:24

manager   ~68559

@galads Are you aware of that error in ComfortUpdate?

DenisChenu

DenisChenu

2022-03-07 17:01

developer   ~68560

We couldn't reproduce it.

Maybe related to some specific character not encoded ?
@Einkauf.ZIT you have a lot of label sets ? Can you export and send it here ?

c_schmitz

c_schmitz

2022-03-07 20:28

administrator   ~68565

I would recommend updating manually (not using ComfortUpdate) to the latest version to rule out missing files.
Let us know if you can reproduce after that.

Einkauf.ZIT

Einkauf.ZIT

2022-03-08 09:13

reporter   ~68568

I made the last update for 5.3.3+220307 manually and the message is still there.

Einkauf.ZIT

Einkauf.ZIT

2022-03-08 09:14

reporter   ~68569

@DenisChenu We have 201 label sets at the moment.

Einkauf.ZIT

Einkauf.ZIT

2022-03-08 09:15

reporter   ~68570

Here is the full export of all label sets.

galads

galads

2022-03-10 12:30

reporter   ~68610

I can reproduce this error in the latest master branch.

gabrieljenik

gabrieljenik

2022-03-10 13:27

manager   ~68611

PR: https://github.com/LimeSurvey/LimeSurvey/pull/2287

Opening the modal loads the dropdown.
Before a labelset is chosen, all labelsets details are already loading in the background.

Eventually, all requests finish and the labelset dropdown appears.
If there are a lot of labelsets, there might be an overload.

We believe that the details should only be uploaded when they are chosen.

We do not know if it is really the problem that produces the error for the user, we think so.
Still, we believe that this situation should also be corrected.

We also took the opportunity to solve another problem: When you open the modal several times, choosing a label set makes the screen to flick several times. This occurred because the change event was rebinded on each opening of the modal. So when choosing an option, the change was triggered several times.

Two other things remain to be resolved for me:

1) Show a loader while the dropdown loads. Normally it's fast, but if there are many labelsets it takes a few seconds and is confusing.

2) Do something if the ajax fails. Both in the load of the dropdown and in the selection of an option.
Show an error?

geraldC

geraldC

2022-03-10 14:30

reporter   ~68612

Same problem with multiple choice questions.
Tried with version 5.3.4

gabrieljenik

gabrieljenik

2022-03-14 06:38

manager   ~68648

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=33347

Einkauf.ZIT

Einkauf.ZIT

2022-03-14 09:21

reporter   ~68651

@c_schmitz Hello, I still have that problem, when I want to make an update online.

500.PNG (62,139 bytes)   
500.PNG (62,139 bytes)   
galads

galads

2022-03-14 10:06

reporter   ~68652

Can you enable debug = 2 in application/config/config.php and try again, please? Paste the complete error message here.

Einkauf.ZIT

Einkauf.ZIT

2022-03-14 10:28

reporter   ~68653

Here is the result of the debug=2 run.

debug1.PNG (141,785 bytes)
debug2.PNG (207,294 bytes)
debug3.PNG (184,486 bytes)
LimeBot

LimeBot

2022-03-14 11:35

administrator   ~68657

Fixed in Release 5.3.5+220314

Einkauf.ZIT

Einkauf.ZIT

2022-03-14 12:45

reporter   ~68661

Hello @all :)

I made the update to 5.3.5+220314 manually again and everyhing looks fine now!

THANK YOU! :)

Kind regards,

Klaus :)

Related Changesets

LimeSurvey: master d0c886c2

2022-03-14 07:38

gabrieljenik

Committer: GitHub


Details Diff
Fixed issue 17906: Label set doesn't load (#2287)

- Avoid triggering Label Set selector 'change' event on background for each label set.
- Also fixed flickering when selecting a label set after closing and opening the modal multiple times.

Co-authored-by: encuestabizdevgit <devgit@encuesta.biz>
Affected Issues
17906
mod - assets/scripts/admin/questionEditor.js Diff File

Issue History

Date Modified Username Field Change
2022-02-23 12:28 Einkauf.ZIT New Issue
2022-02-23 12:28 Einkauf.ZIT File Added: beschriftungssets-laden-nicht_komprimiert.mp4
2022-02-25 13:00 ollehar Priority none => high
2022-02-25 13:00 ollehar Zoho Project Synchronization => |Yes|
2022-03-03 09:26 Einkauf.ZIT Note Added: 68531
2022-03-03 09:26 Einkauf.ZIT Bug heat 0 => 2
2022-03-04 15:40 gabrieljenik Note Added: 68542
2022-03-04 15:40 gabrieljenik Bug heat 2 => 4
2022-03-07 11:01 Einkauf.ZIT Note Added: 68555
2022-03-07 13:24 gabrieljenik Note Added: 68559
2022-03-07 17:01 DenisChenu Note Added: 68560
2022-03-07 17:01 DenisChenu Bug heat 4 => 6
2022-03-07 20:28 c_schmitz Assigned To => c_schmitz
2022-03-07 20:28 c_schmitz Status new => feedback
2022-03-07 20:28 c_schmitz Note Added: 68565
2022-03-07 20:28 c_schmitz Bug heat 6 => 8
2022-03-08 09:13 Einkauf.ZIT Note Added: 68568
2022-03-08 09:13 Einkauf.ZIT Status feedback => assigned
2022-03-08 09:14 Einkauf.ZIT Note Added: 68569
2022-03-08 09:15 Einkauf.ZIT Note Added: 68570
2022-03-08 09:15 Einkauf.ZIT File Added: limesurvey_labelset_185_83_126_125_199_71_196_58_170_171_189_145_190_64_65_123_124_200_28_198_115_95_98_89_114_117_144_69_68_30_172_178_27_97_86_148_149_150_191_169_158_159_84_116_160_192_55_75_74_142_111_109_151_100_70_179_94_112_128_.lsl
2022-03-08 14:30 gabrieljenik Relationship added related to 17843
2022-03-10 12:30 galads Note Added: 68610
2022-03-10 12:30 galads Bug heat 8 => 10
2022-03-10 13:27 gabrieljenik Note Added: 68611
2022-03-10 14:28 guest Bug heat 10 => 16
2022-03-10 14:30 geraldC Note Added: 68612
2022-03-10 14:30 geraldC Bug heat 16 => 18
2022-03-14 06:38 gabrieljenik Changeset attached => LimeSurvey master d0c886c2
2022-03-14 06:38 gabrieljenik Note Added: 68648
2022-03-14 06:38 gabrieljenik Assigned To c_schmitz => gabrieljenik
2022-03-14 06:38 gabrieljenik Resolution open => fixed
2022-03-14 09:21 Einkauf.ZIT Note Added: 68651
2022-03-14 09:21 Einkauf.ZIT File Added: 500.PNG
2022-03-14 10:06 galads Note Added: 68652
2022-03-14 10:07 galads Status assigned => feedback
2022-03-14 10:28 Einkauf.ZIT Note Added: 68653
2022-03-14 10:28 Einkauf.ZIT File Added: debug1.PNG
2022-03-14 10:28 Einkauf.ZIT File Added: debug2.PNG
2022-03-14 10:28 Einkauf.ZIT File Added: debug3.PNG
2022-03-14 10:28 Einkauf.ZIT Status feedback => assigned
2022-03-14 11:35 LimeBot Zoho Project Synchronization Yes => |Yes|
2022-03-14 11:35 LimeBot Note Added: 68657
2022-03-14 11:35 LimeBot Status assigned => closed
2022-03-14 11:35 LimeBot Bug heat 18 => 20
2022-03-14 12:45 Einkauf.ZIT Note Added: 68661