View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
17798 | Bug reports | Authentication | public | 2021-12-12 13:52 | 2022-02-28 12:58 |
Reporter | DenisChenu | Assigned To | gabrieljenik | ||
Priority | none | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 5.2.x | ||||
Summary | 17798: Set authwebserver as default didn't deactivate AuthDB usage | ||||
Description | User can still log in with AuthDB if Authwebserver is default | ||||
Steps To Reproduce | Steps to reproduceSet Authwebserver settings as ANOTHERKEY for server key Expected resultNo way to login : 401 error. Actual resultSee form and can log in. | ||||
Tags | No tags attached. | ||||
Attached Files | |||||
Bug heat | 8 | ||||
Complete LimeSurvey version number (& build) | 5.2.5 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | not relevant | ||||
Database type & version | not relevant | ||||
Server OS (if known) | not relevant | ||||
Webserver software & version (if known) | not relevant | ||||
PHP Version | not relevant | ||||
related to | 17860 | closed | gabrieljenik | Some controllers don't honor authwebserver plugin |
The issue here is that the key is not found on the server. If key is not found, and default is checked, should not show the form but throw some kind of error? |
|
It's the issue i think :) maybe do like AuthCas : https://github.com/univlorraine/limesurvey-cas
|
|
IMHO authwebserver is in general broken. |
|
I will fix this issue honoring "This disable …" checkbox, even if the key doesn't match. Thanks! |
|
Maybe it's more an "sentence help" issue ;) |
|
PR: https://github.com/LimeSurvey/LimeSurvey/pull/2210 @c_schmitz Can you tell me an example of this urls not covered by the authwebserver? |
|
QuestionAdministrationController.php any maybe a couple more IMHO they cannot co-exist in the /admin subdirectory because the routing is different. |
|
All: @c_schmitz Will review the list. Thanks |
|
@gabrieljenik : see my comment on pull request. Maybe adding in plugin settings : "Default if not set too" to false by default ? About other controller : need to extend another controller ? And check access in run action ? |
|
Create a new bug for that. 17860 About the other comments, I think all are addressed as code review is OK. |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=33221 |
|
Fixed in Release 5.3.0+220228 |
|
LimeSurvey: master 4f4325b9 2022-02-21 13:43 Committer: GitHub Details Diff |
Fixed issue 17798: Set authwebserver as default didn't deactivate AuthDB usage (#2210) * Fixed issue 17798: Set authwebserver as default didn't deactivate AuthDB usage * Fixed issue 17798: Set authwebserver as default didn't deactivate AuthDB usage Co-authored-by: encuestabizdevgit <devgit@encuesta.biz> |
Affected Issues 17798 |
|
mod - application/core/plugins/Authwebserver/Authwebserver.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2021-12-12 13:52 | DenisChenu | New Issue | |
2021-12-12 13:52 | DenisChenu | File Added: Capture d’écran du 2021-12-12 13-49-10.png | |
2021-12-13 13:16 | galads | Assigned To | => galads |
2021-12-13 13:16 | galads | Status | new => acknowledged |
2021-12-16 13:02 | galads | Status | acknowledged => confirmed |
2021-12-16 13:02 | galads | Zoho Project Synchronization | => |Yes| |
2022-01-12 22:14 | gabrieljenik | Note Added: 67987 | |
2022-01-12 22:14 | gabrieljenik | Bug heat | 0 => 2 |
2022-01-13 08:36 | DenisChenu | Note Added: 67988 | |
2022-01-13 08:36 | DenisChenu | Bug heat | 2 => 4 |
2022-01-13 13:12 | c_schmitz | Note Added: 67994 | |
2022-01-13 13:12 | c_schmitz | Bug heat | 4 => 6 |
2022-01-13 15:13 | gabrieljenik | Note Added: 67996 | |
2022-01-13 16:03 | DenisChenu | Note Added: 67997 | |
2022-01-14 14:07 | gabrieljenik | Note Added: 68008 | |
2022-01-14 16:55 | c_schmitz | Note Added: 68028 | |
2022-01-14 16:56 | c_schmitz | Note Edited: 68028 | |
2022-01-14 20:27 | gabrieljenik | Note Added: 68030 | |
2022-01-15 10:55 | DenisChenu | Note Added: 68031 | |
2022-01-31 16:10 | gabrieljenik | Note Added: 68153 | |
2022-01-31 16:10 | gabrieljenik | Relationship added | related to 17860 |
2022-02-21 12:43 | gabrieljenik | Changeset attached | => LimeSurvey master 4f4325b9 |
2022-02-21 12:43 | gabrieljenik | Note Added: 68338 | |
2022-02-21 12:43 | gabrieljenik | Assigned To | galads => gabrieljenik |
2022-02-21 12:43 | gabrieljenik | Resolution | open => fixed |
2022-02-28 12:58 | LimeBot | Zoho Project Synchronization | Yes => |Yes| |
2022-02-28 12:58 | LimeBot | Note Added: 68428 | |
2022-02-28 12:58 | LimeBot | Status | confirmed => closed |
2022-02-28 12:58 | LimeBot | Bug heat | 6 => 8 |