View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 2 person(s).
 16
IDProjectCategoryView StatusDate SubmittedLast Update
17773Bug reportsLabel setspublic2021-12-02 13:292022-03-07 10:14
ReporterHiccup Assigned Togabrieljenik  
PrioritynoneSeverityfeature 
Status closedResolutionfixed 
Product Version3.x 
Summary17773: Code name change while we updated from Edit Question screen
Description

we have one issue.
we are not able to save label set in ls3.
can you please check this?

Test Scenarios:

we store label set direct in question edit.
but in label set list code has been cut down and display.
but actually in edit question code display properly.
while we used that that save label set that used cut down string.

labelset list

PLACE;HOTEL OR PLACE NAME
ADDR;STREET ADDRESS
CITY;CITY
STATE;STATE
ZIP;ZIP
LAT;LAT
LONG;LONG
SEARCHKEY;SEARCH KEYWORD USED
SELTYPE;MAP LATLONG SELECTION TYPE ( SEARCH,PIN )
STPCLNTID;STPCLIENT ID
STPID;STOP ID
STPSEQ;STOP SEQUENCE
STPUSRSTOP;STPUSRSTOP

Steps To Reproduce

Steps to reproduce

Create a new label set from Edit question.,
then Save as label set.
After that go to Manage label sets check the code of that new label set.
new label set code in trim in manage label set screen.

Please check Test group

Expected result

Both have to display the same as the edit question label set we added.

TagsNo tags attached.
Attached Files
limesurvey_survey_413621.lss (447,795 bytes)
Bug heat16
Complete LimeSurvey version number (& build)LS3
I will donate to the project if issue is resolved
Browser
Database type & version
Server OS (if known)
Webserver software & version (if known)
PHP Version

Users monitoring this issue

There are no users monitoring this issue.

Activities

Mazi

Mazi

2021-12-02 13:46

updater   ~67651

@galads, I can reproduce this issue. While when adding answer options the max code lenght is 5, adding subquestions allows using longer subquestion codes, see screenshot.

Problem: When saving such subquestions with longer codes as label set, the subquestion codes then get cut off. If I save the subquestions and then view the label sets, the codes are shortened but the user will not notice that.

image.png (31,198 bytes)   
image.png (31,198 bytes)   
image-2.png (32,240 bytes)   
image-2.png (32,240 bytes)   
Hiccup

Hiccup

2021-12-02 17:01

reporter   ~67658

Last edited: 2021-12-14 13:18

@Mazi how can we change or remove description details??
I m not able to make any changes in this issue/
gabrieljenik

gabrieljenik

2022-01-06 17:24

manager   ~67936

Last edited: 2022-01-06 17:24

PR: https://github.com/LimeSurvey/LimeSurvey/pull/2201

Made the labelsets long enough for hlding answer codes (5 chars) and subquestion codes (>= 5).
If a labelset thought for a subquestion code is imported on answer options, codes are trimed and alerts are shown

This should also be happening on master.
Will apply it after reviewing this 3x branch
gabrieljenik

gabrieljenik

2022-01-14 11:58

manager   ~68000

Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=33098
LimeBot

LimeBot

2022-01-18 10:54

administrator   ~68046

Fixed in Release 3.27.32+220119
c_schmitz

c_schmitz

2022-02-09 14:40

administrator   ~68255

Master patch still pending.
gabrieljenik

gabrieljenik

2022-02-23 13:00

manager   ~68383

Last edited: 2022-02-23 13:01

PR for master: https://github.com/LimeSurvey/LimeSurvey/pull/2217
gabrieljenik

gabrieljenik

2022-03-03 19:56

manager   ~68534

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=33320
LimeBot

LimeBot

2022-03-07 10:14

administrator   ~68548

Fixed in Release 5.3.3+220307

Related Changesets

LimeSurvey: 3.x-LTS 2a4ed74c

2022-01-14 12:58

gabrieljenik

Committer: GitHub


Details Diff		 Fixed issue 17773: Code name change while we updated from Edit Question screen (#2201)

Co-authored-by: encuestabizdevgit <devgit@encuesta.biz>		 Affected Issues
17773
mod - application/config/version.php Diff File
mod - application/helpers/update/updatedb_helper.php Diff File
mod - application/views/admin/labels/_labelviewtabcontent_view.php Diff File
mod - application/views/admin/survey/Question/question_subviews/_modals.twig Diff File
mod - assets/scripts/admin/answers.js Diff File
mod - installer/create-database.php Diff File

LimeSurvey: master 2e2ccb23

2022-01-24 20:18

gabrieljenik


Details Diff		 Fixed issue 17773: Code name change while we updated from Edit Question screen Affected Issues
17773
mod - application/config/version.php Diff File
mod - application/helpers/update/updatedb_helper.php Diff File
mod - application/views/admin/labels/_labelviewtabcontent_view.php Diff File
mod - application/views/questionAdministration/modals.twig Diff File
mod - assets/scripts/admin/questionEditor.js Diff File
mod - installer/create-database.php Diff File

LimeSurvey: master 13826d67

2022-03-03 20:56

gabrieljenik

Committer: GitHub


Details Diff		 Merge pull request #2217 from gabrieljenik/bug/17773-master--Code-name-change-while-we-updated-from-Edit-Question-screen

Fixed issue 17773: Code name change while we updated from Edit Question screen		 Affected Issues
17773
mod - application/config/version.php Diff File
add - application/helpers/update/updates/Update_483.php Diff File
mod - application/views/admin/labels/_labelviewtabcontent_view.php Diff File
mod - application/views/questionAdministration/modals.twig Diff File
mod - assets/scripts/admin/questionEditor.js Diff File
mod - installer/create-database.php Diff File

Issue History

Date Modified Username Field Change
2021-12-02 13:29 Hiccup New Issue
2021-12-02 13:29 Hiccup File Added: Screenshot_1438.png
2021-12-02 13:29 Hiccup File Added: Screenshot_1437.png
2021-12-02 13:29 Hiccup File Added: limesurvey_survey_413621.lss
2021-12-02 13:46 Mazi Note Added: 67651
2021-12-02 13:46 Mazi File Added: image.png
2021-12-02 13:46 Mazi File Added: image-2.png
2021-12-02 17:01 Hiccup Note Added: 67658
2021-12-02 17:29 c_schmitz Description Updated
2021-12-02 17:29 c_schmitz Steps to Reproduce Updated
2021-12-02 17:30 c_schmitz File Deleted: Screenshot_1438.png
2021-12-02 17:30 c_schmitz File Deleted: Screenshot_1437.png
2021-12-02 17:30 c_schmitz Project Development => Bug reports
2021-12-02 19:36 guest Bug heat 4 => 10
2021-12-14 13:18 galads Assigned To => galads
2021-12-14 13:18 galads Status new => confirmed
2021-12-14 13:18 galads Complete LimeSurvey version number (& build) => LS3
2021-12-14 13:18 galads Zoho Project Synchronization => |Yes|
2022-01-06 17:24 gabrieljenik Note Added: 67936
2022-01-06 17:24 gabrieljenik Bug heat 10 => 12
2022-01-06 17:24 gabrieljenik Note Edited: 67936
2022-01-14 11:58 gabrieljenik Changeset attached => LimeSurvey 3.x-LTS 2a4ed74c
2022-01-14 11:58 gabrieljenik Note Added: 68000
2022-01-14 11:58 gabrieljenik Assigned To galads => gabrieljenik
2022-01-14 11:58 gabrieljenik Resolution open => fixed
2022-01-18 10:54 LimeBot Zoho Project Synchronization Yes => |Yes|
2022-01-18 10:54 LimeBot Note Added: 68046
2022-01-18 10:54 LimeBot Status confirmed => closed
2022-01-18 10:54 LimeBot Bug heat 12 => 14
2022-02-09 14:40 c_schmitz Status closed => assigned
2022-02-09 14:40 c_schmitz Note Added: 68255
2022-02-09 14:40 c_schmitz Bug heat 14 => 16
2022-02-23 13:00 gabrieljenik Note Added: 68383
2022-02-23 13:01 gabrieljenik Note Edited: 68383
2022-03-03 19:56 gabrieljenik Changeset attached => LimeSurvey master 13826d67
2022-03-03 19:56 gabrieljenik Changeset attached => LimeSurvey master 2e2ccb23
2022-03-03 19:56 gabrieljenik Note Added: 68534
2022-03-07 10:14 LimeBot Zoho Project Synchronization Yes => |Yes|
2022-03-07 10:14 LimeBot Note Added: 68548
2022-03-07 10:14 LimeBot Status assigned => closed