View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
17751 | Bug reports | Data Entry (non public) | public | 2021-11-22 16:46 | 2022-01-24 15:26 |
Reporter | DenisChenu | Assigned To | DenisChenu | ||
Priority | none | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 3.25.20 | ||||
Summary | 17751: Date stamped throw php notice when data edit and debug | ||||
Description | When try to edit existing respoinse in data edit and stamped survey : throw PHP Notice | ||||
Steps To Reproduce | Steps to reproduce
Expected resultWork Actual resultThrow PHP Notice | ||||
Tags | No tags attached. | ||||
Attached Files | |||||
Bug heat | 6 | ||||
Complete LimeSurvey version number (& build) | 3.27.25 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | not relevant | ||||
Database type & version | not relevant | ||||
Server OS (if known) | not relevant | ||||
Webserver software & version (if known) | not relevant | ||||
PHP Version | not relevant | ||||
5.X have same issue PHP notice.html (19,558 bytes)
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en"><head> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> <title>PHP notice</title> <style type="text/css"> /*<![CDATA[*/ html,body,div,span,applet,object,iframe,h1,h2,h3,h4,h5,h6,p,blockquote,pre,a,abbr,acronym,address,big,cite,code,del,dfn,em,font,img,ins,kbd,q,s,samp,small,strike,strong,sub,sup,tt,var,b,u,i,center,dl,dt,dd,ol,ul,li,fieldset,form,label,legend,table,caption,tbody,tfoot,thead,tr,th,td{border:0;outline:0;font-size:100%;vertical-align:baseline;background:transparent;margin:0;padding:0;} body{line-height:1;} ol,ul{list-style:none;} blockquote,q{quotes:none;} blockquote:before,blockquote:after,q:before,q:after{content:none;} :focus{outline:0;} ins{text-decoration:none;} del{text-decoration:line-through;} table{border-collapse:collapse;border-spacing:0;} body { font: normal 9pt "Verdana"; color: #000; background: #fff; } h1 { font: normal 18pt "Verdana"; color: #f00; margin-bottom: .5em; } h2 { font: normal 14pt "Verdana"; color: #800000; margin-bottom: .5em; } h3 { font: bold 11pt "Verdana"; } pre { font: normal 11pt Menlo, Consolas, "Lucida Console", Monospace; } pre span.error { display: block; background: #fce3e3; } pre span.ln { color: #999; padding-right: 0.5em; border-right: 1px solid #ccc; } pre span.error-ln { font-weight: bold; } .container { margin: 1em 4em; } .version { color: gray; font-size: 8pt; border-top: 1px solid #aaa; padding-top: 1em; margin-bottom: 1em; } .message { color: #000; padding: 1em; font-size: 11pt; background: #f3f3f3; -webkit-border-radius: 10px; -moz-border-radius: 10px; border-radius: 10px; margin-bottom: 1em; line-height: 160%; } .source { margin-bottom: 1em; } .code pre { background-color: #ffe; margin: 0.5em 0; padding: 0.5em; line-height: 125%; border: 1px solid #eee; } .source .file { margin-bottom: 1em; font-weight: bold; } .traces { margin: 2em 0; } .trace { margin: 0.5em 0; padding: 0.5em; } .trace.app { border: 1px dashed #c00; } .trace .number { text-align: right; width: 2em; padding: 0.5em; } .trace .content { padding: 0.5em; } .trace .plus, .trace .minus { display:inline; vertical-align:middle; text-align:center; border:1px solid #000; color:#000; font-size:10px; line-height:10px; margin:0; padding:0 1px; width:10px; height:10px; } .trace.collapsed .minus, .trace.expanded .plus, .trace.collapsed pre { display: none; } .trace-file { cursor: pointer; padding: 0.2em; } .trace-file:hover { background: #f0ffff; } /*]]>*/ </style> </head> <body> <div class="container"> <h1>PHP notice</h1> <p class="message"> Trying to access array offset on value of type int </p> <div class="source"> <p class="file">/data/webdev/3LTS/application/controllers/admin/dataentry.php(1433)</p> <div class="code"><pre><span class="ln">1421</span> $thisvalue = dateShift(date("Y-m-d H:i"), "Y-m-d\TH:i", Yii::app()->getConfig('timeadjust')); <span class="ln">1422</span> } else { <span class="ln">1423</span> $thisvalue = date("Y-m-d\TH:i", (int) mktime(0, 0, 0, 1, 1, 1980)); <span class="ln">1424</span> } <span class="ln">1425</span> } <span class="ln">1426</span> case 'startdate': <span class="ln">1427</span> case 'datestamp': <span class="ln">1428</span> if(empty($thisvalue)) { <span class="ln">1429</span> $oReponse->$fieldname = null; <span class="ln">1430</span> break; <span class="ln">1431</span> } <span class="ln">1432</span> $dateformatdetails = getDateFormatForSID($surveyid); <span class="error"><span class="ln error-ln">1433</span> $datetimeobj = DateTime::createFromFormat('!'.$dateformatdetails['phpdate'], $thisvalue); </span><span class="ln">1434</span> if (!$datetimeobj) { <span class="ln">1435</span> /* Not able to use js system */ <span class="ln">1436</span> $datetimeobj = DateTime::createFromFormat('Y-m-d\TH:i', $thisvalue); <span class="ln">1437</span> } <span class="ln">1438</span> if ($datetimeobj) { <span class="ln">1439</span> $oReponse->$fieldname = $datetimeobj->format('Y-m-d H:i'); <span class="ln">1440</span> } else { <span class="ln">1441</span> Yii::app()->setFlashMessage(sprintf(gT("Invalid datetime %s value for %s"),htmlentities($thisvalue),$fieldname), 'warning'); <span class="ln">1442</span> if($irow['type'] != 'submitdate') { <span class="ln">1443</span> $oReponse->$fieldname = date("Y-m-d H:i:s");// Need not null value <span class="ln">1444</span> } else { <span class="ln">1445</span> $oReponse->$fieldname = null; </pre></div> </div> <div class="traces"> <h2>Stack Trace</h2> <table style="width:100%;"> <tbody><tr class="trace core collapsed"> <td class="number"> #0 </td> <td class="content"> <div class="trace-file"> unknown(0): <strong>dataentry</strong>-><strong>update</strong>() </div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #1 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /data/webdev/3LTS/framework/web/actions/CAction.php(115): <strong>ReflectionMethod</strong>-><strong>invokeArgs</strong>(dataentry, array()) </div> <div class="code"><pre><span class="ln">110</span> elseif($param->isDefaultValueAvailable()) <span class="ln">111</span> $ps[]=$param->getDefaultValue(); <span class="ln">112</span> else <span class="ln">113</span> return false; <span class="ln">114</span> } <span class="error"><span class="ln error-ln">115</span> $method->invokeArgs($object,$ps); </span><span class="ln">116</span> return true; <span class="ln">117</span> } <span class="ln">118</span> } </pre></div> </td> </tr> <tr class="trace app expanded"> <td class="number"> #2 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /data/webdev/3LTS/application/core/Survey_Common_Action.php(83): <strong>CAction</strong>-><strong>runWithParamsInternal</strong>(dataentry, ReflectionMethod, array("r" => "admin/dataentry/sa/update", "sa" => "update", "iId" => "1", "iSurveyId" => "592229", ...)) </div> <div class="code"><pre><span class="ln">78</span> $oMethod = new ReflectionMethod($this, $sDefault); <span class="ln">79</span> } <span class="ln">80</span> <span class="ln">81</span> // We're all good to go, let's execute it <span class="ln">82</span> // runWithParamsInternal would automatically get the parameters of the method and populate them as required with the params <span class="error"><span class="ln error-ln">83</span> return parent::runWithParamsInternal($this, $oMethod, $params); </span><span class="ln">84</span> } <span class="ln">85</span> <span class="ln">86</span> /** <span class="ln">87</span> * Some functions have different parameters, which are just an alias of the <span class="ln">88</span> * usual parameters we're getting in the url. This function just populates </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #3 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /data/webdev/3LTS/framework/web/CController.php(308): <strong>Survey_Common_Action</strong>-><strong>runWithParams</strong>(array("r" => "admin/dataentry/sa/update", "sa" => "update", "iId" => "1", "iSurveyId" => "592229", ...)) </div> <div class="code"><pre><span class="ln">303</span> { <span class="ln">304</span> $priorAction=$this->_action; <span class="ln">305</span> $this->_action=$action; <span class="ln">306</span> if($this->beforeAction($action)) <span class="ln">307</span> { <span class="error"><span class="ln error-ln">308</span> if($action->runWithParams($this->getActionParams())===false) </span><span class="ln">309</span> $this->invalidActionParams($action); <span class="ln">310</span> else <span class="ln">311</span> $this->afterAction($action); <span class="ln">312</span> } <span class="ln">313</span> $this->_action=$priorAction; </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #4 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /data/webdev/3LTS/framework/web/CController.php(286): <strong>CController</strong>-><strong>runAction</strong>(dataentry) </div> <div class="code"><pre><span class="ln">281</span> * @see runAction <span class="ln">282</span> */ <span class="ln">283</span> public function runActionWithFilters($action,$filters) <span class="ln">284</span> { <span class="ln">285</span> if(empty($filters)) <span class="error"><span class="ln error-ln">286</span> $this->runAction($action); </span><span class="ln">287</span> else <span class="ln">288</span> { <span class="ln">289</span> $priorAction=$this->_action; <span class="ln">290</span> $this->_action=$action; <span class="ln">291</span> CFilterChain::create($this,$action,$filters)->run(); </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #5 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /data/webdev/3LTS/framework/web/CController.php(265): <strong>CController</strong>-><strong>runActionWithFilters</strong>(dataentry, array()) </div> <div class="code"><pre><span class="ln">260</span> { <span class="ln">261</span> if(($parent=$this->getModule())===null) <span class="ln">262</span> $parent=Yii::app(); <span class="ln">263</span> if($parent->beforeControllerAction($this,$action)) <span class="ln">264</span> { <span class="error"><span class="ln error-ln">265</span> $this->runActionWithFilters($action,$this->filters()); </span><span class="ln">266</span> $parent->afterControllerAction($this,$action); <span class="ln">267</span> } <span class="ln">268</span> } <span class="ln">269</span> else <span class="ln">270</span> $this->missingAction($actionID); </pre></div> </td> </tr> <tr class="trace app expanded"> <td class="number"> #6 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /data/webdev/3LTS/application/controllers/AdminController.php(165): <strong>CController</strong>-><strong>run</strong>("dataentry") </div> <div class="code"><pre><span class="ln">160</span> $this->redirect(array('/admin/authentication/sa/login')); <span class="ln">161</span> } <span class="ln">162</span> } <span class="ln">163</span> } <span class="ln">164</span> <span class="error"><span class="ln error-ln">165</span> return parent::run($action); </span><span class="ln">166</span> } <span class="ln">167</span> <span class="ln">168</span> /** <span class="ln">169</span> * Routes all the actions to their respective places <span class="ln">170</span> * </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #7 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /data/webdev/3LTS/framework/web/CWebApplication.php(282): <strong>AdminController</strong>-><strong>run</strong>("dataentry") </div> <div class="code"><pre><span class="ln">277</span> { <span class="ln">278</span> list($controller,$actionID)=$ca; <span class="ln">279</span> $oldController=$this->_controller; <span class="ln">280</span> $this->_controller=$controller; <span class="ln">281</span> $controller->init(); <span class="error"><span class="ln error-ln">282</span> $controller->run($actionID); </span><span class="ln">283</span> $this->_controller=$oldController; <span class="ln">284</span> } <span class="ln">285</span> else <span class="ln">286</span> throw new CHttpException(404,Yii::t('yii','Unable to resolve the request "{route}".', <span class="ln">287</span> array('{route}'=>$route===''?$this->defaultController:$route))); </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #8 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /data/webdev/3LTS/framework/web/CWebApplication.php(141): <strong>CWebApplication</strong>-><strong>runController</strong>("admin/dataentry/sa/update") </div> <div class="code"><pre><span class="ln">136</span> foreach(array_splice($this->catchAllRequest,1) as $name=>$value) <span class="ln">137</span> $_GET[$name]=$value; <span class="ln">138</span> } <span class="ln">139</span> else <span class="ln">140</span> $route=$this->getUrlManager()->parseUrl($this->getRequest()); <span class="error"><span class="ln error-ln">141</span> $this->runController($route); </span><span class="ln">142</span> } <span class="ln">143</span> <span class="ln">144</span> /** <span class="ln">145</span> * Registers the core application components. <span class="ln">146</span> * This method overrides the parent implementation by registering additional core components. </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #9 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /data/webdev/3LTS/framework/base/CApplication.php(185): <strong>CWebApplication</strong>-><strong>processRequest</strong>() </div> <div class="code"><pre><span class="ln">180</span> public function run() <span class="ln">181</span> { <span class="ln">182</span> if($this->hasEventHandler('onBeginRequest')) <span class="ln">183</span> $this->onBeginRequest(new CEvent($this)); <span class="ln">184</span> register_shutdown_function(array($this,'end'),0,false); <span class="error"><span class="ln error-ln">185</span> $this->processRequest(); </span><span class="ln">186</span> if($this->hasEventHandler('onEndRequest')) <span class="ln">187</span> $this->onEndRequest(new CEvent($this)); <span class="ln">188</span> } <span class="ln">189</span> <span class="ln">190</span> /** </pre></div> </td> </tr> <tr class="trace app expanded"> <td class="number"> #10 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /data/webdev/3LTS/index.php(194): <strong>CApplication</strong>-><strong>run</strong>() </div> <div class="code"><pre><span class="ln">189</span> require_once APPPATH . 'core/LSYii_Application' . EXT; <span class="ln">190</span> <span class="ln">191</span> $config = require_once(APPPATH . 'config/internal' . EXT); <span class="ln">192</span> <span class="ln">193</span> Yii::$enableIncludePath = false; <span class="error"><span class="ln error-ln">194</span> Yii::createApplication('LSYii_Application', $config)->run(); </span><span class="ln">195</span> <span class="ln">196</span> /* End of file index.php */ <span class="ln">197</span> /* Location: ./index.php */ </pre></div> </td> </tr> </tbody></table> </div> <div class="version"> 2021-11-22 16:46:32 nginx/1.18.0 <a href="http://www.yiiframework.com/">Yii Framework</a>/1.1.24-dev </div> </div> <script type="text/javascript"> /*<![CDATA[*/ var traceReg = new RegExp("(^|\\s)trace-file(\\s|$)"); var collapsedReg = new RegExp("(^|\\s)collapsed(\\s|$)"); var e = document.getElementsByTagName("div"); for(var j=0,len=e.length;j<len;j++){ if(traceReg.test(e[j].className)){ e[j].onclick = function(){ var trace = this.parentNode.parentNode; if(collapsedReg.test(trace.className)) trace.className = trace.className.replace("collapsed", "expanded"); else trace.className = trace.className.replace("expanded", "collapsed"); } } } /*]]>*/ </script> <table class="yiiLog" style="border-spacing:1px;font:11px Verdana, Arial, Helvetica, sans-serif;background:#EEEEEE;color:#666666;" width="100%" cellpadding="2"> <tbody><tr> <th style="background:black;color:white;" colspan="5"> Journal d'application </th> </tr> <tr style="background-color: #ccc;"> <th style="width:120px">Heure</th> <th>Niveau</th> <th>Categorie</th> <th>Message</th> </tr> <tr style="background:#FFC0CB"> <td align="center">16:46:32.770771</td> <td>error</td> <td>php</td> <td><pre>Trying to access array offset on value of type int (/data/webdev/3LTS/application/controllers/admin/dataentry.php:1433) Stack trace: #0 /data/webdev/3LTS/application/core/Survey_Common_Action.php(83): dataentry->runWithParamsInternal() #1 /data/webdev/3LTS/framework/web/CController.php(308): dataentry->runWithParams() #2 /data/webdev/3LTS/framework/web/CController.php(286): AdminController->runAction() #3 /data/webdev/3LTS/framework/web/CController.php(265): AdminController->runActionWithFilters() #4 /data/webdev/3LTS/application/controllers/AdminController.php(165): AdminController->run() #5 /data/webdev/3LTS/framework/web/CWebApplication.php(282): AdminController->run() #6 /data/webdev/3LTS/framework/web/CWebApplication.php(141): LSYii_Application->runController() #7 /data/webdev/3LTS/framework/base/CApplication.php(185): LSYii_Application->processRequest() #8 /data/webdev/3LTS/index.php(194): LSYii_Application->run() REQUEST_URI=/3LTS/index.php?r=admin/dataentry/sa/update</pre></td> </tr></tbody></table> <!-- end of log messages --><div id="grammalecte_menu_main_button_shadow_host" style="width: 0px; height: 0px;"></div></body><script src="PHP%20notice_fichiers/api.js"></script></html> <!-- start log messages --> |
|
Issue related : no date format set in data edit |
|
Other related issue in data edit :
Need another report ? PS2 : same with datestamp |
|
We can have only one report for this. Thank you @DenisChenu |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=33085 |
|
Bugfix for 3.X : https://github.com/LimeSurvey/LimeSurvey/pull/2188 |
|
Fixed in Release 5.2.9+220110 |
|
Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=33115 |
|
LimeSurvey: master 16d809ea 2022-01-05 09:54 Committer: GitHub Details Diff |
Fixed issue 17751: Date stamped throw php notice when data edit and debug (#2189) * Fixed issue 17751: Date stamped throw php notice when data edit and debug Dev: same fix than 3.X * Dev: WTF PHP Parse error ? * Dev: php CS partial * Dev: same function but with more line feed * Dev: got it ! |
Affected Issues 17751 |
|
mod - application/controllers/admin/dataentry.php | Diff File | ||
LimeSurvey: 3.x-LTS e4f2fff1 2022-01-24 16:26 Committer: GitHub Details Diff |
Fixed issue 17751: Date stamped throw php notice when data edit and debug (#2188) * Fixed issue 17751: Date stamped throw php notice when data edit and debug * Dev: Fix we need a value in all condition . * Dev: CI happy |
Affected Issues 17751 |
|
mod - application/controllers/admin/dataentry.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2021-11-22 16:46 | DenisChenu | New Issue | |
2021-11-22 16:46 | DenisChenu | File Added: survey_archive_dateStamped.lsa | |
2021-11-22 16:47 | DenisChenu | Note Added: 67477 | |
2021-11-22 16:47 | DenisChenu | File Added: PHP notice.html | |
2021-11-22 16:47 | DenisChenu | Bug heat | 0 => 2 |
2021-11-22 16:50 | DenisChenu | Note Added: 67478 | |
2021-11-22 16:50 | DenisChenu | File Added: Capture d’écran du 2021-11-22 16-50-10.png | |
2021-11-23 10:11 | galads | Assigned To | => galads |
2021-11-23 10:11 | galads | Status | new => confirmed |
2021-11-23 11:29 | DenisChenu | Note Added: 67493 | |
2021-11-23 11:29 | DenisChenu | Note Edited: 67493 | |
2021-11-23 11:50 | galads | Note Added: 67495 | |
2021-11-23 11:50 | galads | Bug heat | 2 => 4 |
2021-11-23 11:50 | galads | Zoho Project Synchronization | => |Yes| |
2022-01-05 08:54 | DenisChenu | Changeset attached | => LimeSurvey master 16d809ea |
2022-01-05 08:54 | DenisChenu | Note Added: 67897 | |
2022-01-05 08:54 | DenisChenu | Assigned To | galads => DenisChenu |
2022-01-05 08:54 | DenisChenu | Resolution | open => fixed |
2022-01-05 17:49 | DenisChenu | Note Added: 67929 | |
2022-01-10 14:40 | LimeBot | Zoho Project Synchronization | Yes => |Yes| |
2022-01-10 14:40 | LimeBot | Note Added: 67941 | |
2022-01-10 14:40 | LimeBot | Status | confirmed => closed |
2022-01-10 14:40 | LimeBot | Bug heat | 4 => 6 |
2022-01-24 15:26 | DenisChenu | Changeset attached | => LimeSurvey 3.x-LTS e4f2fff1 |
2022-01-24 15:26 | DenisChenu | Note Added: 68078 |