View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 12
IDProjectCategoryView StatusDate SubmittedLast Update
17725Bug reportsTheme editorpublic2021-11-17 11:122022-01-05 09:30
Reporterbaltzis Assigned Togabrieljenik  
PrioritynoneSeveritytext 
Status closedResolutionfixed 
Product Version5.2.x 
Summary17725: Unclear error message
Description

In case php_fileinfo.dll is not activated, it is not possible to upload images from within theme options (global or surveys). The error message returned, in this case, is not clear:
"This file is not a supported image format - only the following ones are allowed: GIF, ICO, JPG, PNG".

A better message might be:
"No way to check image file"

Steps To Reproduce

Steps to reproduce

  1. Deactivate php_fileinfo.dll
  2. Try to upload an image either in Configuration/Themes/Theme options or within any survey Settings/Theme options

Expected result

Error message: "This file is not a supported image format - only the following ones are allowed: GIF, ICO, JPG, PNG".

Actual result

Error message: "This file is not a supported image format - only the following ones are allowed: GIF, ICO, JPG, PNG".

TagsNo tags attached.
Bug heat12
Complete LimeSurvey version number (& build)5.2.2+211115
I will donate to the project if issue is resolvedNo
Browser
Database type & versionmysql, mysqlnd 5.0.12-dev - 20150407 - $Id: 38fea24f2847fa7519001be390c98ae0acafe387 $
Server OS (if known)
Webserver software & version (if known)
PHP Version7.2.7

Users monitoring this issue

DenisChenu

Activities

galads

galads

2021-11-17 13:57

reporter   ~67401

Hello, there is no difference btw the expected result and the actual result. Seems you made a mistake in the text.
c_schmitz

c_schmitz

2021-11-17 14:12

administrator   ~67403

Last edited: 2021-11-17 15:59

It looks like the php_fileinfo is not activated by default in Windows.
We need to add this to installer requirements and add a better error message.
DenisChenu

DenisChenu

2021-11-17 15:41

developer   ~67406

Last edited: 2021-11-17 15:59

We need to add this to installer requirements and add a better error message.

great ! Thanks

(PS : i don't think it was activated by default on quick LAMP install oin Linux Server)
gabrieljenik

gabrieljenik

2021-12-07 15:11

manager   ~67732

PR: https://github.com/LimeSurvey/LimeSurvey/pull/2171

I would also add some validation before.

For example, the Upload button is disabled, with a tooltip explaining why.

The issue is that you have to do it in all the different places where you can upload files.
gabrieljenik

gabrieljenik

2021-12-21 16:14

manager   ~67832

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=33068
LimeBot

LimeBot

2022-01-05 09:30

administrator   ~67905

Fixed in Release 5.2.8+220103

Related Changesets

LimeSurvey: master 55deb699

2021-12-21 17:14

gabrieljenik

Committer: GitHub


Details Diff		 Fixed issue 17725: Unclear error message (#2171)

* Fixed issue 17725: Unclear error message

- Change error message when fileinfo is missing
- Added fileinfo to Installer requirements

* Fixed issue 17725: Unclear error message

- Fixed message

Co-authored-by: encuestabizdevgit <devgit@encuesta.biz>		 Affected Issues
17725
mod - application/core/LSYii_ImageValidator.php Diff File
mod - application/models/InstallerConfigForm.php Diff File
mod - application/views/installer/precheck_view.php Diff File

Issue History

Date Modified Username Field Change
2021-11-17 11:12 baltzis New Issue
2021-11-17 11:36 DenisChenu Issue Monitored: DenisChenu
2021-11-17 11:36 DenisChenu Bug heat 0 => 2
2021-11-17 13:57 galads Note Added: 67401
2021-11-17 13:57 galads Bug heat 2 => 4
2021-11-17 14:12 c_schmitz Note Added: 67403
2021-11-17 14:12 c_schmitz Bug heat 4 => 6
2021-11-17 15:41 DenisChenu Note Added: 67406
2021-11-17 15:41 DenisChenu Bug heat 6 => 8
2021-11-17 15:59 galads Zoho Project Synchronization => |Yes|
2021-11-17 16:00 galads Assigned To => galads
2021-11-17 16:00 galads Status new => confirmed
2021-12-07 15:11 gabrieljenik Note Added: 67732
2021-12-07 15:11 gabrieljenik Bug heat 8 => 10
2021-12-21 16:14 gabrieljenik Changeset attached => LimeSurvey master 55deb699
2021-12-21 16:14 gabrieljenik Note Added: 67832
2021-12-21 16:14 gabrieljenik Assigned To galads => gabrieljenik
2021-12-21 16:14 gabrieljenik Resolution open => fixed
2021-12-21 16:29 galads Status confirmed => resolved
2022-01-05 09:30 LimeBot Zoho Project Synchronization Yes => |Yes|
2022-01-05 09:30 LimeBot Note Added: 67905
2022-01-05 09:30 LimeBot Status resolved => closed
2022-01-05 09:30 LimeBot Bug heat 10 => 12