View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
17663 | Bug reports | Survey editing | public | 2021-10-15 17:19 | 2023-09-28 14:31 |
Reporter | matte1 | Assigned To | galads | ||
Priority | none | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 5.x | ||||
Summary | 17663: Location components save settings works with inverted logic | ||||
Description | When you select "yes" in the settings "Save {location component}" (e.g. postal code) the component is not saved, if it is set to no, it is saved. Inspecting files application/helpers/qanda_helper.php and assets/scripts/map.js you can see that in maps.js there are wrong checks. https://github.com/LimeSurvey/LimeSurvey/blob/94c20a6f292d2dc2cd634fa1de4796f7579b7e67/application/helpers/qanda_helper.php | ||||
Steps To Reproduce | Steps to reproduceSet "Yes" in any "Save {location component}" Expected resultComponent is saved when setting "Yes", not saved when setting "No" Actual resultWhen set to Yes, component is not saved. | ||||
Tags | map, questions | ||||
Bug heat | 8 | ||||
Complete LimeSurvey version number (& build) | 5.1.15 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | |||||
Database type & version | MySQL 5.7.35 | ||||
Server OS (if known) | |||||
Webserver software & version (if known) | |||||
PHP Version | 8.0.11 | ||||
if it can be useful here is a PR to solve it: |
|
Thank you for the PR, I will move the task to "testing" and we will test according to priority. |
|
This was merged long time ago https://github.com/LimeSurvey/LimeSurvey/pull/2099 Nov 5, 2021. |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2021-10-15 17:19 | matte1 | New Issue | |
2021-10-15 17:31 | matte1 | Tag Attached: map | |
2021-10-15 17:31 | matte1 | Tag Attached: questions | |
2021-10-15 17:31 | matte1 | Issue Monitored: matte1 | |
2021-10-15 17:31 | matte1 | Bug heat | 0 => 2 |
2021-10-16 16:40 | galads | Assigned To | => galads |
2021-10-16 16:40 | galads | Status | new => confirmed |
2021-10-18 07:56 | matte1 | Note Added: 66862 | |
2021-10-18 07:56 | matte1 | Bug heat | 2 => 4 |
2021-10-18 09:37 | galads | Note Added: 66864 | |
2021-10-18 09:37 | galads | Bug heat | 4 => 6 |
2021-10-18 09:37 | galads | Status | confirmed => ready for testing |
2021-10-18 09:37 | galads | Zoho Project Synchronization | => |Yes| |
2023-09-28 14:31 | tibor.pacalat | Status | ready for testing => closed |
2023-09-28 14:31 | tibor.pacalat | Resolution | open => fixed |
2023-09-28 14:31 | tibor.pacalat | Note Added: 77402 | |
2023-09-28 14:31 | tibor.pacalat | Bug heat | 6 => 8 |