View Issue Details

This bug affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
17663Bug reportsSurvey editingpublic2021-10-18 09:37
Reportermatte1 Assigned Togalads  
PrioritynoneSeverityminor 
Status testingResolutionopen 
Product Version5.x 
Summary17663: Location components save settings works with inverted logic
DescriptionWhen you select "yes" in the settings "Save {location component}" (e.g. postal code) the component is not saved, if it is set to no, it is saved.

Inspecting files application/helpers/qanda_helper.php and assets/scripts/map.js you can see that in maps.js there are wrong checks.

https://github.com/LimeSurvey/LimeSurvey/blob/94c20a6f292d2dc2cd634fa1de4796f7579b7e67/application/helpers/qanda_helper.php
https://github.com/LimeSurvey/LimeSurvey/blob/6437c998731e1e79da24c394ef205444cfa75cdf/assets/scripts/map.js#L399

Steps To ReproduceSteps to reproduce
------------------------------
Set "Yes" in any "Save {location component}"

Expected result
-------------------------
Component is saved when setting "Yes", not saved when setting "No"

Actual result
-----------------
When set to Yes, component is not saved.
When set to No, component is saved

Tagsmap, questions
Bug heat6
Complete LimeSurvey version number (& build)5.1.15
I will donate to the project if issue is resolvedNo
Browser
Database type & versionMySQL 5.7.35
Server OS (if known)
Webserver software & version (if known)
PHP Version8.0.11

Users monitoring this issue

User List matte1

Activities

matte1

matte1

2021-10-18 07:56

reporter   ~66862

if it can be useful here is a PR to solve it:
https://github.com/LimeSurvey/LimeSurvey/pull/2099
galads

galads

2021-10-18 09:37

administrator   ~66864

Last edited: 2021-10-18 09:37

Thank you for the PR, I will move the task to "testing" and we will test according to priority.

Issue History

Date Modified Username Field Change
2021-10-15 17:19 matte1 New Issue
2021-10-15 17:31 matte1 Tag Attached: map
2021-10-15 17:31 matte1 Tag Attached: questions
2021-10-15 17:31 matte1 Issue Monitored: matte1
2021-10-15 17:31 matte1 Bug heat 0 => 2
2021-10-16 16:40 galads Assigned To => galads
2021-10-16 16:40 galads Status new => confirmed
2021-10-18 07:56 matte1 Note Added: 66862
2021-10-18 07:56 matte1 Bug heat 2 => 4
2021-10-18 09:37 galads Note Added: 66864
2021-10-18 09:37 galads Bug heat 4 => 6
2021-10-18 09:37 galads Status confirmed => testing