Steps to reproduce

Open an affected survey. We do not know how to reproduce. Maybe it depends on the order of records in the database or on the relation of the number of questions in the question groups.

Expected result

The question groups in the statistics feature should be in the order of the question groups.

Actual result

The question groups are in a different order.

Guess:

The helper function "groupOrderThenQuestionOrder($a, $b)" defined in "application/helpers/common_helper.php" has an "if" clause which is never entered [1], so the sorting algorithm in [2] does not order by question group as the first criteria. It happens due to the fact that the array attribute "group_order" is neither in $a nor in $b (which are $rows).

In contrast to the attribute "question_order", the attribute "group_order" is in a subarray called "$group".

Therefore, the function should be as follows:

function groupOrderThenQuestionOrder($a, $b)
{
    if (isset($a->group['group_order']) && isset($b->group['group_order'])) {
        $GroupResult = strnatcasecmp($a->group['group_order'], $b->group['group_order']);
    } else {
        $GroupResult = "";
    }
    if ($GroupResult == 0) {
        $TitleResult = strnatcasecmp($a["question_order"], $b["qutoestion_order"]);
        return $TitleResult;
    }
    return $GroupResult;
}

When patching the function as mentioned above, the problem is gone. The problem looks the same as the one mentioned in [3].

[1] https://github.com/LimeSurvey/LimeSurvey/blob/master/application/helpers/common_helper.php#L847-L848
[2] https://github.com/LimeSurvey/LimeSurvey/blob/master/application/controllers/admin/statistics.php#L176
[3] https://forums.limesurvey.org/forum/design-issues/122203-statistics-weird-question-group-order-in-statistics-feature