Old issue or regression?

I think neither. Sounds like something new to me due to the rather special user behavior of opening the links from the index at new browser tabs.

I'm guessing old, then, if the same behaviour can be replicated in LS2 or 1.

Steps to reproduce added.

Steps to reproduce added incl. screenshots.

image001.jpg (33,067 bytes)   

image001.jpg (33,067 bytes)   

image002.jpg (10,090 bytes)   

image002.jpg (10,090 bytes)   

image003.jpg (42,830 bytes)   

image003.jpg (42,830 bytes)   

image004.jpg (29,695 bytes)   

image004.jpg (29,695 bytes)   

image005.jpg (16,416 bytes)   

image005.jpg (16,416 bytes)   

The index link MUST be used only with javascript : there are a POST action done. With open in new tab : you break the JS action, then nothing is submitted.

There are a POST action done with link.
We must disable the href, put a false href or (better) change the to an html button.

@DenisChenu, so if I get it right, the index is not designed to open other pages in additional tabs?

Can we make that work or is it a technical limitation?

Can we make that work or is it a technical limitation?

No : technical situation : open in new tab can not send other value , only GET value from the link.

I used <href="#0"> which does the job. Thanks. This solves the issue with the navigation bar.

But: If you have any Web-Link in a group of a survey and click on it, the data in the current page ist gone as well.
Imagine to have a 'table of contents' - page with URLS like
<a href="surveyhost.com/index.php/723728/lang/de/token/{TOKEN}/move/1">Contents</a>
<a href="surveyhost.com/index.php/723728/lang/de/token/{TOKEN}/move/2">Group 2</a>

and additional data to be entered in the same page. Then, after clicking one of the URL erases all entered data in that page.
This is a different but similar bug, isn't it?

No : use button if you want.

A link didn't submit data.

There still an issue

1. Page 1 , go to Page 2 with next : current page save
2. Page 2 : go to page 3 with open in new tab
3. In the new tab : go to page 1 with real index : data on page 1 disappear : in theory : data muts be here.

My opinion : there are an issue with move …
https://gifyu.com/image/Jukw

Its' surely hard to fix it.
1st step is to remove the href in index and use button

You can check it here: https://puhdlich.limequery.com/723728/lang/de/newtest/Y
Enter some data in "Inhaltsverzeichnis" comment-box, press the button "next", then "back": Text is there.
Click on the link in "Inhaltsverzeichnis" or "Gruppe 1" -> The comment box will erased - text is gone.

Can you check removing the move=X in url ?

Else : you can use <button type="submit" name="move" value="2" class="list-group-item index-item " >Test</button> but this submit current data :/

I cannot remove the move, since this is of course needed for jumping - but I checked ?move=1 against /move/1, but no difference.
I checked your button-code (see link of above for testing): The buttons does the job. You can jump to the same page and no data is lost.
Using the button for a table of contents will need a button layout to fit the new needs...

Just include this twig file : https://github.com/LimeSurvey/LimeSurvey/blob/master/themes/survey/vanilla/views/subviews/navigation/question_index_groups_buttons.twig

I ask you to test with javascript because this file was shown without javascript
https://github.com/LimeSurvey/LimeSurvey/blob/1ce953a23c6012b838b1826b41669d41522281ac/themes/survey/vanilla/views/subviews/navigation/navigator_complement.twig#L7

The identical twig-file is already included in my vanilla template.

Yes : but class hide it.

Else : i disable right click on top menu : no href, no open in new tab ;)
https://gitlab.com/SondagesPro/SurveyThemes/skelvanilla/-/commit/29e0cd92fdc6147ee7bdf4baeb634d280279f038

@galads, any ideas how you want to deal with this issue? It does not happen very often I assume but since the result is a data loss, I consider this rather urgent.

Fixed in SkelVanilla ;)

But better to fix it with button (need more css update)

@DeniChenu, unfortunetaly, not everyone is using SkellVanilla. Could your patch be applied to the core parent LS themes?

https://github.com/LimeSurvey/LimeSurvey/pull/2224

Agree with Denis that the solution is basically to prevent the index menu links from being opened in another tab.

What Denis proposes is to turn it into a button.
The problem is that if we turn it into a button we get into a mess with the CSS, and we can break the themes.

So, we removed the href and add tabindex=0 (because anchors without href are not included by default in the tabbing).

Don't know if it will be necessary to also add role="button".
Not greatly familiar with screen reader topic.

For a cleaner solution : need button tag and not a…

You copy my patch : why delete role="button" ?

Don't know if it will be necessary to also add role="button".
Not greatly familiar with screen reader topic.

… role are not made only for a11y , but a11y use it.

https://www.w3.org/WAI/PF/HTML/wiki/RoleAttribute
https://www.freecodecamp.org/news/html-role-attribute/

You copy my patch : why delete role="button" ?

We didn't copy it, but seems to be very similar :)
Will add the role as you mention

Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=33148

Fixed in Release 3.28.0+220215