Please try with latest version Release 5.1.5

We did try that ofcourse too (see above) - but just for completeness:

Update pgsql:host=localhost;port=5432;user=aaa;password=secret;dbname=aaa; with prefix :lime_ from 449 to 471
PHP Error[2]: Invalid argument supplied for foreach()
in file /var/www/virtual_hosts/bbb/docs/limesurvey5.1.5_210830/application/helpers/update/updatedb_helper.php at line 5131
#0 /var/www/virtual_hosts/bbb/docs/limesurvey5.1.5_210830/application/helpers/update/updatedb_helper.php(4937): decryptArchivedTables450()
#1 /var/www/virtual_hosts/bbb/docs/limesurvey5.1.5_210830/application/helpers/update/updatedb_helper.php(4653): updateEncryptedValues450()
#2 /var/www/virtual_hosts/bbb/docs/limesurvey5.1.5_210830/application/commands/UpdateDbCommand.php(45): db_upgrade_all()
#3 /var/www/virtual_hosts/bbb/docs/limesurvey5.1.5_210830/framework/console/CConsoleCommandRunner.php(71): UpdateDBCommand->run()
#4 /var/www/virtual_hosts/bbb/docs/limesurvey5.1.5_210830/framework/console/CConsoleApplication.php(92): CConsoleCommandRunner->run()
#5 /var/www/virtual_hosts/bbb/docs/limesurvey5.1.5_210830/framework/base/CApplication.php(185): ConsoleApplication->processRequest()
#6 /var/www/virtual_hosts/bbb/docs/limesurvey5.1.5_210830/application/commands/console.php(69): ConsoleApplication->run()

the function where it breaks did not change in between...

Are you running this with debug = 2 or = 0 in config.php?

this is with debug = 0 in config.php

Thank you.

FWIW ... var_dump($archivedTableSettingsArray); added just before the foreach loop - gives:

array(2) {
["enabled"]=>
string(1) "Y"
["columns"]=>
array(3) {
["firstname"]=>
string(1) "N"
["lastname"]=>
string(1) "N"
["email"]=>
string(1) "N"
}
}
array(0) {
}
NULL

A fix for this is already in progress as part of another task, we will give an update when it’s ready.

see https://bugs.limesurvey.org/view.php?id=17476

Message from reporter:

just checked with 5.1.7.

It unfortunately still does not work when it comes to updating the database - it now emits:

php limesurvey5.1.7210908/application/commands/console.php updatedb
Update pgsql:host=localhost;port=5432;user=aaa;password=secret;dbname=aaa; with prefix :lime from 449 to 472
PHP Error[8]: Undefined index: type
in file /var/www/virtual_hosts/bbb/docs/limesurvey5.1.7_210908/application/helpers/update/updatedb_helper.php at line 4708
#0 /var/www/virtual_hosts/bbb/docs/limesurvey5.1.7_210908/application/commands/UpdateDbCommand.php(45): db_upgrade_all()
#1 /var/www/virtual_hosts/bbb/docs/limesurvey5.1.7_210908/framework/console/CConsoleCommandRunner.php(71): UpdateDBCommand->run()
#2 /var/www/virtual_hosts/bbb/docs/limesurvey5.1.7_210908/framework/console/CConsoleApplication.php(92): CConsoleCommandRunner->run()
#3 /var/www/virtual_hosts/bbb/docs/limesurvey5.1.7_210908/framework/base/CApplication.php(185): ConsoleApplication->processRequest()
#4 /var/www/virtual_hosts/bbb/docs/limesurvey5.1.7_210908/application/commands/console.php(69): ConsoleApplication->run()

New version released.

Message from reporter:

Trying 5.1.9 it now emits:

php ls5/application/commands/console.php updatedb
Update pgsql:host=localhost;port=5432;user=aaa;password=secret;dbname=aaa; with prefix :lime_ from 449 to 472
PHP Error[8]: Undefined offset: 0
in file /var/www/virtual_hosts/bbb/docs/limesurvey5.1.9_210912/application/helpers/update/updatedb_helper.php at line 5265
#0 /var/www/virtual_hosts/bbb/docs/limesurvey5.1.9_210912/application/helpers/update/updatedb_helper.php(5023): decryptArchivedTables450()
#1 /var/www/virtual_hosts/bbb/docs/limesurvey5.1.9_210912/application/helpers/update/updatedb_helper.php(4714): updateEncryptedValues450()
#2 /var/www/virtual_hosts/bbb/docs/limesurvey5.1.9_210912/application/commands/UpdateDbCommand.php(45): db_upgrade_all()
#3 /var/www/virtual_hosts/bbb/docs/limesurvey5.1.9_210912/framework/console/CConsoleCommandRunner.php(71): UpdateDBCommand->run()
#4 /var/www/virtual_hosts/bbb/docs/limesurvey5.1.9_210912/framework/console/CConsoleApplication.php(92): CConsoleCommandRunner->run()
#5 /var/www/virtual_hosts/bbb/docs/limesurvey5.1.9_210912/framework/base/CApplication.php(185): ConsoleApplication->processRequest()
#6 /var/www/virtual_hosts/bbb/docs/limesurvey5.1.9_210912/application/commands/console.php(69): ConsoleApplication->run()

Providing the database would require me to deal with things that need to be anonymized before... so I'd like to prevent this.

However - I tried debugging it further and I guess I've found something (application/helpers/update/updatedb_helper.php):
[added some print_r() just before line 5265]

print_r($archivedTableSettings);
Array
(
[id] => 2
[survey_id] => 815967
[user_id] => 1
[tbl_name] => old_survey_815967_20210628225359
[tbl_type] => response
[created] => 2021-06-28 22:53:59.61645
[properties] => []
[attributes] =>
)

print_r($archivedTableSettingsProperties);
Array
(
)

So - $archivedTableSettingsProperties exists - but it does not have an index 0 (it's literally empty) - so it's at least clear why this error comes up.

Tried this now:

diff -Naur limesurvey5.1.9_210912.dist/application/helpers/update/updatedb_helper.php limesurvey5.1.9_210912/application/helpers/update/updatedb_helper.php
--- limesurvey5.1.9_210912.dist/application/helpers/update/updatedb_helper.php 2021-09-08 11:08:34.000000000 +0200
+++ limesurvey5.1.9_210912/application/helpers/update/updatedb_helper.php 2021-09-09 21:31:27.312118339 +0200
@@ -5213,7 +5213,7 @@
// recrypt tokens
if ($archivedTableSettings['tbl_type'] === 'token') {
// skip if the encryption status is unknown

• if (isset($archivedTableSettingsProperties) && $archivedTableSettingsProperties[0] !== 'unknown') {

• if (isset($archivedTableSettingsProperties[0]) && $archivedTableSettingsProperties[0] !== 'unknown') {
  $tokenencryptionoptions = $archivedTableSettingsProperties;

           // default attributes

  @@ -5262,7 +5262,7 @@
  }

   // recrypt responses // skip if the encryption status is unknown

• if ($archivedTableSettings['tbl_type'] === 'response' && isset($archivedTableSettingsProperties) && $archivedTableSettingsProperties[0] !== 'unknown') {
• if ($archivedTableSettings['tbl_type'] === 'response' && isset($archivedTableSettingsProperties[0]) && $archivedTableSettingsProperties[0] !== 'unknown') {
  $responsesCount = $oDB->createCommand()
  ->select('count(*)')
  ->from("{{{$archivedTableSettings['tbl_name']}}}")

and I do come past this error now... with:

php limesurvey5.1.9210912/application/commands/console.php updatedb
Update pgsql:host=localhost;port=5432;user=ls5user;password=ls5pass;dbname=ls5db; with prefix :lime from 449 to 472
Database has been successfully upgraded to version 472

Which looks good to me - at least a first glance.

Questions:
A) can this $archivedTableSettingsProperties be really that empty? Or is it maybe an errorneous result of something else not beeing OK?
B) is this test patch correct at all?

thanks...

Any chance that someone still could have a look into this?! I just tried 5.1.14 too - but the issue is still the same.
Thankyou!

FWIW... I just saw another recent commit which seems to deal with something similiar when upgrading an older db to 450.
Slightly different (better) approach to fix - but it's too about an obivously empty archivedTableSettingsProperties.

https://github.com/LimeSurvey/LimeSurvey/commit/20991add684a0a717deda5d66394b3382d5ff3c3

Hello,
we had internally marked this issue already solved, there were multiple tickets with the same problem and this one got lost on the way. We didn't get any further error reports regarding this issue.
As you have noticed, the fix that you linked should have resolved your issue. Can you confirm that this issue is still affecting you? And if yes, would be great if you could provide as with an updated error.

As to your questions:
A) yes, the value can be empty
B) the patch back then was incomplete, which is why we provided the fix that you linked

Just confirmed that this issue exists, we will update the code accordingly. The reason we no longer got bug reports is that if you are running in "config=0" mode the error will be ignored, which is fine in this case. However, the proper fix would be to replace "$archivedTableSettingsProperties[0]" with "reset($archivedTableSettingsProperties)", since we are working with a mix of normal arrays and associative once.

If you want it to work before update, replace the mentioned code accordingly or change debug mode to 0

Dear all,
just to be sure - the fix you're talking about was not yet committed - isn't it?
I'm asking, because the most recent release (5.1.16) still bails out there:

php limesurvey5.1.16211020/application/commands/console.php updatedb
Update pgsql:host=localhost;port=5432;user=ls5;password=x;dbname=ls5; with prefix :lime from 449 to 475
PHP Error[8]: Undefined offset: 0
in file /var/www/virtual_hosts/x/docs/limesurvey5.1.16_211020/application/helpers/update/updatedb_helper.php at line 5232
#0 /var/www/virtual_hosts/x/docs/limesurvey5.1.16_211020/application/helpers/update/updatedb_helper.php(5039): decryptArchivedTables450()
#1 /var/www/virtual_hosts/x/docs/limesurvey5.1.16_211020/application/helpers/update/updatedb_helper.php(4673): updateEncryptedValues450()
#2 /var/www/virtual_hosts/x/docs/limesurvey5.1.16_211020/application/commands/UpdateDbCommand.php(46): db_upgrade_all()
#3 /var/www/virtual_hosts/x/docs/limesurvey5.1.16_211020/framework/console/CConsoleCommandRunner.php(71): UpdateDBCommand->run()
#4 /var/www/virtual_hosts/x/docs/limesurvey5.1.16_211020/framework/console/CConsoleApplication.php(92): CConsoleCommandRunner->run()
#5 /var/www/virtual_hosts/x/docs/limesurvey5.1.16_211020/framework/base/CApplication.php(185): ConsoleApplication->processRequest()
#6 /var/www/virtual_hosts/x/docs/limesurvey5.1.16_211020/application/commands/console.php(69): ConsoleApplication->run()

FWIW - is there anything I can provide to get things sorted - apart from the whole database...?!
Maybe a dump of a specific table or whatever - please name it.
Thankyou!

Unfortunately, the fixed was never merged due to missing code review. We hope it will be included on Monday's release. Sorry for the delay.

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=32815