View Issue Details

This bug affects 1 person(s).
 4
IDProjectCategoryView StatusLast Update
17411Bug reportsErgonomypublic2021-06-30 09:13
ReporterDenisChenu Assigned To 
PrioritynoneSeverityminor 
Status newResolutionopen 
Product Version5.x 
Summary17411: No difference between Core questiontype and Question theme from core
DescriptionIn Question theme management : there are no difference between : core theme and Question theme from core
Steps To ReproduceGoes to question theme and look
Additional Information- core question theme (previously questiontype) : ./application/core/QuestionTypes/* : base ?
- question theme from core : ./themes/question/* core ?
- question theme from upload : ./upload/themes/question/* (OK : user)
TagsNo tags attached.
Bug heat4
Complete LimeSurvey version number (& build)5.0.6
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Relationships

related to 17379 resolvedgabrieljenik Development  Question types can be uninstalled 

Users monitoring this issue

User List There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2021-06-28 18:28

developer  

DenisChenu

DenisChenu

2021-06-28 18:30

developer   ~65147

Remind : some setup can come with own /themes/question/*
ollehar

ollehar

2021-06-29 16:55

administrator   ~65164

> Remind : some setup can come with own /themes/question/*

What?
DenisChenu

DenisChenu

2021-06-29 17:03

developer   ~65165

CE : user can add file easily in themes

For survey theme : it's the bet way to disable update of "default theme".

:)
ollehar

ollehar

2021-06-29 17:04

administrator   ~65166

Last edited: 2021-06-29 17:04

View 2 revisions

> CE : user can add file easily in themes

They can hack whatever they want. Not our problem. We can only guarantee functionality for non-hacking users.
DenisChenu

DenisChenu

2021-06-29 17:08

developer   ~65167

But clearly here : need a difference between question type and theme, no ?
ollehar

ollehar

2021-06-29 17:09

administrator   ~65168

"Core theme" should be "Custom theme" for built-in question themes, I guess. Then we need a way to explain it for users.
DenisChenu

DenisChenu

2021-06-29 17:15

developer   ~65169

I don't really like custom …

- core question theme (previously questiontype) : ./application/core/QuestionTypes/* : _core_ ?
- question theme from core : ./themes/question/* _custom_ ?
- question theme from upload : ./upload/themes/question/* _user_

PS : i think it's great to have a way to have
1. them from core
2. theme from instance (admin user can not update via GUI)
3. theme from upload (admin user can update via GUI)

But it's another feature here ;)
standardthemerooturl and standardthemerootdir
DenisChenu

DenisChenu

2021-06-29 17:16

developer   ~65170

>> Remind : some setup can come with own /themes/question/*

>What?

Oh : corequestionthemedir + corequestionthemerootdir : https://github.com/LimeSurvey/LimeSurvey/blob/2e126394a72efe81e20c3c4449d9ec5ef2e3eb97/application/config/config-defaults.php#L724-L725

and
questiontypedir https://github.com/LimeSurvey/LimeSurvey/blob/2e126394a72efe81e20c3c4449d9ec5ef2e3eb97/application/config/config-defaults.php#L727
ollehar

ollehar

2021-06-29 17:17

administrator   ~65171

You don't like the word "custom", or the concept of custom themes in the git repo?

You're right with your list, yes.

If I were to expand upon the question theme features, I'd rather integrate directly to LimeStore to get an "Install"-button without any manual ZIP download. And also allow for custom integrations, like to any git repo. "Add question theme git repo url: <bla bla>". Or better, extension git repo.
DenisChenu

DenisChenu

2021-06-30 09:13

developer   ~65172

For plugins : we use directory name ?

Plugin :
- core ./application/core/plugins
- user ./plugins
- upload ./upload/plugins

Why no for QuetsionTheme
- core : ./application/core/QuestionTypes/*
- themes : ./themes/question/*
- upload : ./upload/themes/question/

I know moving user to upload can be dangerous :(

Issue History

Date Modified Username Field Change
2021-06-28 18:28 DenisChenu New Issue
2021-06-28 18:28 DenisChenu File Added: Capture d’écran du 2021-06-28 17-12-55.png
2021-06-28 18:29 DenisChenu Relationship added related to 17379
2021-06-28 18:30 DenisChenu Note Added: 65147
2021-06-29 11:02 ollehar Product Version => 5.x
2021-06-29 16:55 ollehar Note Added: 65164
2021-06-29 17:03 DenisChenu Note Added: 65165
2021-06-29 17:04 ollehar Note Added: 65166
2021-06-29 17:04 ollehar Note Edited: 65166 View Revisions
2021-06-29 17:08 DenisChenu Note Added: 65167
2021-06-29 17:09 ollehar Note Added: 65168
2021-06-29 17:15 DenisChenu Note Added: 65169
2021-06-29 17:16 DenisChenu Note Added: 65170
2021-06-29 17:17 ollehar Note Added: 65171
2021-06-30 09:13 DenisChenu Note Added: 65172