View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 17380 | Bug reports | Other | public | 2021-06-22 14:57 | 2022-10-14 12:22 |
| Reporter | gabrieljenik | Assigned To | gabrieljenik | ||
| Priority | none | Severity | minor | ||
| Status | assigned | Resolution | open | ||
| Product Version | 4.x.0-dev | ||||
| Summary | 17380: Question theme has ambiguous columns | ||||
| Description | core_theme represents that is a theme delivered from LS. extends is overlapping with question_type. Probably should be a bool? | ||||
| Tags | No tags attached. | ||||
| Attached Files | |||||
| Bug heat | 6 | ||||
| Complete LimeSurvey version number (& build) | |||||
| I will donate to the project if issue is resolved | |||||
| Browser | |||||
| Database type & version | |||||
| Server OS (if known) | |||||
| Webserver software & version (if known) | |||||
| PHP Version | |||||
| Git branch / Pull Request URL | N/A | ||||
| related to | 17350 | closed | gabrieljenik | Question theme should be a separate database column, not an attribute |
| related to | 17411 | closed | c_schmitz | No difference between Core questiontype and Question theme from core |
|
core_theme should rather be theme_type, taking "core", "custom", and "user" as values. |
|
|
I think in some places in the code, it assumes core == 1 if extends == '' (empty string). So yeah. Needs to be reviewed. |
|
I suggest just changing the name of the columns, rather than changing its data contents. On the other side, what would be the difference in between "custom" and "user"? |
|
|
"custom" is built-in, inside the git repo BUT extending an existing theme. "user" is uploaded question theme, no in git repo. |
|
Change to what? |
|
|
core_theme -> standard |
|
|
Joinning the change of name I would add these to the class:
As well as new scopes for allowing better future usage What do you think? As per the extends column, the type should be reviewed, but I would do that on a different story |
|
|
Picking this up, this is our approach towards DB review. Rename “theme_type” to "type", and its values should be recoded to differentiate base themes (aka question types) from extended themes. What do you think? |
|
|
Remove "extends"? |
|
Yes, is redundant.
|
|
|
Bad DB design. but is the column name "extends" used in the core queries? Will, it not break something? |
|
|
To be updated after changes: https://manual.limesurvey.org/Database_documentation#question_themes |
|
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2021-06-22 14:57 | gabrieljenik | New Issue | |
| 2021-06-22 14:57 | gabrieljenik | File Added: image.png | |
| 2021-06-22 14:57 | gabrieljenik | Issue generated from: 17350 | |
| 2021-06-22 14:57 | gabrieljenik | Relationship added | related to 17350 |
| 2021-06-22 15:36 | ollehar | Note Added: 64975 | |
| 2021-06-22 15:36 | ollehar | Note Added: 64976 | |
| 2021-06-22 15:36 | ollehar | Note Edited: 64976 | |
| 2021-06-22 17:23 | gabrieljenik | Note Added: 64992 | |
| 2021-06-22 17:33 | ollehar | Note Added: 64993 | |
| 2021-06-22 17:33 | ollehar | Note Added: 64994 | |
| 2021-06-23 18:01 | gabrieljenik | Note Added: 65032 | |
| 2021-06-23 18:03 | gabrieljenik | Note Added: 65033 | |
| 2021-06-23 18:07 | gabrieljenik | Assigned To | => gabrieljenik |
| 2021-06-23 18:07 | gabrieljenik | Status | new => assigned |
| 2021-06-23 18:07 | LimeBot | Zoho Projects ID | => 85781000000987013 |
| 2021-12-07 15:36 | gabrieljenik | Note Added: 67734 | |
| 2021-12-07 15:36 | gabrieljenik | File Added: image-2.png | |
| 2021-12-07 15:37 | ollehar | Note Added: 67735 | |
| 2021-12-07 15:41 | gabrieljenik | Note Added: 67736 | |
| 2022-02-28 12:08 | galads | Note Added: 68421 | |
| 2022-06-01 00:51 | gabrieljenik | Relationship added | related to 17411 |
| 2022-10-14 12:22 | ollehar | Note Added: 72253 |