View Issue Details

This issue affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
17379Bug reportsOtherpublic2022-06-03 15:04
Reportergabrieljenik Assigned Togabrieljenik  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version4.x.0-dev 
Summary17379: Question types can be uninstalled
Description

Ussing the UI, Question Types can be uninstalled.
This is not intended, right?

TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build)
I will donate to the project if issue is resolved
Browser
Database type & version
Server OS (if known)
Webserver software & version (if known)
PHP Version
Git branch / Pull Request URLN/A

Relationships

related to 17350 closedgabrieljenik Question theme should be a separate database column, not an attribute 
related to 17411 closedc_schmitz No difference between Core questiontype and Question theme from core 

Users monitoring this issue

There are no users monitoring this issue.

Activities

ollehar

ollehar

2021-06-22 15:23

reporter   ~64974

Last edited: 2021-06-22 15:23

The answer is no for core/custom question themes, and yes for user question themes. That is, the built-in question themes can only be hidden, but not uninstalled. Because if you uninstall them, there's no way to install them again.

gabrieljenik

gabrieljenik

2021-06-28 15:58

developer   ~65128

PR: https://github.com/LimeSurvey/LimeSurvey/pull/1939

Added an error message when trying to uninstall a question type.

DenisChenu

DenisChenu

2021-06-28 16:06

developer   ~65129

?

I like to uninstall some core question type if there are no child and ,no existing survey with this question type.
This make really lighter drop-down wit only really used question-type.

If i remind : whole system came with this feature : system with only some used question type …

ollehar

ollehar

2021-06-28 16:09

reporter   ~65130

Last edited: 2021-06-28 16:09

No no no no. If you uninstall it, there's no way to install it again. Just hide it instead.

DenisChenu

DenisChenu

2021-06-28 16:31

developer   ~65131

If you uninstall it, there's no way to install it again

This is the issue : no ?

DenisChenu

DenisChenu

2021-06-28 16:33

developer   ~65132

Why not like Survey theme : you can uninstall Fruity, install it again (but not delete).

The only final issue are "What to do when import a lss with not found questiontype".

ollehar

ollehar

2021-06-28 16:44

reporter   ~65133

You can hide any question theme, including the core ones. That's good enough for now, I think.

DenisChenu

DenisChenu

2021-06-28 17:16

developer   ~65134

OK for Quetsion type.

Else : i don't find how to unistall browserdetect (for example) : core QuestionTheme.

Ans we must separate

  • core question theme (previously questiontype) : ./application/core/QuestionTypes/*
  • question theme from core : ./themes/question/*
  • question theme from upload : ./upload/themes/question/* (OK)
DenisChenu

DenisChenu

2021-06-28 17:16

developer   ~65135

DenisChenu

DenisChenu

2021-06-28 17:19

developer   ~65136

OK : only way seems to be checbox and actuion …

I really like to uninstall bootstrap_buttons for example …

gabrieljenik

gabrieljenik

2021-06-28 17:53

developer   ~65140

That is standard, but not core (not a question type). Should be uninstallable. Isn't it through mass actions?

ollehar

ollehar

2021-06-28 17:59

reporter   ~65141

Last edited: 2021-06-28 18:02

No, it should not be uninstallable. :) Nothing that can't be installed again should be possible to uninstall. It's a support ticket waiting to happen. That's the end goal: To avoid support.

DenisChenu

DenisChenu

2021-06-28 18:04

developer   ~65142

That is standard, but not core (not a question type).
I must report another issue

Isn't it through mass actions?
Yes found it after

Nothing that can't be installed again
The issue is not here ? Why didn't have like plugins a checkout directory to install new plugins ?
And what happen when you update an user theme by FTP (not upload system) ? No way to upgrade ?

DenisChenu

DenisChenu

2021-06-28 18:20

developer   ~65143

@ollehar : screenshot

Why you say it can not be installed after unistall ?

DenisChenu

DenisChenu

2021-06-28 18:25

developer   ~65145

Even with core … quetsion type

Uninstall, reload page, install : it work

DenisChenu

DenisChenu

2021-06-28 18:26

developer   ~65146

Please ! Allow uninstall core question :(

ollehar

ollehar

2021-06-28 20:58

reporter   ~65150

How did you install it? o0

ollehar

ollehar

2021-06-28 20:58

reporter   ~65151

Ah, shit, I didn't see that on my machine.

DenisChenu

DenisChenu

2021-06-29 08:46

developer   ~65153

I think you must uninstall , reload page after : the bottom are not reloaded after uninstall.

I can make a screencast if needed

gabrieljenik

gabrieljenik

2021-06-29 15:46

developer   ~65161

Just think the question types are the basic building blocks, and then shouldn't allow to uninstall them

DenisChenu

DenisChenu

2021-06-29 15:56

developer   ~65162

My opinion

  • core question theme (previously questiontype) : can discuss, i prefer to be allowed to uninstall (with control of usage, and warning when import lss/lsa)
  • question theme from core : must be allowed to uninstall, no delete
  • question theme from upload : must be allowed to uninstall and delete after.
ollehar

ollehar

2021-07-01 13:01

reporter   ~65190

I'm unsure now. Maybe I'll discuss it in the team.

gabrieljenik

gabrieljenik

2021-08-20 10:24

developer   ~66089

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=32584

ollehar

ollehar

2021-08-20 10:25

reporter   ~66090

  • question theme from core : must be allowed to uninstall, no delete

Hi ho, we decided that "Hide" would be enough for now. You have any good argument against this? Use-case?

Related Changesets

LimeSurvey: master 45549a23

2021-08-20 12:24

gabrieljenik

Committer: GitHub


Details Diff
Fixed issue 17379: Question types can be uninstalled (#1939)

Co-authored-by: encuestabizdevgit <devgit@encuesta.biz>
Affected Issues
17379
mod - application/models/QuestionTheme.php Diff File

Issue History

Date Modified Username Field Change
2021-06-22 14:47 gabrieljenik New Issue
2021-06-22 14:47 gabrieljenik Issue generated from: 17350
2021-06-22 14:47 gabrieljenik Relationship added related to 17350
2021-06-22 15:23 ollehar Note Added: 64974
2021-06-22 15:23 ollehar Note Edited: 64974
2021-06-22 15:28 gabrieljenik Assigned To => gabrieljenik
2021-06-22 15:28 gabrieljenik Status new => assigned
2021-06-22 15:28 LimeBot Zoho Projects ID => 85781000000982001
2021-06-28 15:58 gabrieljenik Note Added: 65128
2021-06-28 16:06 DenisChenu Note Added: 65129
2021-06-28 16:09 ollehar Note Added: 65130
2021-06-28 16:09 ollehar Note Edited: 65130
2021-06-28 16:31 DenisChenu Note Added: 65131
2021-06-28 16:33 DenisChenu Note Added: 65132
2021-06-28 16:44 ollehar Note Added: 65133
2021-06-28 17:16 DenisChenu Note Added: 65134
2021-06-28 17:16 DenisChenu Note Added: 65135
2021-06-28 17:16 DenisChenu File Added: Capture d’écran du 2021-06-28 17-12-55.png
2021-06-28 17:19 DenisChenu Note Added: 65136
2021-06-28 17:53 gabrieljenik Note Added: 65140
2021-06-28 17:59 ollehar Note Added: 65141
2021-06-28 18:00 ollehar Note Edited: 65141
2021-06-28 18:02 ollehar Note Edited: 65141
2021-06-28 18:04 DenisChenu Note Added: 65142
2021-06-28 18:20 DenisChenu Note Added: 65143
2021-06-28 18:20 DenisChenu File Added: Capture d’écran du 2021-06-28 18-19-58.png
2021-06-28 18:25 DenisChenu Note Added: 65145
2021-06-28 18:26 DenisChenu Note Added: 65146
2021-06-28 18:26 DenisChenu File Added: Capture d’écran du 2021-06-28 18-25-35.png
2021-06-28 18:29 DenisChenu Relationship added related to 17411
2021-06-28 20:58 ollehar Note Added: 65150
2021-06-28 20:58 ollehar Note Added: 65151
2021-06-29 08:46 DenisChenu Note Added: 65153
2021-06-29 15:46 gabrieljenik Note Added: 65161
2021-06-29 15:56 DenisChenu Note Added: 65162
2021-07-01 13:01 ollehar Note Added: 65190
2021-07-05 17:34 gabrieljenik Status assigned => ready for code review
2021-08-20 10:24 gabrieljenik Changeset attached => LimeSurvey master 45549a23
2021-08-20 10:24 gabrieljenik Note Added: 66089
2021-08-20 10:24 gabrieljenik Resolution open => fixed
2021-08-20 10:25 ollehar Note Added: 66090
2021-08-20 10:25 ollehar Status ready for code review => resolved
2022-06-03 15:04 c_schmitz Status resolved => closed