View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 17211 | Bug reports | RemoteControl | public | 2021-03-29 08:48 | 2021-07-12 11:54 |
| Reporter | Jmantysalo | Assigned To | c_schmitz | ||
| Priority | none | Severity | trivial | ||
| Status | closed | Resolution | fixed | ||
| Product Version | 4.4.13 | ||||
| Summary | 17211: Off-by-one (and more) at list_participants() | ||||
| Description | Parameter $iStart at the API function list_participants() is documented as "Start id of the token list". It is not true, if I put 1 to it I get participants starting from id 2. And it sounds anyways bad to have $oCriteria->offset = $iStart; at the code -- what if a participant is deleted and id's of participants are not consecutive numbers? | ||||
| Tags | No tags attached. | ||||
| Bug heat | 2 | ||||
| Complete LimeSurvey version number (& build) | Versio 4.4.13+210315 | ||||
| I will donate to the project if issue is resolved | No | ||||
| Browser | |||||
| Database type & version | N/A | ||||
| Server OS (if known) | |||||
| Webserver software & version (if known) | |||||
| PHP Version | N/A | ||||
 |
I agree. It makes more sense to return by start ID as the documentation say. |
|
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=31423 |
|
LimeSurvey: master f8733ca2 2021-03-29 12:10 Details Diff |
Fixed issue 17211: list_participants returns by IDs by offset, not by ID as documentation says |
Affected Issues 17211 |
|
| mod - application/helpers/remotecontrol/remotecontrol_handle.php | Diff File | ||
|
LimeSurvey: master 43df3f2b 2021-03-29 14:36 Details Diff |
Fixed issue 17211: RemoteControl list_participants() did not properly start at ID but at count |
Affected Issues 17211 |
|
| mod - application/helpers/remotecontrol/remotecontrol_handle.php | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2021-03-29 08:48 | Jmantysalo | New Issue | |
| 2021-03-29 10:10 | c_schmitz | Assigned To | => c_schmitz |
| 2021-03-29 10:10 | c_schmitz | Status | new => assigned |
| 2021-03-29 10:11 | c_schmitz | Status | assigned => confirmed |
| 2021-03-29 10:12 | c_schmitz | Note Added: 63669 | |
| 2021-03-29 12:37 | c_schmitz | Status | confirmed => resolved |
| 2021-03-29 12:37 | c_schmitz | Resolution | open => fixed |
| 2021-03-29 12:50 | c_schmitz | Changeset attached | => LimeSurvey master 43df3f2b |
| 2021-03-29 12:50 | c_schmitz | Changeset attached | => LimeSurvey master f8733ca2 |
| 2021-03-29 12:50 | c_schmitz | Note Added: 63698 | |
| 2021-07-12 11:54 | c_schmitz | Status | resolved => closed |
