 |
Near this one : https://bugs.limesurvey.org/view.php?id=17022 QuestionTheme : specific categories are not updated |
 |
Quick question: Why this change? 5a095ff The issue seems to be because we are pulling the theme from the last saved value on the DB. The requested theme is not saved on the DB yet. That's why it is not bringing up the expected attributes |
|
|
ping @ollehar |
 |
I'm not sure I made that commit. Is it a merge? |
|
|
Gah. I have to think. |
|
|
Is it enough to change this line? https://github.com/LimeSurvey/LimeSurvey/commit/5a095ff627bce3793fdd082e141c157c6dd4ecab#diff-107f8c81519e24601f4b3670bb92ccb4daa2c444134d1c14b24cce40b1e4d722R1779 Or to change $oQuestion->question_theme or whatever attribute. |
|
|
My opinion : original issue is set theme as a attribute like all other one. Theme must be inside question table (I think i tell this before question theme was ready as stable) |
|
|
> Theme must be inside question table Oh yeah. Weird that it isn't. |
|
|
Move it (with DB upgrade) in 5.X ? |
|
|
Which 5.x? We want to release 4.5 next week. :) Add it to 4.6 if it doesn't brake anything, maybe? |
|
|
Oh yes , better if we are sure to didn't broke anything. Since QuestionTheme didn't really work for now (?unsure on this point) @tparner must check if it's OK with existing QuestionTheme |
|
|
All question theme issues are assigned to Gabriel right now. We'll try to involve tpartner when Gabriel is ready. |
|
|
> Is it enough to change this line? https://github.com/LimeSurvey/LimeSurvey/commit/5a095ff627bce3793fdd082e141c157c6dd4ecab#diff-107f8c81519e24601f4b3670bb92ccb4daa2c444134d1c14b24cce40b1e4d722R1779 > > Or to change $oQuestion->question_theme or whatever attribute. Yes, we would need to change some of those lines as to get the theme not from the DB but from the user selection. OK, having reviewed that commit 5a095ff can be safely changed, we will work on it. Thanks! |
|
|
May the force be with you. ^^ |
|
|
PR: https://github.com/LimeSurvey/LimeSurvey/pull/1842 Code reorganization. - Added some comments. - Have created helper functions as to be able to have a better outlook of what some function do. Solution Summary. The key of the solution is to be able to pickup theme attributes from a theme name and not from a the attribute set on the question. Then added a theme override parameter which will set which theme attributes should be picked up. So now, question attributes may contain the attributes of a temp theme, which is not set on the DB. |
|
|
Another remark about New question , I think except Question theme : all advanced settings can be removed from the enw form. It make it simpliest. My opinoon : when copy/create have - theme - question code - question text - question help - Group - order in this group All other part included in Question model are interesting buit not mandatory. Clearly : advanced settings make a simpliest form for user (and i think : more easy for dev). |
|
|
> My opinion : original issue is set theme as a attribute like all other one. > Theme must be inside question table > Move it (with DB upgrade) in 5.X ? >Which 5.x? We want to release 4.5 next week. :) Add it to 4.6 if it doesn't brake anything, maybe? Agree Let's create a different ticket for that. Lot of code to be reviewed I think. |
|
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=31563 |
 |
Release done. |
- Anonymous
