View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
16871 | Bug reports | Assessments | public | 2020-12-01 15:49 | 2021-03-29 12:32 |
Reporter | gabrieljenik | Assigned To | gabrieljenik | ||
Priority | none | Severity | partial_block | ||
Status | closed | Resolution | fixed | ||
Product Version | 3.22.26 | ||||
Summary | 16871: When displaying assessment messages, empty lines are being displayed | ||||
Description | I understand they are related to rules for which the scoring schema doesn't apply | ||||
Steps To Reproduce | In the assessment results (when you finish a survey), there is one row for each rule. But the section of 'Total' rules start with an empty row. | ||||
Additional Information | The problem is in the twig file. | ||||
Tags | No tags attached. | ||||
Bug heat | 6 | ||||
Complete LimeSurvey version number (& build) | 3.22.26 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | |||||
Database type & version | Mysql | ||||
Server OS (if known) | |||||
Webserver software & version (if known) | |||||
PHP Version | 7 | ||||
related to | 17205 | closed | gabrieljenik | When displaying assessment messages, empty lines are being displayed |
You're using an outdated version of LimeSurvey. Please update to the latest version and check if the bug can still be reproduced. Thank you. |
|
PR: https://github.com/LimeSurvey/LimeSurvey/pull/1817 As to reproduce it:
limesurvey_survey_946599.lss (15,570 bytes)
<?xml version="1.0" encoding="UTF-8"?> <document> <LimeSurveyDocType>Survey</LimeSurveyDocType> <DBVersion>365</DBVersion> <languages> <language>en</language> </languages> <answers> <fields> <fieldname>qid</fieldname> <fieldname>code</fieldname> <fieldname>answer</fieldname> <fieldname>sortorder</fieldname> <fieldname>assessment_value</fieldname> <fieldname>language</fieldname> <fieldname>scale_id</fieldname> </fields> <rows> <row> <qid><![CDATA[3352]]></qid> <code><![CDATA[A1]]></code> <answer><![CDATA[0 pts]]></answer> <sortorder><![CDATA[1]]></sortorder> <assessment_value><![CDATA[0]]></assessment_value> <language><![CDATA[en]]></language> <scale_id><![CDATA[0]]></scale_id> </row> <row> <qid><![CDATA[3352]]></qid> <code><![CDATA[A2]]></code> <answer><![CDATA[2 pts]]></answer> <sortorder><![CDATA[2]]></sortorder> <assessment_value><![CDATA[2]]></assessment_value> <language><![CDATA[en]]></language> <scale_id><![CDATA[0]]></scale_id> </row> <row> <qid><![CDATA[3352]]></qid> <code><![CDATA[A3]]></code> <answer><![CDATA[10 pts]]></answer> <sortorder><![CDATA[3]]></sortorder> <assessment_value><![CDATA[10]]></assessment_value> <language><![CDATA[en]]></language> <scale_id><![CDATA[0]]></scale_id> </row> </rows> </answers> <assessments> <fields> <fieldname>id</fieldname> <fieldname>sid</fieldname> <fieldname>scope</fieldname> <fieldname>gid</fieldname> <fieldname>name</fieldname> <fieldname>minimum</fieldname> <fieldname>maximum</fieldname> <fieldname>message</fieldname> <fieldname>language</fieldname> </fields> <rows> <row> <id><![CDATA[4]]></id> <sid><![CDATA[946599]]></sid> <scope><![CDATA[T]]></scope> <gid><![CDATA[382]]></gid> <name><![CDATA[You should pick the "0 pts" option to trigger the bug]]></name> <minimum><![CDATA[1]]></minimum> <maximum><![CDATA[10]]></maximum> <message/> <language><![CDATA[en]]></language> </row> <row> <id><![CDATA[7]]></id> <sid><![CDATA[946599]]></sid> <scope><![CDATA[T]]></scope> <gid><![CDATA[382]]></gid> <name><![CDATA[There is probably an empty table between "Your assessment" and this text]]></name> <minimum><![CDATA[0]]></minimum> <maximum><![CDATA[0]]></maximum> <message><![CDATA[If the table is there, it's a bug.]]></message> <language><![CDATA[en]]></language> </row> </rows> </assessments> <groups> <fields> <fieldname>gid</fieldname> <fieldname>sid</fieldname> <fieldname>group_name</fieldname> <fieldname>group_order</fieldname> <fieldname>description</fieldname> <fieldname>language</fieldname> <fieldname>randomization_group</fieldname> <fieldname>grelevance</fieldname> </fields> <rows> <row> <gid><![CDATA[382]]></gid> <sid><![CDATA[946599]]></sid> <group_name><![CDATA[My first question group]]></group_name> <group_order><![CDATA[1]]></group_order> <description/> <language><![CDATA[en]]></language> <randomization_group/> <grelevance><![CDATA[1]]></grelevance> </row> </rows> </groups> <questions> <fields> <fieldname>qid</fieldname> <fieldname>parent_qid</fieldname> <fieldname>sid</fieldname> <fieldname>gid</fieldname> <fieldname>type</fieldname> <fieldname>title</fieldname> <fieldname>question</fieldname> <fieldname>preg</fieldname> <fieldname>help</fieldname> <fieldname>other</fieldname> <fieldname>mandatory</fieldname> <fieldname>question_order</fieldname> <fieldname>language</fieldname> <fieldname>scale_id</fieldname> <fieldname>same_default</fieldname> <fieldname>relevance</fieldname> <fieldname>modulename</fieldname> </fields> <rows> <row> <qid><![CDATA[3352]]></qid> <parent_qid><![CDATA[0]]></parent_qid> <sid><![CDATA[946599]]></sid> <gid><![CDATA[382]]></gid> <type><![CDATA[!]]></type> <title><![CDATA[Q00]]></title> <question><![CDATA[A first example question. Please answer this question:]]></question> <preg/> <help><![CDATA[This is a question help text.]]></help> <other><![CDATA[N]]></other> <mandatory><![CDATA[N]]></mandatory> <question_order><![CDATA[1]]></question_order> <language><![CDATA[en]]></language> <scale_id><![CDATA[0]]></scale_id> <same_default><![CDATA[0]]></same_default> <relevance><![CDATA[1]]></relevance> <modulename/> </row> </rows> </questions> <surveys> <fields> <fieldname>sid</fieldname> <fieldname>gsid</fieldname> <fieldname>admin</fieldname> <fieldname>expires</fieldname> <fieldname>startdate</fieldname> <fieldname>adminemail</fieldname> <fieldname>anonymized</fieldname> <fieldname>faxto</fieldname> <fieldname>format</fieldname> <fieldname>savetimings</fieldname> <fieldname>template</fieldname> <fieldname>language</fieldname> <fieldname>additional_languages</fieldname> <fieldname>datestamp</fieldname> <fieldname>usecookie</fieldname> <fieldname>allowregister</fieldname> <fieldname>allowsave</fieldname> <fieldname>autonumber_start</fieldname> <fieldname>autoredirect</fieldname> <fieldname>allowprev</fieldname> <fieldname>printanswers</fieldname> <fieldname>ipaddr</fieldname> <fieldname>refurl</fieldname> <fieldname>showsurveypolicynotice</fieldname> <fieldname>publicstatistics</fieldname> <fieldname>publicgraphs</fieldname> <fieldname>listpublic</fieldname> <fieldname>htmlemail</fieldname> <fieldname>sendconfirmation</fieldname> <fieldname>tokenanswerspersistence</fieldname> <fieldname>assessments</fieldname> <fieldname>usecaptcha</fieldname> <fieldname>usetokens</fieldname> <fieldname>bounce_email</fieldname> <fieldname>attributedescriptions</fieldname> <fieldname>emailresponseto</fieldname> <fieldname>emailnotificationto</fieldname> <fieldname>tokenlength</fieldname> <fieldname>showxquestions</fieldname> <fieldname>showgroupinfo</fieldname> <fieldname>shownoanswer</fieldname> <fieldname>showqnumcode</fieldname> <fieldname>bouncetime</fieldname> <fieldname>bounceprocessing</fieldname> <fieldname>bounceaccounttype</fieldname> <fieldname>bounceaccounthost</fieldname> <fieldname>bounceaccountpass</fieldname> <fieldname>bounceaccountencryption</fieldname> <fieldname>bounceaccountuser</fieldname> <fieldname>showwelcome</fieldname> <fieldname>showprogress</fieldname> <fieldname>questionindex</fieldname> <fieldname>navigationdelay</fieldname> <fieldname>nokeyboard</fieldname> <fieldname>alloweditaftercompletion</fieldname> <fieldname>googleanalyticsstyle</fieldname> <fieldname>googleanalyticsapikey</fieldname> </fields> <rows> <row> <sid><![CDATA[946599]]></sid> <gsid><![CDATA[1]]></gsid> <admin><![CDATA[Administrator]]></admin> <adminemail><![CDATA[jorgerugiero@gmail.com]]></adminemail> <anonymized><![CDATA[N]]></anonymized> <faxto/> <format><![CDATA[G]]></format> <savetimings><![CDATA[N]]></savetimings> <template><![CDATA[vanilla]]></template> <language><![CDATA[en]]></language> <additional_languages/> <datestamp><![CDATA[N]]></datestamp> <usecookie><![CDATA[N]]></usecookie> <allowregister><![CDATA[N]]></allowregister> <allowsave><![CDATA[Y]]></allowsave> <autonumber_start><![CDATA[2]]></autonumber_start> <autoredirect><![CDATA[N]]></autoredirect> <allowprev><![CDATA[N]]></allowprev> <printanswers><![CDATA[N]]></printanswers> <ipaddr><![CDATA[N]]></ipaddr> <refurl><![CDATA[N]]></refurl> <showsurveypolicynotice><![CDATA[0]]></showsurveypolicynotice> <publicstatistics><![CDATA[N]]></publicstatistics> <publicgraphs><![CDATA[N]]></publicgraphs> <listpublic><![CDATA[N]]></listpublic> <htmlemail><![CDATA[Y]]></htmlemail> <sendconfirmation><![CDATA[Y]]></sendconfirmation> <tokenanswerspersistence><![CDATA[N]]></tokenanswerspersistence> <assessments><![CDATA[Y]]></assessments> <usecaptcha><![CDATA[N]]></usecaptcha> <usetokens><![CDATA[N]]></usetokens> <bounce_email><![CDATA[jorgerugiero@gmail.com]]></bounce_email> <emailresponseto/> <emailnotificationto/> <tokenlength><![CDATA[15]]></tokenlength> <showxquestions><![CDATA[Y]]></showxquestions> <showgroupinfo><![CDATA[B]]></showgroupinfo> <shownoanswer><![CDATA[Y]]></shownoanswer> <showqnumcode><![CDATA[X]]></showqnumcode> <bounceprocessing><![CDATA[N]]></bounceprocessing> <showwelcome><![CDATA[N]]></showwelcome> <showprogress><![CDATA[Y]]></showprogress> <questionindex><![CDATA[0]]></questionindex> <navigationdelay><![CDATA[0]]></navigationdelay> <nokeyboard><![CDATA[N]]></nokeyboard> <alloweditaftercompletion><![CDATA[N]]></alloweditaftercompletion> <googleanalyticsstyle><![CDATA[0]]></googleanalyticsstyle> <googleanalyticsapikey/> </row> </rows> </surveys> <surveys_languagesettings> <fields> <fieldname>surveyls_survey_id</fieldname> <fieldname>surveyls_language</fieldname> <fieldname>surveyls_title</fieldname> <fieldname>surveyls_description</fieldname> <fieldname>surveyls_welcometext</fieldname> <fieldname>surveyls_endtext</fieldname> <fieldname>surveyls_policy_notice</fieldname> <fieldname>surveyls_policy_error</fieldname> <fieldname>surveyls_policy_notice_label</fieldname> <fieldname>surveyls_url</fieldname> <fieldname>surveyls_urldescription</fieldname> <fieldname>surveyls_email_invite_subj</fieldname> <fieldname>surveyls_email_invite</fieldname> <fieldname>surveyls_email_remind_subj</fieldname> <fieldname>surveyls_email_remind</fieldname> <fieldname>surveyls_email_register_subj</fieldname> <fieldname>surveyls_email_register</fieldname> <fieldname>surveyls_email_confirm_subj</fieldname> <fieldname>surveyls_email_confirm</fieldname> <fieldname>surveyls_dateformat</fieldname> <fieldname>surveyls_attributecaptions</fieldname> <fieldname>email_admin_notification_subj</fieldname> <fieldname>email_admin_notification</fieldname> <fieldname>email_admin_responses_subj</fieldname> <fieldname>email_admin_responses</fieldname> <fieldname>surveyls_numberformat</fieldname> <fieldname>attachments</fieldname> </fields> <rows> <row> <surveyls_survey_id><![CDATA[946599]]></surveyls_survey_id> <surveyls_language><![CDATA[en]]></surveyls_language> <surveyls_title><![CDATA[Test assessments]]></surveyls_title> <surveyls_description/> <surveyls_welcometext/> <surveyls_endtext/> <surveyls_url/> <surveyls_urldescription/> <surveyls_email_invite_subj><![CDATA[Invitation to participate in a survey]]></surveyls_email_invite_subj> <surveyls_email_invite><![CDATA[Dear {FIRSTNAME},<br /> <br /> you have been invited to participate in a survey.<br /> <br /> The survey is titled:<br /> "{SURVEYNAME}"<br /> <br /> "{SURVEYDESCRIPTION}"<br /> <br /> To participate, please click on the link below.<br /> <br /> Sincerely,<br /> <br /> {ADMINNAME} ({ADMINEMAIL})<br /> <br /> ----------------------------------------------<br /> Click here to do the survey:<br /> {SURVEYURL}<br /> <br /> If you do not want to participate in this survey and don't want to receive any more invitations please click the following link:<br /> {OPTOUTURL}<br /> <br /> If you are blacklisted but want to participate in this survey and want to receive invitations please click the following link:<br /> {OPTINURL}]]></surveyls_email_invite> <surveyls_email_remind_subj><![CDATA[Reminder to participate in a survey]]></surveyls_email_remind_subj> <surveyls_email_remind><![CDATA[Dear {FIRSTNAME},<br /> <br /> Recently we invited you to participate in a survey.<br /> <br /> We note that you have not yet completed the survey, and wish to remind you that the survey is still available should you wish to take part.<br /> <br /> The survey is titled:<br /> "{SURVEYNAME}"<br /> <br /> "{SURVEYDESCRIPTION}"<br /> <br /> To participate, please click on the link below.<br /> <br /> Sincerely,<br /> <br /> {ADMINNAME} ({ADMINEMAIL})<br /> <br /> ----------------------------------------------<br /> Click here to do the survey:<br /> {SURVEYURL}<br /> <br /> If you do not want to participate in this survey and don't want to receive any more invitations please click the following link:<br /> {OPTOUTURL}]]></surveyls_email_remind> <surveyls_email_register_subj><![CDATA[Survey registration confirmation]]></surveyls_email_register_subj> <surveyls_email_register><![CDATA[Dear {FIRSTNAME},<br /> <br /> You, or someone using your email address, have registered to participate in an online survey titled {SURVEYNAME}.<br /> <br /> To complete this survey, click on the following URL:<br /> <br /> {SURVEYURL}<br /> <br /> If you have any questions about this survey, or if you did not register to participate and believe this email is in error, please contact {ADMINNAME} at {ADMINEMAIL}.]]></surveyls_email_register> <surveyls_email_confirm_subj><![CDATA[Confirmation of your participation in our survey]]></surveyls_email_confirm_subj> <surveyls_email_confirm><![CDATA[Dear {FIRSTNAME},<br /> <br /> this email is to confirm that you have completed the survey titled {SURVEYNAME} and your response has been saved. Thank you for participating.<br /> <br /> If you have any further questions about this email, please contact {ADMINNAME} on {ADMINEMAIL}.<br /> <br /> Sincerely,<br /> <br /> {ADMINNAME}]]></surveyls_email_confirm> <surveyls_dateformat><![CDATA[1]]></surveyls_dateformat> <email_admin_notification_subj><![CDATA[Response submission for survey {SURVEYNAME}]]></email_admin_notification_subj> <email_admin_notification><![CDATA[Hello,<br /> <br /> A new response was submitted for your survey '{SURVEYNAME}'.<br /> <br /> Click the following link to see the individual response:<br /> {VIEWRESPONSEURL}<br /> <br /> Click the following link to edit the individual response:<br /> {EDITRESPONSEURL}<br /> <br /> View statistics by clicking here:<br /> {STATISTICSURL}]]></email_admin_notification> <email_admin_responses_subj><![CDATA[Response submission for survey {SURVEYNAME} with results]]></email_admin_responses_subj> <email_admin_responses><![CDATA[Hello,<br /> <br /> A new response was submitted for your survey '{SURVEYNAME}'.<br /> <br /> Click the following link to see the individual response:<br /> {VIEWRESPONSEURL}<br /> <br /> Click the following link to edit the individual response:<br /> {EDITRESPONSEURL}<br /> <br /> View statistics by clicking here:<br /> {STATISTICSURL}<br /> <br /> <br /> The following answers were given by the participant:<br /> {ANSWERTABLE}]]></email_admin_responses> <surveyls_numberformat><![CDATA[0]]></surveyls_numberformat> </row> </rows> </surveys_languagesettings> <themes> <theme> <sid>946599</sid> <template_name>vanilla</template_name> <config> <options>inherit</options> </config> </theme> </themes> <themes_inherited> <theme> <sid>946599</sid> <template_name>vanilla</template_name> <config> <options> <ajaxmode>off</ajaxmode> <brandlogo>on</brandlogo> <container>on</container> <hideprivacyinfo>off</hideprivacyinfo> <brandlogofile>./files/logo.png</brandlogofile> <font>noto</font> </options> </config> </theme> </themes_inherited> </document> |
|
Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=31397 |
|
Fixed in Release 3.25.20+210330 |
|
LimeSurvey: 3.x-LTS 309c4c2b 2021-03-26 10:25 Committer: GitHub Details Diff |
Fixed issue 16871: When displaying assessment messages, empty lines are being displayed (#1817) Dev When the total assessment value is 0, there are no assessed entries in aAssessments.total, but just the boolean "show" variable. |
Affected Issues 16871 |
|
mod - themes/survey/vanilla/views/subviews/messages/assessments.twig | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2020-12-01 15:49 | gabrieljenik | New Issue | |
2020-12-01 15:49 | gabrieljenik | Issue generated from: 16870 | |
2020-12-01 16:10 | gabrieljenik | Steps to Reproduce Updated | |
2020-12-01 16:10 | gabrieljenik | Additional Information Updated | |
2020-12-01 16:10 | gabrieljenik | Note Added: 60816 | |
2020-12-01 16:10 | gabrieljenik | File Added: image.png | |
2020-12-01 16:11 | gabrieljenik | Product Version | 3.25.2 => 3.22.26 |
2020-12-01 16:11 | gabrieljenik | Complete LimeSurvey version number (& build) | 3.25.2 => 3.22.26 |
2021-03-10 17:16 | ollehar | Assigned To | => ollehar |
2021-03-10 17:16 | ollehar | Status | new => feedback |
2021-03-10 17:16 | ollehar | Note Added: 63071 | |
2021-03-25 16:33 | gabrieljenik | Note Added: 63617 | |
2021-03-25 16:33 | gabrieljenik | File Added: limesurvey_survey_946599.lss | |
2021-03-25 16:33 | gabrieljenik | Status | feedback => assigned |
2021-03-25 16:59 | c_schmitz | Sync to Zoho Project | => |Yes| |
2021-03-25 17:26 | gabrieljenik | Issue cloned: 17205 | |
2021-03-25 17:26 | gabrieljenik | Relationship added | related to 17205 |
2021-03-26 09:25 | c_schmitz | Status | assigned => resolved |
2021-03-26 09:25 | c_schmitz | Resolution | open => fixed |
2021-03-26 09:25 | gabrieljenik | Changeset attached | => LimeSurvey 3.x-LTS 309c4c2b |
2021-03-26 09:25 | gabrieljenik | Note Added: 63644 | |
2021-03-26 09:25 | gabrieljenik | Assigned To | ollehar => gabrieljenik |
2021-03-29 12:32 | lime_release_bot | Sync to Zoho Project | Yes => |Yes| |
2021-03-29 12:32 | lime_release_bot | Note Added: 63693 | |
2021-03-29 12:32 | lime_release_bot | Status | resolved => closed |