View Issue Details

IDProjectCategoryView StatusLast Update
16847Bug reportsUser / Groups / Rolespublic2020-11-23 14:57
ReporterJmantysalo Assigned To 
PrioritynoneSeveritytweak 
Status closedResolutionfixed 
Product Version4.3.26 
Summary16847: Add user to group: unsorted list
Description

When adding user to a user group the list of users is unsorted. Could we do something to this? For example ''application/controllers/UserGroupController.php'' line 167 ends at '' 'condition' => "id IS NULL"'' and having '''condition' => "id IS NULL ORDER BY uid"'' would make this much easier to use.

Steps To Reproduce

Just make an installation for over 100 user.

TagsNo tags attached.
Complete LimeSurvey version number (& build)Versio 4.3.26+201110
I will donate to the project if issue is resolvedNo
Sync to Zoho Project
Browser
Database & DB-VersionMariaDB
Server OS (if known)
Webserver software & version (if known)
PHP VersionN/A

Activities

cdorin

cdorin

2020-11-20 10:21

manager   ~60719

Hey and thanks for info!
Would you like to make a PR? Did you test the solution :) ?

Jmantysalo

Jmantysalo

2020-11-20 10:28

reporter   ~60720

I did test. This works, and is definitely better than the current code. But maybe sorting by name, not by account, would be still better.

Anyways, if nobody's gonna make better fix, I'll try to make a PR.

Jmantysalo

Jmantysalo

2020-11-20 10:45

reporter   ~60722

PR at https://github.com/LimeSurvey/LimeSurvey/pull/1662

DenisChenu

DenisChenu

2020-11-20 10:57

developer   ~60723

order by name or user_name is (maybe) better ?

Jmantysalo

Jmantysalo

2020-11-20 11:06

reporter   ~60724

order by name or user_name is (maybe) better ?

Of course, don't know what I was thinkig... I pushed this to branch containing PR.

guest

guest

2020-11-23 14:55

viewer   ~60739

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30743

lime_release_bot

lime_release_bot

2020-11-23 14:57

administrator   ~60741

Fixed in Release 4.3.28+201123

Related Changesets

LimeSurvey: master 5a53c938

2020-11-23 14:55:03

Jmantysalo


Committer: GitHub Details Diff
Fixed issue 16847: Sort users when adding to usergroup (#1662)

* Sort users when adding to usergroup.

* Correction: Sort users when adding to usergroup.
Affected Issues
16847
mod - application/controllers/UserGroupController.php Diff File

Issue History

Date Modified Username Field Change
2020-11-20 10:07 Jmantysalo New Issue
2020-11-20 10:21 cdorin Note Added: 60719
2020-11-20 10:28 Jmantysalo Note Added: 60720
2020-11-20 10:45 Jmantysalo Note Added: 60722
2020-11-20 10:57 DenisChenu Note Added: 60723
2020-11-20 11:06 Jmantysalo Note Added: 60724
2020-11-23 14:55 Jmantysalo Changeset attached => LimeSurvey master 5a53c938
2020-11-23 14:55 guest Note Added: 60739
2020-11-23 14:57 lime_release_bot Note Added: 60741
2020-11-23 14:57 lime_release_bot Status new => closed
2020-11-23 14:57 lime_release_bot Resolution open => fixed