View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 16769 | Bug reports | Security | public | 2020-10-21 15:41 | 2021-01-14 16:01 |
| Reporter | DenisChenu | Assigned To | DenisChenu | ||
| Priority | none | Severity | minor | ||
| Status | closed | Resolution | fixed | ||
| Product Version | 3.24.2 | ||||
| Fixed in Version | 4.3.22 | ||||
| Summary | 16769: Unable to embed in iframe (using config.php) for Chrome | ||||
| Description | Currently : allow iframe survey can work except on new Chrome version cookies inside iframe in chrome need
It can be done for crfCookies but not for session cookie | ||||
| Steps To Reproduce | Activate IFrame embedding allowed to ON (this rarely work, never for new Chrome) Check with chrome CRSF issue Update config.php
and
(you need https) Check with firefox (default cofnig) : seems OK | ||||
| Additional Information | Reason : need Yii update to have samesite available in config for session cookie I check with replace just this function : it work (with my chrome and my firefoix) See For information : null for chrome mean Lax, null for Firefox : None | ||||
| Tags | No tags attached. | ||||
| Bug heat | 256 | ||||
| Complete LimeSurvey version number (& build) | 3.24.2 | ||||
| I will donate to the project if issue is resolved | No | ||||
| Browser | not relevant ? | ||||
| Database type & version | not relevant? | ||||
| Server OS (if known) | not relevant ? | ||||
| Webserver software & version (if known) | not relevant ? | ||||
| PHP Version | not relevant ? | ||||
|
Check here : http://www.gsill.net/example/check/ |
|
|
About settings : since config is loaded before read config , i think it's hard to make it dynamically according to IFrame embedding allowed but we can document it. |
|
|
@ollehar : need advice … To fix this issue : need https://github.com/yiisoft/yii/commit/566cae7fd94cffb8a20771949c8a97a27bd237f8#diff-652721134484aa3b5f3d6fe36ddc8db5b02f315e1ea047974e40dec1cc0675fb Did i move to master for other fix : https://github.com/yiisoft/yii/pull/4306 for example Or just apply patch ? Denis |
|
|
Apply manually? Then we update Yii when released. |
|
|
Milstone for next release : https://github.com/yiisoft/yii/milestone/15 |
|
|
Oki, Thank you. |
|
|
Screenshot of cookies settings |
|
|
Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30643 |
|
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30645 |
|
|
Clone |
|
|
Here comes an adjusted config.php file with the correct settings mentioned above (note the difference of "samesite" and "sameSite"!): return array(
); |
|
|
LimeSurvey: 3.x-LTS e1459a65 2020-10-21 18:52 Details Diff |
Fixed issue 16769: Unable to embed in iframe (using config.php) for Chrome Dev: apply patch from Yii1 before Yii 1.1.23 Dev: see https://github.com/yiisoft/yii/pull/4313/files |
Affected Issues 16769 |
|
| mod - framework/web/CHttpSession.php | Diff File | ||
|
LimeSurvey: master 40b57dcd 2020-10-21 18:52 Details Diff |
Fixed issue 16769: Unable to embed in iframe (using config.php) for Chrome Dev: apply patch from Yii1 before Yii 1.1.23 Dev: see https://github.com/yiisoft/yii/pull/4313/files Dev: cherry-picked Dev: session can be set with samesite:None checked |
Affected Issues 16769 |
|
| mod - framework/web/CHttpSession.php | Diff File | ||
|
LimeSurvey: 3.x-LTS 3c5028f2 2020-10-22 13:30 Committer: GitHub Details Diff |
Merge pull request #1629 from Shnoulle/3X_allowChromeIframeViaConfig Fixed issue 16769: Unable to embed in iframe (using config.php) for Chrome |
Affected Issues 16769 |
|
| mod - framework/web/CHttpSession.php | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2020-10-21 15:41 | DenisChenu | New Issue | |
| 2020-10-21 15:41 | DenisChenu | Note Added: 60335 | |
| 2020-10-21 15:42 | DenisChenu | Assigned To | => DenisChenu |
| 2020-10-21 15:42 | DenisChenu | Status | new => assigned |
| 2020-10-21 15:45 | DenisChenu | Note Added: 60336 | |
| 2020-10-21 15:53 | DenisChenu | Note Added: 60337 | |
| 2020-10-21 15:54 | ollehar | Note Added: 60338 | |
| 2020-10-21 15:55 | DenisChenu | Note Added: 60339 | |
| 2020-10-21 15:56 | DenisChenu | Note Added: 60340 | |
| 2020-10-21 16:55 | DenisChenu | Note Added: 60342 | |
| 2020-10-21 16:55 | DenisChenu | File Added: Capture d’écran du 2020-10-21 16-54-01.png | |
| 2020-10-21 16:55 | DenisChenu | File Added: Capture d’écran du 2020-10-21 16-54-50.png | |
| 2020-10-21 16:57 | DenisChenu | Assigned To | DenisChenu => cdorin |
| 2020-10-21 16:57 | DenisChenu | Status | assigned => ready for testing |
| 2020-10-21 16:57 | DenisChenu | Note Added: 60343 | |
| 2020-10-22 11:30 | ollehar | Changeset attached | => LimeSurvey 3.x-LTS 3c5028f2 |
| 2020-10-22 11:30 | DenisChenu | Changeset attached | => LimeSurvey 3.x-LTS e1459a65 |
| 2020-10-22 11:30 | DenisChenu | Note Added: 60354 | |
| 2020-10-22 11:30 | DenisChenu | Assigned To | cdorin => DenisChenu |
| 2020-10-22 11:30 | DenisChenu | Resolution | open => fixed |
| 2020-10-22 11:58 | DenisChenu | Status | ready for testing => resolved |
| 2020-10-22 11:58 | DenisChenu | Fixed in Version | => 3.24.2 |
| 2020-10-22 12:09 | DenisChenu | Changeset attached | => LimeSurvey master 40b57dcd |
| 2020-10-22 12:09 | DenisChenu | Note Added: 60358 | |
| 2020-10-22 12:22 | DenisChenu | Status | resolved => closed |
| 2020-10-22 12:22 | DenisChenu | Fixed in Version | 3.24.2 => 4.3.22 |
| 2020-10-22 12:22 | DenisChenu | Note Added: 60359 | |
| 2021-01-14 15:59 | Mazi | Note Added: 61542 | |
| 2021-01-14 15:59 | Mazi | Note Edited: 61542 | |
| 2021-01-14 16:01 | Mazi | Note Edited: 61542 | |
| 2021-01-14 16:01 | Mazi | Note Edited: 61542 | |
| 2021-01-14 16:01 | Mazi | Note Edited: 61542 |