| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 16720 | Bug reports | Import/Export | public | 2020-10-06 08:35 | 2021-09-06 10:59 |
| Reporter | Mazi | Assigned To | gabrieljenik | ||
| Priority | normal | Severity | block | ||
| Status | closed | Resolution | fixed | ||
| Product Version | 3.23.6 | ||||
| Summary | 16720: Old/invalid question codes adjusted during LSS import do not get replaced | ||||
| Description | I am importing an old 2.06 survey at which we used underscores within the question codes. That is not valid anymore at LS 3.23 so the system removes the underscore so we get a valid code and it also replaces most occurrences of the code within the survey, but not everywhere. I noticed that the adjusted code does not get updated when being used at:
| ||||
| Steps To Reproduce |
| ||||
| Additional Information | I am adding some screenshots showing the problem. What surprises me is that often within the same question, some adjusted question codes were replaced properly but others were not. | ||||
| Tags | No tags attached. | ||||
| Bug heat | 10 | ||||
| Complete LimeSurvey version number (& build) | Version 3.23.5+200923 | ||||
| I will donate to the project if issue is resolved | No | ||||
| Browser | Chrome | ||||
| Database type & version | MySQL | ||||
| Server OS (if known) | Linux | ||||
| Webserver software & version (if known) | Apache | ||||
| PHP Version | 5.6.40 | ||||
 |
It's weird that the same code sometimes gets replaced and sometimes does not get replaced within the same question, see additional screenshot. qcode_replacement.png (17,985 bytes) |
|
|
I am also attaching the manually adjusted LSS file with the wrong codes being corrected. Maybe that helps comparing where things go wrong. |
 |
I think it's because we import by order of XML, adn fix with same order.
Potential fix :
|
|
|
Good catch, Denis. That could explain the weird behavior. We should definitely make sure that replacements are done in one go and cover all occurrences. Maybe do the code adjustments first and then do the replacements based on an array with old and new codes. That way we make sure the whole file is processed from beginning to end and all placeholders get adjusted properly. @cdorin, can we assign this to @gabrieljenik since we need this for a project I am working on with him together? |
|
|
It's just an idea :) |
|
|
@cdorin, this is a really annoying bug if you need to copy surveys from a 2.x system to 3.x. Can someone please work on a fix? Denis already suggested a potential solution. |
|
|
@cdorin, we really need a fix for a long term Limesurvey customer who frequently needs to import surveys from 2.0x to 3.x and faces the mentioned issues. |
|
|
@cdorin, @c_schmitz, can we please, please assign this to a developer to get it fixed ASAP? We need this for our most important customer which is switching from 2.x to 3.x and faces that issue with multiple surveys. They can't use LS 3.x unless this is fixed because they need to copy-over many surveys. |
 |
When does it happen? When you import a survey from 2.x to 3.x? Are there issues when upgrading the db? (upgrading LS2 to LS3) |
|
|
@cdorin, thanks for getting back to me. The problem shows up when importing a Limesurvey 2.x survey to a LS 3.x system. We did not upgrade the DB but started with an empty DB at the 3.x system. |
|
|
it is not a bug from what I see, but a feature request from what I see. The import system won't be improved by us too soon. |
|
|
@cdorin, this surely is a bug. Since LS 3.x (or even earlier), older question codes like QUESTION_CODE get replaced and turned into valid codes like QUESTIONCODE. This replacement is done during import. But as you can see at the screenshots, the replacements sometimes fail. So this is a bug. |
|
|
My opinion : Even if it's an issue old than 2.05 : it sill an issue :), not a feature. |
|
|
@cdorin, can we please assign this? |
 |
Maybe we can hire Denis to fix this issue? Hm, or Gabriel. |
|
|
Pushed to next sprint. |
 |
The following sections of the lss were never subect to olc-code-vs-new-code replacement.
|
|
|
Well, I think everywhere you can add placeholders you should also do the replacement on import. |
|
|
PR: https://github.com/LimeSurvey/LimeSurvey/pull/1994 There was also an issue when replacing codes on general basis. |
|
|
PR for Master: https://github.com/LimeSurvey/LimeSurvey/pull/2011 |
|
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=32585 |
