View Issue Details

This bug affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
16710Feature requestsPluginspublic2020-10-02 12:57
ReporterTonisOrmisson Assigned ToTonisOrmisson  
PrioritynoneSeverityfeature 
Status closedResolutionfixed 
Summary16710: add onUpdateResponse plugin event
Description

Add the plugin event for any actual data submission/update of the response.

TagsNo tags attached.
Bug heat6
Story point estimate
Users affected %

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2020-10-01 10:08

developer   ~59998

We already have the event …

I make effort and Pull request to have the beforeResponseDave and afterResponseSave event in master …

If needed in 3.X : best is to apply the fix from 4.X …

checkResponseSave.zip (1,584 bytes)
TonisOrmisson

TonisOrmisson

2020-10-01 10:38

developer   ~60000

show me where :) doesn't seem to exist (or Im just in a stupid place today :)

DenisChenu

DenisChenu

2020-10-01 11:00

developer   ~60001

I create a plugin : the zip file was a plugin

https://manual.limesurvey.org/Dynamic_model_events

But in 3.X : there are no usage of PDO before the fix, i can push in 3.X due to a issue with SQL , but not with ->save()

DenisChenu

DenisChenu

2020-10-01 11:08

developer   ~60002

PS : we think to add a easy way to set isValid in 4.X
https://www.yiiframework.com/doc/api/1.1/CModelEvent#isValid-detail

TonisOrmisson

TonisOrmisson

2020-10-01 12:00

developer   ~60009

I can see the manual, but not in source code. Search the "beforeResponse" in source and there is no match in v3, v4. Thats what im sayin.

DenisChenu

DenisChenu

2020-10-01 12:07

developer   ~60012

Yes : because its a dynamic name event :
https://github.com/LimeSurvey/LimeSurvey/blob/987fa4bb04bb56b64648d322c425574445759d86/application/models/behaviors/PluginEventBehavior.php#L48

You know the file : https://github.com/LimeSurvey/LimeSurvey/commit/703da1daee34e22aa43e4eae96f10a56b0a7ebb8#diff-4b12d5298d112354d26385cdd1b735fd

But before moving EM to PDO and use ->save : the event didn't happen for public part (and response).

And beofre 3.15 : beforeResponse_1234Save are not very clear …

ollehar

ollehar

2020-10-02 12:54

administrator   ~60051

This can be closed, then?

Issue History

Date Modified Username Field Change
2020-10-01 09:34 TonisOrmisson New Issue
2020-10-01 09:34 TonisOrmisson Status new => assigned
2020-10-01 09:34 TonisOrmisson Assigned To => TonisOrmisson
2020-10-01 10:08 DenisChenu Note Added: 59998
2020-10-01 10:08 DenisChenu File Added: checkResponseSave.zip
2020-10-01 10:38 TonisOrmisson Note Added: 60000
2020-10-01 11:00 DenisChenu Note Added: 60001
2020-10-01 11:00 DenisChenu File Added: Capture d’écran du 2020-10-01 10-59-02.png
2020-10-01 11:08 DenisChenu Note Added: 60002
2020-10-01 12:00 TonisOrmisson Note Added: 60009
2020-10-01 12:07 DenisChenu Note Added: 60012
2020-10-02 12:54 ollehar Note Added: 60051
2020-10-02 12:57 TonisOrmisson Status assigned => closed
2020-10-02 12:57 TonisOrmisson Resolution open => fixed