View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
16670 | Bug reports | Theme editor | public | 2020-09-16 07:14 | 2021-04-22 16:30 |
Reporter | Jmantysalo | Assigned To | gabrieljenik | ||
Priority | low | Severity | tweak | ||
Status | closed | Resolution | fixed | ||
Product Version | 4.3.16 | ||||
Summary | 16670: Extended theme shows all options in one page | ||||
Description | Theme options for fruity are nicely shown in tabs ("Colors", "Images" etc). If I extend the theme to a new one, then settings are shown in one long page, which is slightly irritating. | ||||
Tags | No tags attached. | ||||
Bug heat | 8 | ||||
Complete LimeSurvey version number (& build) | Version 4.3.16+200915 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | |||||
Database type & version | N/A | ||||
Server OS (if known) | |||||
Webserver software & version (if known) | |||||
PHP Version | N/A | ||||
Relind the way to reproduce, always :) Way to reproduce:
I didn't test on Survey theme option. |
|
Thanks, I'll try to remember that. For this one it's too late, I can not modify issue after creating it. |
|
No problem : i add it after :) |
|
Thanks for report :) |
|
https://github.com/LimeSurvey/LimeSurvey/pull/1674 When the theme config is copied, the engine node is removed (apparently it caused issues before). |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30781 |
|
LimeSurvey: master 99aae156 2020-12-10 18:54 Committer: GitHub Details Diff |
Fixed issue 16670: Extended theme shows all options in one page (#1674) When the theme config is copied, the engine node is removed (apparently it caused issues before). Since the optionspage config is inside the engine node, it's removed from the extended theme config, and then the options.twig is used. One option is to move the optionspage out of the engine node, so it's not removed. Other option is to remove the engine node contents EXCEPT optionspage, instead of the whole engine node. This option seems easier and it was the one implemented. |
Affected Issues 16670 |
|
mod - application/models/TemplateManifest.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2020-09-16 07:14 | Jmantysalo | New Issue | |
2020-09-16 08:16 | DenisChenu | Note Added: 59841 | |
2020-09-16 08:16 | DenisChenu | File Added: Capture d’écran du 2020-09-16 08-14-44.png | |
2020-09-16 08:29 | Jmantysalo | Note Added: 59842 | |
2020-09-16 08:32 | DenisChenu | Note Added: 59843 | |
2020-09-16 16:40 | cdorin | Priority | none => low |
2020-09-16 16:40 | cdorin | Status | new => confirmed |
2020-09-16 16:40 | cdorin | Zoho Sprints | => |Yes| |
2020-09-16 16:40 | cdorin | Note Added: 59847 | |
2020-12-03 17:08 | gabrieljenik | Note Added: 60825 | |
2020-12-10 17:54 | gabrieljenik | Changeset attached | => LimeSurvey master 99aae156 |
2020-12-10 17:54 | gabrieljenik | Note Added: 60920 | |
2020-12-10 17:54 | gabrieljenik | Assigned To | => gabrieljenik |
2020-12-10 17:54 | gabrieljenik | Resolution | open => fixed |
2021-04-22 16:30 | gabrieljenik | Status | confirmed => closed |