View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
16662 | Bug reports | Plugins | public | 2020-09-11 12:17 | 2020-12-30 19:27 |
Reporter | Jmantysalo | Assigned To | ollehar | ||
Priority | none | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 4.3.14 | ||||
Summary | 16662: Event beforePermissionSetSave is not dispatched | ||||
Description | In https://github.com/LimeSurvey/LimeSurvey/blob/master/application/models/Permission.php#L262 there is a new PluginEvent of type beforePermissionSetSave created, but it has no corresponding dispatchEvent. Hence the plugin AuditLog can not fully work. | ||||
Tags | No tags attached. | ||||
Bug heat | 8 | ||||
Complete LimeSurvey version number (& build) | Version 4.3.14+200826 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | |||||
Database type & version | N/A | ||||
Server OS (if known) | |||||
Webserver software & version (if known) | |||||
PHP Version | N/A | ||||
It suffices to add App()->getPluginManager()->dispatchEvent($oEvent); after line 265 at the file. Currently wondering how to make a pull request in GitHub... |
|
Good catch. Github has lots of documentation on how to do a pull request. Join us on telegram if you need guidance. |
|
If I got it right this time, then the fix is at https://github.com/LimeSurvey/LimeSurvey/pull/1593 and I guess you will get a notification of a pull request after some automatic checks are done. Telegram? More info on that is available at [please make a www-page if not already exists]? |
|
Since it's merged, i think it's OK ? PS : i update the event in https://github.com/LimeSurvey/LimeSurvey/pull/1593/files
entity and entity added … |
|
Yes, it's OK. |
|
Thank you ! |
|
fixed in 4.4.0 rc1 |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2020-09-11 12:17 | Jmantysalo | New Issue | |
2020-09-15 11:48 | Jmantysalo | Note Added: 59809 | |
2020-09-15 15:07 | ollehar | Note Added: 59815 | |
2020-09-16 07:45 | Jmantysalo | Note Added: 59839 | |
2020-10-31 11:23 | DenisChenu | Assigned To | => DenisChenu |
2020-10-31 11:23 | DenisChenu | Status | new => feedback |
2020-10-31 11:23 | DenisChenu | Note Added: 60479 | |
2020-10-31 15:04 | Jmantysalo | Note Added: 60480 | |
2020-10-31 15:04 | Jmantysalo | Status | feedback => assigned |
2020-10-31 16:13 | DenisChenu | Assigned To | DenisChenu => ollehar |
2020-10-31 16:13 | DenisChenu | Status | assigned => resolved |
2020-10-31 16:13 | DenisChenu | Resolution | open => fixed |
2020-10-31 16:13 | DenisChenu | Note Added: 60481 | |
2020-12-30 19:27 | cdorin | Note Added: 61336 | |
2020-12-30 19:27 | cdorin | Status | resolved => closed |