View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|16619||Feature requests||RemoteControl||public||2020-08-26 14:06||2023-01-24 18:01|
|Status||ready for merge||Resolution||open|
|Summary||16619: API function get_uploaded_files() can only be used for closed surveys using tokens|
As outlined at https://api.limesurvey.org/classes/remotecontrol_handle.html#method_get_uploaded_files the get_uploaded_files() API function uses a token to identify a data set and get the related uploaded files. That is a problme for several reasons:
With the current implementation you can't use the function to get the files uploaded to a certain data set. One needs to pass the data set ID but that'S not possible.
|Tags||No tags attached.|
@gabrieljenik, can you roughly estimate hours for adding that third parameter? I may be interested to pay for this fix since we need an API function to get uploaded files but that is an open survey where no tokens are available.
I like the approach.
It has to be done for LS4 too, including acceptance test.
Best solution seems to be adding another parameter as discussed at https://forums.limesurvey.org/forum/development/120057-is-there-an-api-like-get_url_from_uploaded_file#204508.
@ollehar, the code adjustment seems to be pretty straightforward and not that complex. But it could get tricky to code the test for the download stuff. Have you ever done that? Do we have any examples?
Because from a monetary point of view it doesn't make that much sense to code a test if that is twice the effort of the original code adjutment.
Manual testing is more expensive in the long run. The automated tests are there to make sure the feature remains through future changes. But maybe we can help you write the test, or provide a scaffold?
I've done testing with files for the theme editor.
You're using an outdated version of LimeSurvey. Please update to the latest version and check if the bug can still be reproduced. Thank you.
@ollehar: You are taking too much time to address bugs. Please be faster :-)
Thing is: The function get_uploaded_files() has not changed from the bug report until now, see https://github.com/LimeSurvey/LimeSurvey/commits/3.x-LTS/application/helpers/remotecontrol. So why should this suddenly be fixed.
Pasting a default "Please test again" message is not useful in every case...
It's very useful. Thanks for the feedback.
This is a new feature, or?
Well, it is more like making this a usable feature at all. Currently the usage is limited to closed surveys using tokens for unknown reasons. Most surveys are not using tokens though.
Documentation should be updated as well.
|2020-08-26 14:06||Mazi||New Issue|
|2020-08-26 14:08||Mazi||Note Added: 59625|
|2020-08-26 15:13||gabrieljenik||Note Added: 59628|
|2020-08-26 15:14||ollehar||Note Added: 59629|
|2020-08-29 00:35||Mazi||Note Added: 59666|
|2020-09-01 12:41||Mazi||Note Added: 59673|
|2020-09-01 13:26||ollehar||Note Added: 59674|
|2021-03-10 17:13||ollehar||Assigned To||=> ollehar|
|2021-03-10 17:13||ollehar||Status||new => feedback|
|2021-03-10 17:13||ollehar||Note Added: 63061|
|2021-03-10 17:36||Mazi||Note Added: 63094|
|2021-03-10 17:36||Mazi||Status||feedback => assigned|
|2021-03-10 17:40||ollehar||Note Added: 63099|
|2021-03-10 17:40||ollehar||Status||assigned => new|
|2021-03-10 17:41||ollehar||Note Added: 63101|
|2021-03-10 17:48||Mazi||Note Added: 63115|
|2021-03-10 17:55||ollehar||Note Added: 63121|
|2021-03-10 17:58||ollehar||Project||Bug reports => Feature requests|
|2021-11-01 11:15||galads||Status||new => acknowledged|
|2021-11-01 11:15||galads||Severity||@60@ => feature|
|2021-11-01 11:15||galads||Product Version||3.23.1 =>|
|2021-11-01 11:15||LimeBot||Zoho Projects URL||=> https://projects.limesurvey.org/portal/limesurvey#taskdetail/85781000001335039/85781000001348001/85781000001394001|
|2021-11-02 09:52||galads||Status||acknowledged => confirmed|
|2022-04-11 13:42||galads||Assigned To||ollehar => gabrieljenik|
|2022-04-21 19:34||gabrieljenik||Status||confirmed => ready for testing|
|2022-04-21 19:34||gabrieljenik||Note Added: 69183|
|2023-01-24 18:01||gabrieljenik||Assigned To||gabrieljenik => ollehar|
|2023-01-24 18:01||gabrieljenik||Status||ready for testing => ready for merge|