| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 16579 | Bug reports | Survey participants (Tokens) | public | 2020-08-11 16:34 | 2020-12-30 19:27 |
| Reporter | TonyMonast | Assigned To | JHoeck | ||
| Priority | none | Severity | minor | ||
| Status | closed | Resolution | fixed | ||
| Product Version | 4.3.8 | ||||
| Summary | 16579: Problem with the error message when a token is already used (inherit) | ||||
| Description | When a token is already used and the error message appear, the admin info and email show the text "Inherit" instead of the inherit values. I tried with the Vanilla theme and I have the same problem. | ||||
| Steps To Reproduce |
| ||||
| Tags | No tags attached. | ||||
| Bug heat | 12 | ||||
| Complete LimeSurvey version number (& build) | Version 4.3.8+200803 | ||||
| I will donate to the project if issue is resolved | No | ||||
| Browser | Firefox | ||||
| Database type & version | 5.7.31 | ||||
| Server OS (if known) | Linux | ||||
| Webserver software & version (if known) | Apache | ||||
| PHP Version | 7.4.8 | ||||
 |
Same problem when the survey is in english. error-english.png (21,886 bytes) |
 |
Hey there, I am not sure if I understand where the bug is - do you want to use the same token for multiple entries? |
 |
@cdorin : admin name «inherit«, admin email : «inherit» Must be inherited value, not the 'inherit' string ;) |
|
|
As Denis said. We should not see the text "inherit", but rather its corresponding value. |
|
|
Ah, thanks! got it now :) . Confirmed and reported :) |
|
|
This is not a bug. The value 'inherit' is set for the adminemail in db. 1231313131.JPG (45,252 bytes) |
 |
This should use the value from the belonging survey group, or what? |
|
|
@JHoeck : maybe in DB , this is not the desired behaviour : It must be same email that the email used when sending email @ollehar : i finally founs how to set this value by group … Capture d’écran du 2020-10-30 11-37-40.png (25,275 bytes) Capture d’écran du 2020-10-30 11-39-03.png (49,897 bytes) |
|
|
PS : maybe inherit value can be saved as NULL value in DB ? If we have an administrator with name inherit … |
|
|
would be a good idea to set it to null. |
|
|
Don't do this now, tho. You'd have to change all "inherit" in all database tables to make it consistent. |
|
|
Maybe , but it's a pity not to have designed it like that from the start You don't think we can do a DB upgrade an a fix when import (comparing with DB version of the xml) ? |
|
|
Yeah. A better value than null might be "<inherit>" or "__Inherit" or similar.
Maybe, but not now, bigger fish to fry. :) |
|
|
No, i really think NULL is better. Null mean : not set, if not set get it elsewhere. |
|
|
Null does not communicate intent. |
|
|
Anything else can broke with specific need … null == not set seems clear enough for me :) |
|
|
I'm not thinking of you, I'm thinking of someone that sees the database for the first time. Low barrier to enter. |
|
|
see comment of @JHoeck : i really think she's right :) At fist look : admin name is inherit ("<inherit>" or "__Inherit" or similar.). With NULL : «There are something strange here : get look at code» :) A good discussion for next dev meeting ;) |
|
|
Else : |
|
|
Problem include SurveyGroupsettings somewhere too. |
|
|
I think $oSurvey->oOptions do this. |
 |
Yes, it does. What I am not sure now is about inheritance from the global admin settings.
I agree. It will be also less error prone. |
|
|
Looking this morning : Survey global settings have gsid = 0 |
|
|
Fixed in branch: bug/issue-16579-problem-with-erro-message-when-token-already-used-inherit (Replaced $aSurveyInfo['admin'] and $aSurveyInfo['adminemail'] with the survey options values (admin and adminemail). So this is a quick fix for those issues, but in the future we have to think about the inheritence (inherit value)). |
|
|
fixed in 4.4.0 rc1 |
