View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|16579||Bug reports||Survey participants (Tokens)||public||2020-08-11 16:34||2020-12-30 19:27|
|Summary||16579: Problem with the error message when a token is already used (inherit)|
|Description||When a token is already used and the error message appear, the admin info and email show the text "Inherit" instead of the inherit values. I tried with the Vanilla theme and I have the same problem.|
|Steps To Reproduce||1. Create a new survey with one question|
2. Generate participants
3. Use the first token to access the survey and complete the survey
4. Try to reuse the same token to access the survey
5. The error message will appear (see attachment)
|Tags||No tags attached.|
|Complete LimeSurvey version number (& build)||Version 4.3.8+200803|
|I will donate to the project if issue is resolved||No|
|Database & DB-Version||5.7.31|
|Server OS (if known)||Linux|
|Webserver software & version (if known)||Apache|
|Same problem when the survey is in english.|
I am not sure if I understand where the bug is - do you want to use the same token for multiple entries?
@cdorin : admin name «inherit«, admin email : «inherit»
Must be inherited value, not the 'inherit' string
|As Denis said. We should not see the text "inherit", but rather its corresponding value.|
|Ah, thanks! got it now :) . Confirmed and reported :)|
|This is not a bug. The value 'inherit' is set for the adminemail in db.|
|This should use the value from the belonging survey group, or what?|
@JHoeck : maybe in DB , this is not the desired behaviour :
It must be same email that the email used when sending email
Or this one shown on Survey settings edit
@ollehar : i finally founs how to set this value by group …
(second pic) : final by global settings
Capture d’écran du 2020-10-30 11-37-40.png (25,275 bytes)
Capture d’écran du 2020-10-30 11-37-40.png (25,275 bytes)
PS : maybe inherit value can be saved as NULL value in DB ?
If we have an administrator with name _inherit_ …
|would be a good idea to set it to null.|
> would be a good idea to set it to null.
Don't do this now, tho. You'd have to change _all_ "inherit" in all database tables to make it consistent.
> Don't do this now, tho. You'd have to change all "inherit" in all database tables to make it consistent.
Maybe , but it's a pity not to have designed it like that from the start
You don't think we can do a DB upgrade an a fix when import (comparing with DB version of the xml) ?
> Maybe , but it's a pity not to have designed it like that from the start
Yeah. A better value than null might be "<inherit>" or "__Inherit" or similar.
> You don't think we can do a DB upgrade an a fix when import (comparing with DB version of the xml) ?
Maybe, but not now, bigger fish to fry. :)
> Yeah. A better value than null might be "<inherit>" or "__Inherit" or similar.
No, i **really** think NULL is better. Null mean : not set, if not set get it elsewhere.
|Null does not communicate intent.|
Anything else can broke with specific need …
null == not set seems clear enough for me :)
> null == not set seems clear enough for me :)
I'm not thinking of you, I'm thinking of someone that sees the database for the first time. Low barrier to enter.
see comment of @JHoeck : i really think she's right :) At fist look : admin name is inherit ("<inherit>" or "__Inherit" or similar.).
With NULL : «There are something strange here : get look at code»
A good discussion for next dev meeting ;)
|Else : `$oSurvey->oOptions->adminemail` and `$oSurvey->oOptions->admin` must be used somewhere in place of `$oSurvey->adminemail` and `$oSurvey->admin`|
|Problem include SurveyGroupsettings somewhere too.|
I think $oSurvey->oOptions do this.
> I think $oSurvey->oOptions do this.
Yes, it does.
What I am not sure now is about inheritance from the global admin settings.
Is that included? IS it expected to be included?
> I'm not thinking of you, I'm thinking of someone that sees the database for the first time. Low barrier to enter.
I agree. It will be also less error prone.
At last, we can always, in the code, adopt the inheritnce behaviour if NULL is found.
> Is that included? IS it expected to be included?
Looking this morning : Survey global settings have gsid = 0
Fixed in branch: bug/issue-16579-problem-with-erro-message-when-token-already-used-inherit
(Replaced $aSurveyInfo['admin'] and $aSurveyInfo['adminemail'] with the survey options values (admin and adminemail). So this is a quick fix for those issues, but in the future we have to think about the inheritence (inherit value)).
|fixed in 4.4.0 rc1|
|2020-08-11 16:34||TonyMonast||New Issue|
|2020-08-11 16:34||TonyMonast||File Added: Screenshot_2020-08-11 ERROR.png|
|2020-08-11 16:44||TonyMonast||Note Added: 59408|
|2020-08-11 16:44||TonyMonast||File Added: error-english.png|
|2020-10-19 11:58||cdorin||Note Added: 60263|
|2020-10-19 11:58||cdorin||Status||new => feedback|
|2020-10-19 13:43||DenisChenu||Note Added: 60264|
|2020-10-19 14:51||TonyMonast||Note Added: 60266|
|2020-10-19 14:51||TonyMonast||Status||feedback => new|
|2020-10-19 16:36||cdorin||Note Added: 60269|
|2020-10-19 16:37||cdorin||Status||new => confirmed|
|2020-10-30 11:23||JHoeck||Note Added: 60454|
|2020-10-30 11:23||JHoeck||File Added: 1231313131.JPG|
|2020-10-30 11:23||JHoeck||Assigned To||=> JHoeck|
|2020-10-30 11:23||JHoeck||Status||confirmed => assigned|
|2020-10-30 11:27||ollehar||Note Added: 60455|
|2020-10-30 11:39||DenisChenu||Note Added: 60457|
|2020-10-30 11:39||DenisChenu||File Added: Capture d’écran du 2020-10-30 11-37-40.png|
|2020-10-30 11:39||DenisChenu||File Added: Capture d’écran du 2020-10-30 11-39-03.png|
|2020-10-30 11:40||DenisChenu||Note Added: 60458|
|2020-10-30 11:57||JHoeck||Note Added: 60460|
|2020-10-30 12:05||ollehar||Note Added: 60461|
|2020-10-30 14:20||DenisChenu||Note Added: 60463|
|2020-10-30 14:21||ollehar||Note Added: 60464|
|2020-10-30 14:24||DenisChenu||Note Added: 60465|
|2020-10-30 14:25||ollehar||Note Added: 60466|
|2020-10-30 14:57||DenisChenu||Note Added: 60468|
|2020-10-30 15:10||ollehar||Note Added: 60469|
|2020-10-30 16:39||DenisChenu||Note Added: 60473|
|2020-11-02 14:28||DenisChenu||Note Added: 60493|
|2020-11-02 14:29||ollehar||Note Added: 60494|
|2020-11-02 14:34||DenisChenu||Note Added: 60495|
|2020-11-02 15:45||gabrieljenik||Note Added: 60496|
|2020-11-02 16:10||DenisChenu||Note Added: 60497|
|2020-11-02 18:15||JHoeck||Note Added: 60499|
|2020-11-02 18:18||JHoeck||Note Edited: 60499||View Revisions|
|2020-11-02 18:18||JHoeck||Status||assigned => resolved|
|2020-11-02 18:18||JHoeck||Resolution||open => fixed|
|2020-12-30 19:27||cdorin||Note Added: 61335|
|2020-12-30 19:27||cdorin||Status||resolved => closed|