View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
16471 | Bug reports | _ Unknown | public | 2020-07-08 16:10 | 2021-04-11 10:59 |
Reporter | jatoko | Assigned To | ollehar | ||
Priority | none | Severity | partial_block | ||
Status | closed | Resolution | unable to reproduce | ||
Product Version | 4.3.0 | ||||
Summary | 16471: Inserted div by CBaseListView contains wrong URL | ||||
Description | The div 'keys' inserted by CBaseListView uses the request URL which misses the baseUrl if a reverse proxy mode is used. This results in error when logging in, deleting responses, filtering responses etc. | ||||
Steps To Reproduce | Change baseUrl | ||||
Additional Information | I submit a pull request to fix this issue. In framework/zii/widgets/CBaseListView.php change: 'title'=>Yii::app()->getRequest()->getUrl(), to 'title'=>Yii::app()->getBaseURL().Yii::app()->getRequest()->getUrl(), | ||||
Tags | No tags attached. | ||||
Bug heat | 10 | ||||
Complete LimeSurvey version number (& build) | 4.3.0+200616 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | |||||
Database type & version | 15.1 Distrib 10.1.44-MariaDB | ||||
Server OS (if known) | |||||
Webserver software & version (if known) | |||||
PHP Version | 7.3 | ||||
Even without proxy : see https://www.yiiframework.com/doc/api/1.1/CHttpRequest#getUrl-detail " Else : i think we need baseUrl not absolute URL Proxy issue ? |
|
It's better if we don't force url … and keep relative URL |
|
If i don't make error : you can force baseUrl with
https://manual.limesurvey.org/Optional_settings#Request_settings |
|
I have the feeling this will faile if LS in a subfolder. |
|
Yes, the path seems to be wrong if LS is installed ina subfolder. How is this "keys" div used for? Please take into account we are updating a base thing from Yii. What are we tryingto accomplish? Thanks! |
|
Hi! Sorry for my late response, but I only managed to look into this issue again today. We had the folling issue:
Navigating manually to proxyUrl/index.php/admin after login loads all ressources just fine. Fix: in /application/controllers/admin/authentication.php in doRedirect() (-) $returnUrl = App()->user->getReturnUrl(array('/admin')); (+) App()->getController()->redirect(array('/admin')); Now this fixes our issue. I do not remeber if we had any other issue which made me suggest changes to Yii. So I believe that this is the "real" issue. Sorry for confusion. |
|
On step #3, can you please describe which is the full url that you are getting and which is the full url that you are expecting? The change that you suggest breaks the feature of allowing the user to return to the url which was intended to lad before the login screen appeared. |
|
Here is the full call stack (example): "custom/path" is ignored, while all other requests work fine and include the path. Browser history works fine of course. Interestingly, filter options when looking at survey responses have the same problem too. For example, filter for completed answers only leads to wrong POST: |
|
Related ? |
|
As far as I understand multiviews, the suggested related buck relies on rewrites done by apache which it should not be doing. In our case, however, the limesurvey application uses wrong URLs. I still believe the problem related to using YII "getUrl".
|
|
*sorry for typo: I meant bug but cannot edit the post? |
|
PS : i have a lot of instance in subfolder : then it's not related to only the subfolder .... |
|
PS2 : see https://www.yiiframework.com/doc/api/1.1/CHttpRequest#getRequestUri-detail
proxy issue in my opinion. |
|
I think this is about reverse proxy. Still, we were not able to reproduce it with reverse proxy. Says exactly the same as here. |
|
As to be cleat, please @jatoko can you confirm you have applied this configuration? We will continue reviewing and trying to reproduce after. Thansk! |
|
Please check if this bug still exists in the latest patch release. Thank you. |
|
I updated to Version 4.4.11+210301, but the problem still exists i.e. the requested filename is missing the 'baseUrl'-prefix. Our setup: [Nginx] <=> [Apache + LimeSurvey] According to YII Framework, Apache does not require any special config. This is our LS configuration (config.php): This is our Nginx configuration: |
|
And your suggested fix is still this line? (+) App()->getController()->redirect(array('/admin')); |
|
Hello jatoko, we have asked for feedback on this issue. Because we did not get an answer we assume that the issue is resolved. Thank you and best regards, c_schmitz |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2020-07-08 16:10 | jatoko | New Issue | |
2020-07-08 16:45 | DenisChenu | Note Added: 58800 | |
2020-07-08 16:46 | DenisChenu | Note Added: 58801 | |
2020-07-08 16:50 | DenisChenu | Note Added: 58802 | |
2020-10-15 22:37 | gabrieljenik | Note Added: 60220 | |
2020-10-16 01:00 | gabrieljenik | Note Added: 60221 | |
2020-10-16 01:00 | gabrieljenik | File Added: image.png | |
2020-11-01 12:31 | jatoko | Note Added: 60484 | |
2020-11-26 20:22 | gabrieljenik | Note Added: 60767 | |
2020-11-26 20:23 | gabrieljenik | Note Edited: 60767 | |
2020-11-27 00:18 | jatoko | Note Added: 60770 | |
2020-11-27 07:59 | DenisChenu | Note Added: 60772 | |
2020-11-27 10:51 | jatoko | Note Added: 60779 | |
2020-11-27 10:51 | jatoko | File Added: ls_bug.png | |
2020-11-27 10:51 | jatoko | File Added: ls_bug2.png | |
2020-11-27 10:53 | jatoko | Note Added: 60780 | |
2020-11-27 10:59 | DenisChenu | Note Added: 60781 | |
2020-11-27 11:00 | DenisChenu | Note Added: 60782 | |
2020-11-27 20:31 | gabrieljenik | Note Added: 60790 | |
2020-11-30 14:08 | gabrieljenik | Note Added: 60805 | |
2021-03-03 16:05 | ollehar | Assigned To | => ollehar |
2021-03-03 16:05 | ollehar | Status | new => feedback |
2021-03-03 16:05 | ollehar | Note Added: 62686 | |
2021-03-04 11:56 | jatoko | Note Added: 62711 | |
2021-03-04 11:56 | jatoko | Status | feedback => assigned |
2021-03-05 17:21 | ollehar | Note Added: 62796 | |
2021-03-09 12:47 | ollehar | Severity | block => partial_block |
2021-03-10 14:01 | c_schmitz | Status | assigned => feedback |
2021-04-11 10:59 | c_schmitz | Status | feedback => closed |
2021-04-11 10:59 | c_schmitz | Resolution | open => unable to reproduce |
2021-04-11 10:59 | c_schmitz | Note Added: 63908 |