View Issue Details

IDProjectCategoryView StatusLast Update
16471Bug reports_ Unknownpublic2020-10-16 01:00
Reporterjatoko Assigned To 
PrioritynoneSeverityblock 
Status newResolutionopen 
Product Version4.3.0 
Summary16471: Inserted div by CBaseListView contains wrong URL
Description

The div 'keys' inserted by CBaseListView uses the request URL which misses the baseUrl if a reverse proxy mode is used. This results in error when logging in, deleting responses, filtering responses etc.

Steps To Reproduce

Change baseUrl
Load login page
login
get error page

Additional Information

I submit a pull request to fix this issue.

In framework/zii/widgets/CBaseListView.php change:

'title'=>Yii::app()->getRequest()->getUrl(),

to

'title'=>Yii::app()->getBaseURL().Yii::app()->getRequest()->getUrl(),

TagsNo tags attached.
Complete LimeSurvey version number (& build)4.3.0+200616
I will donate to the project if issue is resolvedNo
Browser
Database & DB-Version15.1 Distrib 10.1.44-MariaDB
Server OS (if known)
Webserver software & version (if known)
PHP Version7.3

Activities

DenisChenu

DenisChenu

2020-07-08 16:45

developer   ~58800

misses the baseUrl if a reverse proxy mode is used.

Even without proxy : see https://www.yiiframework.com/doc/api/1.1/CHttpRequest#getUrl-detail "

Else : i think we need baseUrl not absolute URL

Proxy issue ?

DenisChenu

DenisChenu

2020-07-08 16:46

developer   ~58801

It's better if we don't force url … and keep relative URL

DenisChenu

DenisChenu

2020-07-08 16:50

developer   ~58802

If i don't make error : you can force baseUrl with

        // Enforce a certain URL base 
        'request' => array(
            'hostInfo' => 'http://www.example.org/'  
            ),

https://manual.limesurvey.org/Optional_settings#Request_settings

gabrieljenik

gabrieljenik

2020-10-15 22:37

developer   ~60220

I have the feeling this will faile if LS in a subfolder.
I am tsting it!

gabrieljenik

gabrieljenik

2020-10-16 01:00

developer   ~60221

Yes, the path seems to be wrong if LS is installed ina subfolder.
Check attachment please,

How is this "keys" div used for?

Please take into account we are updating a base thing from Yii.
Not sure that's the best.

What are we tryingto accomplish?
Can you elaborate more?

Thanks!

image.png (6,531 bytes)   
image.png (6,531 bytes)   

Issue History

Date Modified Username Field Change
2020-07-08 16:10 jatoko New Issue
2020-07-08 16:45 DenisChenu Note Added: 58800
2020-07-08 16:46 DenisChenu Note Added: 58801
2020-07-08 16:50 DenisChenu Note Added: 58802
2020-10-15 22:37 gabrieljenik Note Added: 60220
2020-10-16 01:00 gabrieljenik Note Added: 60221
2020-10-16 01:00 gabrieljenik File Added: image.png