https://github.com/LimeSurvey/LimeSurvey/pull/1444

Made a small error in https://github.com/LimeSurvey/LimeSurvey/pull/1444. second commit is the valid one!

Oops.. I think there is the same problem in the getXMLDataSingleTable() function..
I can' test that right now!

on line 998 there is also to much ($xml->endElement(); // close columns)
https://github.com/LimeSurvey/LimeSurvey/pull/1444/commits/0c56e8f067a1dd5979d3e212c53876335a6891db

Please look at every
$xml->endElement(); // close columns
line in /application/helpers/export_helper.php.. I think they are all at fault and should be removed!
As I say I can't test them all!

Creating a new survey based on an existing survey in the adminpanel from Limesurvey (copy a survey) is also not working.
Fixed with the above pull-request.

@carsten IMHO it is NOT fixed in https://github.com/LimeSurvey/LimeSurvey/commit/a877f78df366fd5ff1546f41389e3a775eb0a83c

Are you using MySQL 8?

IMHO: The wrong XML has nothing to do with MYSQL8.. It just is not valid anymore. Due to one close tag to many.
Therefore look in the code to every line with
$xml->endElement(); // close columns
This line renders the XML invalid!

It has to do with MySQL 8 due to the new keyword "groups", our escaping fix, and a pattern match.

@asshank : i juts update 3.X this morning (yes : 3.X)

Before the update : xml broken, after update : xml OK …

Unsure it's this fix , but : please can you check ?

we prefer to concentrate our testing to 4.x.
As far as I know there was no issue in 3.x.
without the fix we can't copy a survey in 4.3, with the suggested fix we can..

You use git to pull?

I mean : test on 4.X :)

https://github.com/LimeSurvey/LimeSurvey/pull/1444

Can you attach an lss file with which we can reproduce the issue? Or describe in detail how to reproduce it. Thank you.

Before Mise à jour e55a12f35b..a877f78df3

See screnshot (debug =2)

After :
see lss (broken)

Capture d’écran du 2020-06-25 15-28-20.png (20,922 bytes)   

Capture d’écran du 2020-06-25 15-28-20.png (20,922 bytes)   

@asshank : rthink your last commit are an issue : https://github.com/LimeSurvey/LimeSurvey/pull/1444/commits/16a78259429d412b512c5439a5e8045907ad571d

Because there was no reaction on my fix yesterday I tried to wothdraw the pull...

this https://github.com/LimeSurvey/LimeSurvey/pull/1444/commits/0c56e8f067a1dd5979d3e212c53876335a6891db php has the correct code to get Copy Survey working again!

But I noticed a lot of problems.. boiling down to the lines with
$xml->endElement(); // close columns

See earlies comments

I just pushed another fix to LS3. I will cherry-pick it into LS4.

Hm, looks like the needed fix was already applied to LS4.

In any case, more info needed to be able to reproduce.

in github I see the FIX from Carsten 14 hours ago.
But my fix about the $xml->endElement(); // close columns is NOT there!
But maybe I'm looking in the wrong branch in github!? https://github.com/LimeSurvey/LimeSurvey/blob/master/application/helpers/export_helper.php

We have exactly this patch https://github.com/LimeSurvey/LimeSurvey/pull/1444/commits/0c56e8f067a1dd5979d3e212c53876335a6891db installed on our Lime4 (limesurvey4.3.1+200623) and we can Copy Surveys again!

Please understand, without proper instructions of how to reproduce the issue, we can't help you.

@asshank : i just with last git version

1. Create a new survey with checking 'create sample question'
2. Export without updating it
3. Can be imported

MLaybe some other fix fix differently … we don't have this issue at start of 4.0 : xml is OK

Just did a test with Version 4.3.1+200623.
importing the lss from Denis [limesurvey_survey_created.lss] goes perfect.
copying the survey generates the discussed error.
See attached screenshots

2020-06-26_09h32_08.png (46,958 bytes)   

2020-06-26_09h32_08.png (46,958 bytes)   

2020-06-26_09h31_39.png (33,192 bytes)   

2020-06-26_09h31_39.png (33,192 bytes)   

Just did a test with Version 4.3.1+200623.

This commit : https://github.com/LimeSurvey/LimeSurvey/commit/a877f78df366fd5ff1546f41389e3a775eb0a83c is not in 4.3.1+200623.

No, but it will be in 4.3.2 on Monday. :)

Probably your looking ay the version modified by Carsten.
w'll simply wait for the new version and test it again.
We have our own fix that we can use for now :)
To be continued!

@asshank : but you can test applying the fix :)

Please test with new release next Monday.

tested, seems to be working now.
thanks!