View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
16415 | Bug reports | Other | public | 2020-06-22 19:29 | 2020-06-26 13:23 |
Reporter | criugmls | Assigned To | |||
Priority | none | Severity | partial_block | ||
Status | closed | Resolution | fixed | ||
Product Version | 3.22.19 | ||||
Summary | 16415: can't upload files with Google Chrome | ||||
Description | Version 3.22.18+200603 Upload with Chrome was fixed in 3.22.18 Can upload with Edge or Firefox, but not with Google Chrome. Chrome : Version 83.0.4103.116 (Build officiel) (64 bits) | ||||
Steps To Reproduce | You can test it here : | ||||
Tags | No tags attached. | ||||
Attached Files | |||||
Bug heat | 14 | ||||
Complete LimeSurvey version number (& build) | 3.22.18+200603 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | |||||
Database type & version | mysql Ver 14.14 Distrib 5.7.30, for Linux (x86_64) | ||||
Server OS (if known) | Ubuntu 16.04.6 LTS | ||||
Webserver software & version (if known) | |||||
PHP Version | PHP Version 7.0.33-0ubuntu0.16.04.14 | ||||
related to | 16395 | closed | cdorin | file upload crash randomly |
related to | 16346 | closed | p_teichmann | File Upload modal not working correctly in Chromium 83.0.x (LS3) |
I just tested it with Chrome Version 83.0.4103.97 (build official) (64 bits) amn it worked. I updated Chrome on the same machine to 83.0.4103.116 (official build) (64 bits) and it stopped working. So, I presume Google Chrome 83.0.4103.116 is the trouble maker. |
|
Seem to work one time, then it stop working. |
|
Do not have any issues - cannot reproduce (played with your installation) I will ask my colleagues for further testing. LE: Meanwhile, can you please upgrade to the latest LTS release and try again? |
|
I will update to limesurvey3.22.21+200622 tonight, and let you know. I can easily reproduce the error: |
|
Ok, so I cannot reproduce it on the latest Chrome (83.0.4103.116) - I use Ubuntu 20.04. |
|
Yes, you take the "private" status out. |
|
I cannot reproduce the problem either on ubuntu 18 (Chrome 83.0.4103.116). |
|
I just updated to LimeSurvey Version 3.22.21+200622 |
|
Tested the issue on the latest chrome (Version 83.0.4103.116 (Official Build) (64-bit)), i am not able to upload the file anyways. |
|
|
|
Issue moved to confirmed |
|
For information : It's OK. Related to operating system. |
|
From what I was able to see (and understand), the issue happens because of some false positive load events of the iframe. There are already some filters, so I am adding a new one. |
|
We could be checking the src of the iframe as an extra filtering layer. |
|
We must move to something without iframe ;) : https://bugs.limesurvey.org/view.php?id=14664 But take more time. And : use jquery ajax too, not own functionnality … real XHR … |
|
@gabrieljenik |
|
Commenting this line make it work again. |
|
|
|
I just followed the gabrieljenik github fix. |
|
Hi All, That was a WIP which still needed testing. I see that fix wasn't good enough and then suggested rolling back and removing the srcdoc line. |
|
Sure, gabriel. Thanks for help! :) If you need help with testing, can jump in anytime. |
|
This modification in on my server since yesterday (commenting the srcdoc line). If you need help for further testing, let me know. |
|
OK, this could be a possible explanation for what happened: From my understanding: |
|
I tested by going back to Release 3.22.17+200525(Step 0 in above comment), i was able to successfully do the file upload and than i checked out to latest PR(Step 5 in above comment) and tested seems to work fine there as well. |
|
Then the issue are added between 22.17 and current ? Because we add a workaround for a chrome bug ? |
|
Yes, it seems so |
|
@sushmanadendla ,Im sorry but what is "the latest PR"? |
|
Hey @criugmls - please see: https://github.com/LimeSurvey/LimeSurvey/pull/1445 . Gabriel deleted the fix provided some time ago by Patrick. Have time to test it? If everything ok, we will release LTS tomorrow once again. |
|
I commented the line yesterday. No problem since. I just deleted it completly today and the upload question is still OK. You can test it here: |
|
great, then a new release will come tmrw. Thanks for quick update. (saw too late which lines were commented out, basically those were deleted) |
|
Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30220 |
|
Fixed in Release 3.22.23+200626 |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2020-06-22 19:29 | criugmls | New Issue | |
2020-06-22 19:29 | criugmls | File Added: upload.png | |
2020-06-22 20:08 | criugmls | Note Added: 58382 | |
2020-06-22 21:10 | criugmls | Note Added: 58383 | |
2020-06-22 23:06 | cdorin | Note Added: 58386 | |
2020-06-22 23:08 | cdorin | Note Edited: 58386 | |
2020-06-22 23:18 | criugmls | Note Added: 58387 | |
2020-06-22 23:25 | cdorin | Note Added: 58388 | |
2020-06-22 23:27 | criugmls | Note Added: 58389 | |
2020-06-22 23:35 | cdorin | View Status | private => public |
2020-06-22 23:35 | cdorin | Description Updated | |
2020-06-22 23:35 | cdorin | Steps to Reproduce Updated | |
2020-06-22 23:48 | criugmls | Note Added: 58391 | |
2020-06-23 04:51 | criugmls | Note Added: 58392 | |
2020-06-23 10:26 |
|
Note Added: 58394 | |
2020-06-23 10:26 |
|
File Added: FIleUpload_Notworking.gif | |
2020-06-23 11:16 | DenisChenu | Note Added: 58395 | |
2020-06-23 11:17 | DenisChenu | Note Added: 58396 | |
2020-06-23 11:18 | DenisChenu | Relationship added | related to 16395 |
2020-06-23 12:04 |
|
Reproducibility | have not tried => always |
2020-06-23 12:04 |
|
Status | new => confirmed |
2020-06-23 12:04 |
|
Zoho Sprints | => |Yes| |
2020-06-23 12:04 |
|
Note Added: 58398 | |
2020-06-23 12:04 |
|
Zoho Sprints ID | => 14469000000144001 |
2020-06-23 12:10 |
|
Zoho Sprints | Yes => |
2020-06-23 13:32 | DenisChenu | Note Added: 58401 | |
2020-06-23 13:32 | DenisChenu | File Added: Capture d’écran du 2020-06-23 13-31-04.png | |
2020-06-23 21:12 | gabrieljenik | Note Added: 58418 | |
2020-06-23 21:29 | gabrieljenik | Note Added: 58419 | |
2020-06-24 07:04 | DenisChenu | Note Added: 58422 | |
2020-06-24 07:07 | DenisChenu | Note Edited: 58422 | |
2020-06-24 18:23 | criugmls | Note Added: 58428 | |
2020-06-24 19:20 | criugmls | Note Added: 58429 | |
2020-06-24 19:21 | DenisChenu | Note Added: 58430 | |
2020-06-24 19:21 | DenisChenu | Note Edited: 58430 | |
2020-06-24 19:25 | criugmls | Note Added: 58431 | |
2020-06-25 13:27 | gabrieljenik | Note Added: 58451 | |
2020-06-25 13:52 | cdorin | Note Added: 58452 | |
2020-06-25 15:17 | criugmls | Note Added: 58457 | |
2020-06-25 17:27 | gabrieljenik | Relationship added | related to 16346 |
2020-06-25 17:31 | gabrieljenik | Note Added: 58486 | |
2020-06-25 18:03 |
|
Note Added: 58489 | |
2020-06-25 18:03 |
|
File Added: 16415_FileUpload_LTS3X.png | |
2020-06-25 18:09 |
|
Note Edited: 58489 | |
2020-06-25 18:12 | DenisChenu | Note Added: 58493 | |
2020-06-25 18:17 |
|
Note Added: 58496 | |
2020-06-25 18:59 | criugmls | Note Added: 58500 | |
2020-06-25 21:58 | cdorin | Note Added: 58502 | |
2020-06-25 22:16 | criugmls | Note Added: 58505 | |
2020-06-25 22:16 | cdorin | Note Added: 58506 | |
2020-06-25 22:17 | cdorin | Note Edited: 58506 | |
2020-06-26 12:23 | gabrieljenik | Changeset attached | => LimeSurvey 3.x-LTS b8ff095f |
2020-06-26 12:23 | guest | Note Added: 58521 | |
2020-06-26 13:23 | lime_release_bot | Note Added: 58522 | |
2020-06-26 13:23 | lime_release_bot | Status | confirmed => closed |
2020-06-26 13:23 | lime_release_bot | Resolution | open => fixed |