View Issue Details

IDProjectCategoryView StatusLast Update
16321Bug reportsOtherpublic2020-05-25 17:47
ReporterJmantysalo Assigned Tocdorin  
PrioritynoneSeveritypartial_block 
Status confirmedResolutionopen 
Product Version4.2.4 
Summary16321: Email template : shown HTML editor if email set as text.
Description

Changing the text in Basic admin notification results to mails that have HTML code shown directly in the mail, i.e. mails have Content-Type: text/plain but it starts with "<p>A test</p>" and so on.

Steps To Reproduce

Import included survey,
Check email HTML setting
Go to email template edit.

TagsNo tags attached.
Complete LimeSurvey version number (& build)Versio 4.2.4+200520
I will donate to the project if issue is resolvedNo
BrowserFirefox, newest available on Ubuntu 20.04
Database & DB-VersionN/A
Server OS (if known)
Webserver software & version (if known)
PHP VersionN/A

Activities

DenisChenu

DenisChenu

2020-05-22 17:43

developer   ~57987

Please : send a simple lss.

What is the settings of https://manual.limesurvey.org/Participant_settings#Use_HTML_format_for_token_emails

Since 1.92 : these settings was used too for admin notification too if i don't make error.

Jmantysalo

Jmantysalo

2020-05-22 20:28

reporter   ~57993

Thanks! Setting mail format to HTML works. Hence the severity of this issue should be lowered.

So there are two bugs: first for some of the mails when not using html format, and second about the string. "Use HTML format for participant emails:" should be "Use HTML format for emails:". Can these be corrected together?

DenisChenu

DenisChenu

2020-05-22 20:58

developer   ~57994

If settings is set to 'text' : HTML editor must not be launched on all emails : it'(s the case or not ?

"Use HTML format for participant emails:" should be "Use HTML format for emails:"
Right :) and manual need update too.

Jmantysalo

Jmantysalo

2020-05-22 21:05

reporter   ~57995

Might be easier if the system would just strip html tags when sending plain text.

Also, the place for this switch should not be on Participant settings, but instead on Notifications & data. I have no idea how complicated the change is.

DenisChenu

DenisChenu

2020-05-23 10:33

developer   ~57999

Might be easier if the system would just strip html tags when sending plain text.

Can be a plugin, since we have it like this since 1.92

Also, the place for this switch should not be on Participant settings, but instead on Notifications & data. I have no idea how complicated the change is.

Right, unsure of other dev position

Jmantysalo

Jmantysalo

2020-05-23 11:04

reporter   ~58000

Actually: Do we really need a plain text emails? Personally I use mostly Alpine which is text-based, but even it can show about every mail I got.

DenisChenu

DenisChenu

2020-05-23 18:41

developer   ~58001

We send email in both format if set as html.

DenisChenu

DenisChenu

2020-05-24 10:59

developer   ~58003

Might be easier if the system would just strip html tags when sending plain text.

No : we can not know what is the desired behaviour … maybe have a system send email in txt format to a system who read email and create an HTML page …

It's the difficult way of a system with a lot of user : never update something if it can broke something other, or : create it a a default system with option/plugin/extension.

Jmantysalo

Jmantysalo

2020-05-24 20:11

reporter   ~58006

No : we can not know what is the desired behaviour - -

True, good practise.

DenisChenu

DenisChenu

2020-05-25 17:40

developer   ~58014

There are an issue with "Reset to defaut" : it don't reset in the good formùat , and reste falsly the title.

I report it on another number

DenisChenu

DenisChenu

2020-05-25 17:42

developer   ~58015

Issue History

Date Modified Username Field Change
2020-05-22 09:47 Jmantysalo New Issue
2020-05-22 17:43 DenisChenu Note Added: 57987
2020-05-22 20:28 Jmantysalo Note Added: 57993
2020-05-22 20:58 DenisChenu Note Added: 57994
2020-05-22 21:05 Jmantysalo Note Added: 57995
2020-05-23 10:33 DenisChenu Note Added: 57999
2020-05-23 10:33 DenisChenu Assigned To => DenisChenu
2020-05-23 10:33 DenisChenu Status new => assigned
2020-05-23 11:04 Jmantysalo Note Added: 58000
2020-05-23 18:41 DenisChenu Note Added: 58001
2020-05-24 10:59 DenisChenu Note Added: 58003
2020-05-24 20:11 Jmantysalo Note Added: 58006
2020-05-25 17:40 DenisChenu Note Added: 58014
2020-05-25 17:41 DenisChenu Summary Basic admin notification, html shown as text => Email template : shown HTML editor if email set as text.
2020-05-25 17:42 DenisChenu Steps to Reproduce Updated View Revisions
2020-05-25 17:42 DenisChenu Note Added: 58015
2020-05-25 17:42 DenisChenu File Added: Capture d’écran du 2020-05-25 17-41-43.png
2020-05-25 17:42 DenisChenu File Added: limesurvey_survey_emailAsText.lss
2020-05-25 17:44 DenisChenu Assigned To DenisChenu => cdorin
2020-05-25 17:44 DenisChenu Status assigned => confirmed