View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update | 
|---|---|---|---|---|---|
| 16208 | Bug reports | Survey taking | public | 2020-04-29 21:59 | 2020-12-30 19:27 | 
| Reporter | nicolasgoudard | Assigned To | DenisChenu | ||
| Priority | urgent | Severity | crash | ||
| Status | closed | Resolution | fixed | ||
| Product Version | 4.2.0 | ||||
| Fixed in Version | 4.2.2 | ||||
| Summary | 16208: serious escape bug in Multiple choice with comments (P) | ||||
| Description | Hello . I use want report bug on Limesurvey Version 4.2.0+200422 In the field type  "Multiple choice with comments (P)"  there is a serious bug Best regards  | ||||
| Steps To Reproduce | Add  field type   "Multiple choice with comments (P)"  | ||||
| Tags | answers, data types, error!, escapes, quote, subquestion | ||||
| Bug heat | 10 | ||||
| Complete LimeSurvey version number (& build) | Limesurvey Version 4.2.0+200422 | ||||
| I will donate to the project if issue is resolved | No | ||||
| Browser | all | ||||
| Database type & version | Mariadb | ||||
| Server OS (if known) | |||||
| Webserver software & version (if known) | |||||
| PHP Version | 7 | ||||
| 
	 This should be solved, and needs a regression test as well.  | 
|
| 
	 It does not work only when the user update his own survey and introduce a quote in updating the comment. For new answers (insert) there is not bug.  | 
|
| 
	 Ah.  | 
|
| 
	 @nicolasgoudard : only when reload by token ? Or move previous/move next too ?  | 
|
| 
	 @ollehar : i take a look, i assign it to me (or not) before end of this afternoon.  | 
|
| 
	 OK : question encoding must be done by twig or by code ? My opinion : by twig , never by code  | 
|
| 
	 I have checked again : in really, the  bug  happened  when select from database before  display, not in insert or update.  | 
|
| 
	 Then :https://github.com/LimeSurvey/LimeSurvey/pull/1414 Need Dev discussion (in my opinion) and to be documented for Question Theme dev. @tparner : Maybe maybe you have an opinion ? Value encoded or not ?  | 
|
| 
	 @nicolasgoudard : no need reloading :) Previous do the trick  | 
|
| 
	 Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=29960  | 
|
| 
	 Thank you, Denis !  | 
|
| 
	 Can not update https://manualv4.limesurvey.org/Question_themes about text encoded.  | 
|
| 
	 @cdorin : can you check the manual ?  | 
|
	
  | 
|
| 
	 fixed in 4.4.0 rc1  | 
|
| 
	
	 LimeSurvey: master c66766fc 2020-05-06 14:58 Details Diff  | 
Fixed issue 16208: escape in Multiple choice with comments Dev: Encode in renderClass Dev: don't fix the param for previous questiontheme compatibility Dev: CHtml::encode are htmlspecialchars($dispVal, ENT_QUOTES,Yii::app()->charset) Dev: then good replacer  | 
Affected Issues 16208  | 
|
| mod - application/core/QuestionTypes/MultipleChoiceWithComments/RenderMultipleChoiceWithComments.php | Diff File | ||
| Date Modified | Username | Field | Change | 
|---|---|---|---|
| 2020-04-29 21:59 | nicolasgoudard | New Issue | |
| 2020-04-29 22:09 | nicolasgoudard | Tag Attached: quote | |
| 2020-04-29 22:09 | nicolasgoudard | Tag Attached: escapes | |
| 2020-04-29 22:09 | nicolasgoudard | Tag Attached: error! | |
| 2020-04-29 22:09 | nicolasgoudard | Tag Attached: data types | |
| 2020-04-29 22:09 | nicolasgoudard | Tag Attached: answers | |
| 2020-04-29 22:09 | nicolasgoudard | Tag Attached: subquestion | |
| 2020-04-30 10:24 | ollehar | Priority | none => urgent | 
| 2020-04-30 10:24 | ollehar | Severity | partial_block => crash | 
| 2020-04-30 10:25 | ollehar | Note Added: 57485 | |
| 2020-04-30 11:31 | nicolasgoudard | Note Added: 57489 | |
| 2020-04-30 14:24 | DenisChenu | Issue Monitored: DenisChenu | |
| 2020-04-30 14:29 | ollehar | Note Added: 57495 | |
| 2020-04-30 14:33 | DenisChenu | Note Added: 57497 | |
| 2020-04-30 14:34 | DenisChenu | Note Added: 57498 | |
| 2020-04-30 18:37 | DenisChenu | Note Added: 57507 | |
| 2020-04-30 18:48 | nicolasgoudard | Note Added: 57508 | |
| 2020-04-30 18:52 | DenisChenu | Note Added: 57509 | |
| 2020-04-30 19:45 | DenisChenu | Note Added: 57510 | |
| 2020-04-30 19:45 | DenisChenu | File Added: Peek 30-04-2020 19-44.gif | |
| 2020-04-30 19:45 | DenisChenu | File Added: limesurvey_survey_multipleWithComment.lss | |
| 2020-05-06 12:59 | DenisChenu | Changeset attached | => LimeSurvey master c66766fc | 
| 2020-05-06 12:59 | DenisChenu | Note Added: 57576 | |
| 2020-05-06 12:59 | DenisChenu | Assigned To | => DenisChenu | 
| 2020-05-06 12:59 | DenisChenu | Resolution | open => fixed | 
| 2020-05-06 13:04 | DenisChenu | Status | new => resolved | 
| 2020-05-06 13:04 | DenisChenu | Fixed in Version | => 4.2.2 | 
| 2020-05-06 13:04 | cdorin | Note Added: 57577 | |
| 2020-05-06 13:07 | DenisChenu | Note Added: 57578 | |
| 2020-05-06 13:07 | DenisChenu | Note Added: 57579 | |
| 2020-05-06 13:07 | DenisChenu | Note Added: 57580 | |
| 2020-12-30 19:27 | cdorin | Note Added: 61358 | |
| 2020-12-30 19:27 | cdorin | Status | resolved => closed | 
| 2021-08-02 17:18 | guest | Bug heat | 8 => 10 |