View Issue Details

This bug affects 1 person(s).
 10
IDProjectCategoryView StatusLast Update
16115Bug reportsImport/Exportpublic2020-04-14 16:02
Reporterlterfloth Assigned Toc_schmitz  
PriorityurgentSeveritycrash 
Status closedResolutionreopened 
Product Version4.1.5 
Summary16115: .lsg import doesn't work with array-questiontype
Description

Hey there,

NOTE: WE ARE ON 4.1.4 - this is not available in the dropdown.

I imported a .lsg that contains 2 array questions with each 5 subquestions and a 0 to 10 (agree - disagree) scale. I exported a working group from another colleagues survey and imported it to my survey which lead to the following issues:

1) the subquestions textfields were empty after importing them
2) editing the subquestion textfields lead to an error after saving "Call to a member function setAttributes() on null"

I can't find a way around this bug.

Steps To Reproduce

Import the added questiongroup and bug 1) is reproduced.

Then edit the subquestion-textfields/add one subquestion and hit save, that should reproduce bug 2)

Tags4.1.16, 4.1.4, import
Attached Files
limesurvey_group_443.lsg (26,759 bytes)
Bug heat10
Complete LimeSurvey version number (& build) 4.1.4 Build 200214
I will donate to the project if issue is resolvedYes
BrowserChrome and Firefox - did not test others.
Database type & versionmysql, mysqlnd 5.0.12-dev - 20150407 - $Id: 3591daad22de08524295e1bd073aceeff11e6579 $
Server OS (if known)Linux 3.16.0-10-amd64 #1 SMP Debian 3.16.81-1 (2020-01-17) x86_64
Webserver software & version (if known) Apache/2.4.10 (Debian)
PHP Version7.2.29-1+0~20200320.39+debian8~1.gbp513c2e

Users monitoring this issue

There are no users monitoring this issue.

Activities

lterfloth

lterfloth

2020-04-08 11:23

reporter   ~57021

Announcement: tested it on the LimeSurvey DevDemo https://demo.limesurvey.org/index.php?r=admin as well (Thanks, _olle!) which was running 4.1.16. The bug is still present there.

lterfloth

lterfloth

2020-04-08 11:31

reporter   ~57022

Last edited: 2020-04-08 11:38

This issues is blocking us from rolling out our latest, updated survey to our at-th-ready participants. We are not able to properly edit the necessary changes into our survey as the error prevents a successfull save.

ollehar

ollehar

2020-04-08 11:34

administrator   ~57024

Last edited: 2020-04-08 11:38

You can also

1) Give us a screenshot of "Call to a member function setAttributes() on null"

2) Enable debug = 2 in application/config/config.php and give us a screenshot of "Call to a member function setAttributes() on null" or the full error

cdorin

cdorin

2020-04-08 11:38

reporter   ~57025

Last edited: 2020-04-08 11:38

I also have the issue, thanks for report.

c_schmitz

c_schmitz

2020-04-08 11:58

administrator   ~57026

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=29817

c_schmitz

c_schmitz

2020-04-08 12:00

administrator   ~57027

The problem seems to be the export, not the import.
lterfloth, please apply the fix below, export the group again and see if it can be imported successfully this time.

lterfloth

lterfloth

2020-04-08 12:01

reporter   ~57028

Wow that was quick. Will try and report back, thank you.

lterfloth

lterfloth

2020-04-08 12:02

reporter   ~57029

The link you provided is not working. Found the change on GitHub though. Do we just have to overwrite the file for an update?

lterfloth

lterfloth

2020-04-08 13:38

reporter   ~57031

Update: we applied the fix by just changing line 1943, nothing else. When clicking the export group button, an error appears (see attached screenshot)

c_schmitz

c_schmitz

2020-04-08 16:44

administrator   ~57032

You must not have changed the line properly. please try again.

lterfloth

lterfloth

2020-04-09 11:08

reporter   ~57040

This is the environment/block we changed the line in:

// Questions localization
$qqueryl10n = "SELECT {{question_l10ns}}.*
FROM {{question_l10ns}}
JOIN {{questions}} ON {{question_l10ns}}.qid = {{questions}}.qid
WHERE gid=$gid order by question_order, {{question_l10ns}}.language, scale_id";
buildXMLFromQuery($xml, $qqueryl10n, 'question_l10ns');

I'll get the full export_helper.php-file later today, will attach that one as soon as possible so you can compare it. Again info: we are on 4.1.4, might have to do with that version as well? No chance for us to test on 4.1.16 atm.

lterfloth

lterfloth

2020-04-09 14:16

reporter   ~57053

Attached the export_helper.php we are using. The file is on version 4.1.4 and no changes were made. Just that single line got replaced according to the sysadmin.

export_helper.php (125,594 bytes)
ollehar

ollehar

2020-04-09 14:20

administrator   ~57054

Revert all your changes. We don't offer personal support to non-paying users. Either wait for the release or ask on our forum.

lterfloth

lterfloth

2020-04-09 14:25

reporter   ~57055

I know that you are not offering "personal support", do not need to put emphasis on that. We are calmly waiting and not pressuring you in any way. Maybe I misunderstood the way you communicate within the bugtracker, sorry for not knowing your culture in this regard. The only thing I did was responding to the requests made by c_schmitz. I do not understand such a passive-aggressive response, as I was only trying to give you as much info as possible.

cdorin

cdorin

2020-04-09 15:43

reporter   ~57057

Hello @lterfloth, we did not mean to answer you harshly - and it definitely was not Olle's intention ^^ .

Regarding your problem, please note that we cannot test in 4.1.4 - all the fixes are provided based on the latest stable version which is at the moment 4.1.16.

Also the issue was not completely solved: the subquestion text is exported, but it does not seem to be imported - If @c_schmitz does not have time for this issue, I will make sure to be part of the next round of bug fixing. (changing status now)

ollehar

ollehar

2020-04-09 16:56

administrator   ~57059

Last edited: 2020-04-09 16:58

@lterfloth Yeah, sorry, I had a root canal filling this morning, haha. It got to me.

c_schmitz

c_schmitz

2020-04-09 20:01

administrator   ~57062

Last edited: 2020-04-09 20:01

@lterfloth, sorry for the confusion. Please test and let me know if it works now.
If it does not, please add the survey (even with only that one question group) as .lss file (not .lsg) so I can test your case properly. Thank you for your help.

c_schmitz

c_schmitz

2020-04-09 20:50

administrator   ~57063

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=29822

lime_release_bot

lime_release_bot

2020-04-14 12:53

administrator   ~57111

Fixed in Release 4.1.17+200414

lterfloth

lterfloth

2020-04-14 13:45

reporter   ~57119

Hey there,

I tried reproducing the bug on your demo system ( https://demo.limesurvey.org/index.php?r=admin ) and it was successful. Steps to reproduce:

  1. create a new survey
  2. import the attached .lsg (in the bug report)
  3. go into one question-array of the group, you should see the entries in "Teilantworten" are blank
  4. change those entries to whatever you want
  5. hit save
  6. error-toast appears
lterfloth

lterfloth

2020-04-14 16:00

reporter   ~57120

Dove deeper:

I exported the .lsg again after applying the fix. Seems like it works now, on 4.1.4 and on 4.1.17 (demo server) as well. So the bugfix seems to be working flawlessly, sorry for reopening and BIG THANKS for the quick fix!

ollehar

ollehar

2020-04-14 16:02

administrator   ~57121

Fixed.

Related Changesets

LimeSurvey: master bd8dd6dd

2020-04-08 11:58:41

c_schmitz

Details Diff
Fixed issue 16115: .lsg group export does not export subquestion texts Affected Issues
16115
mod - application/helpers/export_helper.php Diff File

LimeSurvey: master edc0e38d

2020-04-09 20:47:48

c_schmitz

Details Diff
Fixed issue 16115: .lsg group export does not export subquestion texts Affected Issues
16115
mod - application/helpers/export_helper.php Diff File

Issue History

Date Modified Username Field Change
2020-04-08 10:50 lterfloth New Issue
2020-04-08 10:50 lterfloth File Added: limesurvey_group_443.lsg
2020-04-08 11:23 lterfloth Note Added: 57021
2020-04-08 11:31 lterfloth Note Added: 57022
2020-04-08 11:32 lterfloth Tag Attached: 4.1.4
2020-04-08 11:32 lterfloth Tag Attached: 4.1.16
2020-04-08 11:32 lterfloth Tag Attached: import
2020-04-08 11:32 ollehar Priority none => urgent
2020-04-08 11:32 ollehar Severity partial_block => crash
2020-04-08 11:34 ollehar Note Added: 57024
2020-04-08 11:36 cdorin Status new => confirmed
2020-04-08 11:38 cdorin Note Added: 57025
2020-04-08 11:38 cdorin Zoho Sprints => |Yes|
2020-04-08 11:38 swendrich Zoho Sprints ID => 14469000000031025
2020-04-08 11:41 c_schmitz Assigned To => c_schmitz
2020-04-08 11:41 c_schmitz Status confirmed => assigned
2020-04-08 11:58 c_schmitz Changeset attached => LimeSurvey master bd8dd6dd
2020-04-08 11:58 c_schmitz Note Added: 57026
2020-04-08 11:58 c_schmitz Resolution open => fixed
2020-04-08 12:00 c_schmitz Status assigned => feedback
2020-04-08 12:00 c_schmitz Note Added: 57027
2020-04-08 12:01 lterfloth Note Added: 57028
2020-04-08 12:01 lterfloth Status feedback => assigned
2020-04-08 12:02 lterfloth Note Added: 57029
2020-04-08 13:38 lterfloth File Added: Bildschirmfoto 2020-04-08 um 13.24.33.png
2020-04-08 13:38 lterfloth Note Added: 57031
2020-04-08 16:44 c_schmitz Note Added: 57032
2020-04-08 16:44 c_schmitz Status assigned => feedback
2020-04-09 11:08 lterfloth Note Added: 57040
2020-04-09 11:08 lterfloth Status feedback => assigned
2020-04-09 14:16 lterfloth File Added: export_helper.php
2020-04-09 14:16 lterfloth Note Added: 57053
2020-04-09 14:20 ollehar Note Added: 57054
2020-04-09 14:25 lterfloth Note Added: 57055
2020-04-09 15:43 cdorin Note Added: 57057
2020-04-09 15:44 cdorin Status assigned => confirmed
2020-04-09 15:44 cdorin Zoho Sprints Yes => |Yes|
2020-04-09 16:56 ollehar Note Added: 57059
2020-04-09 16:58 ollehar Note Edited: 57059
2020-04-09 20:01 c_schmitz Status confirmed => feedback
2020-04-09 20:01 c_schmitz Note Added: 57062
2020-04-09 20:01 c_schmitz Note Edited: 57062
2020-04-09 20:50 c_schmitz Changeset attached => LimeSurvey master edc0e38d
2020-04-09 20:50 c_schmitz Note Added: 57063
2020-04-14 12:53 lime_release_bot Zoho Sprints Yes => |Yes|
2020-04-14 12:53 lime_release_bot Note Added: 57111
2020-04-14 12:53 lime_release_bot Status feedback => closed
2020-04-14 13:42 ollehar Status closed => feedback
2020-04-14 13:42 ollehar Resolution fixed => reopened
2020-04-14 13:45 lterfloth Note Added: 57119
2020-04-14 13:45 lterfloth Status feedback => assigned
2020-04-14 16:00 lterfloth Note Added: 57120
2020-04-14 16:02 ollehar Status assigned => closed
2020-04-14 16:02 ollehar Note Added: 57121