View Issue Details

This bug affects 1 person(s).
 4
IDProjectCategoryView StatusLast Update
16009Feature requests_ Unknownpublic2022-04-28 17:23
Reporterollehar Assigned ToDenisChenu  
PrioritynoneSeverityfeature 
Status assignedResolutionopen 
Summary16009: Add column ignore_load_error to make plugins load even if there was an error
Description

Title.

TagsNo tags attached.
Bug heat4
Story point estimate
Users affected %

Relationships

related to 18062 confirmed Bug reports Plugin get deactivated after error 

Users monitoring this issue

There are no users monitoring this issue.

Activities

ollehar

ollehar

2020-03-19 17:05

administrator   ~56679

Read value from config.xml at install (activate)? Or static variable in plugin class? $ignoreLoadError = true.

DenisChenu

DenisChenu

2020-03-19 17:10

developer   ~56680

Last edited: 2020-03-19 17:10

Or config debug / debugplugin ?

DenisChenu

DenisChenu

2020-03-19 17:12

developer   ~56681

Oups .

Not same objective , sorry :)

Or static variable in plugin class?

Seem cool , maybe a public function or a public var in PluginBase class ?

DenisChenu

DenisChenu

2020-03-19 17:13

developer   ~56682

Last edited: 2020-03-19 17:14

If you're ok for a function : assing it to me.

For develop ?

Pro of function : a plugin can disable when debug is not set, but load when debug is 1. Or load only for specific user (for example : ForcedAdmin).

ollehar

ollehar

2020-03-20 12:26

administrator   ~56694

For develop, but shan't be merged before next merge window.

For function: Then add new function in PluginBase ingoreLoadError() { return false; }.

ollehar

ollehar

2020-03-20 12:26

administrator   ~56695

Also, the hard-coded "Authdb" should be removed, and instead Authdb should override the ignoreLoadError() function.

DenisChenu

DenisChenu

2020-03-20 12:35

developer   ~56697

Yep for the 2 part, what i think to do :)

Quick fix in fact :)

DenisChenu

DenisChenu

2020-03-20 15:26

developer   ~56706

Arg ... i'm silly ... you can not call a plugin function if plugin are not loaded ...

ollehar

ollehar

2020-03-20 15:27

administrator   ~56707

Hm. Syntax error in class file. :) Can't create object. You're right.

DenisChenu

DenisChenu

2020-03-20 15:32

developer   ~56708

Maybe

  1. By DB (new config.xml value, or when load
  2. A config array for forced plugins ?
DenisChenu

DenisChenu

2020-03-27 09:14

developer   ~56796

Last edited: 2020-04-07 17:32

@ollehar : thinking on another solution about a new column (came from config.xml when reload, like version number) to allow using too for debug

Something like state where there are (for staring) 4 possibility (maybe more after)

  • need : AuthDB only (maybe other) : never check (always loaded)
  • stable : basic : disable if there are error
  • dev: disable only if debug is not set
  • test : don't disable if forcedsuperadmin (and or debug set ?)

Issue History

Date Modified Username Field Change
2020-03-19 17:04 ollehar New Issue
2020-03-19 17:05 ollehar Note Added: 56679
2020-03-19 17:10 DenisChenu Note Added: 56680
2020-03-19 17:10 DenisChenu Note Edited: 56680
2020-03-19 17:12 DenisChenu Note Added: 56681
2020-03-19 17:13 DenisChenu Note Added: 56682
2020-03-19 17:14 DenisChenu Note Edited: 56682
2020-03-20 12:26 ollehar Note Added: 56694
2020-03-20 12:26 ollehar Note Added: 56695
2020-03-20 12:35 DenisChenu Assigned To => DenisChenu
2020-03-20 12:35 DenisChenu Status new => assigned
2020-03-20 12:35 DenisChenu Note Added: 56697
2020-03-20 15:26 DenisChenu Note Added: 56706
2020-03-20 15:27 ollehar Note Added: 56707
2020-03-20 15:32 DenisChenu Note Added: 56708
2020-03-27 09:14 DenisChenu Note Added: 56796
2020-03-27 09:14 DenisChenu Note Edited: 56796
2020-04-07 17:32 DenisChenu Note Edited: 56796
2022-04-28 17:23 DenisChenu Relationship added related to 18062