View Issue Details

IDProjectCategoryView StatusLast Update
15909Bug reportsPluginspublic2020-02-24 17:31
ReporterDenisChenu Assigned ToDenisChenu  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version4.1.6 
Fixed in Version4.1.6 
Summary15909: customToken delete settings by other plugin
Description

When deactivate customToken : it delete settings by another plugin

Steps To Reproduce

Import included plugin,
Update and set a value
Check it saved
Deactivate customToken plugin
Check value disappear

Additional Information

Need a prof for https://github.com/LimeSurvey/LimeSurvey/pull/1390

But : really move form HARD sql to PDO need proff ...

I merge it .

TagsNo tags attached.
Complete LimeSurvey version number (& build)4.1.6
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database & DB-Versionmariadb
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Activities

DenisChenu

DenisChenu

2020-02-24 15:00

developer  

dontDeleteMySettings.zip (26,147 bytes)
DenisChenu

DenisChenu

2020-02-24 15:01

developer   ~56168

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=29613

lime_release_bot

lime_release_bot

2020-02-24 17:31

administrator   ~56182

Fixed in Release 4.1.7+200224

Related Changesets

LimeSurvey: master 7cc80005

2020-02-24 15:01:17

DenisChenu


Committer: GitHub Details Diff
Fixed issue 15909: customToken delete settings by other plugin

Dev: broken SQL for PG or MS in customToken plugin (#1390)
Dev: and always better to use PDO with Yii
Dev: if elseif is really awfull. Usage of switch
Dev: Add translation system (check if it's OK , $this->gT must work)
Affected Issues
15909
mod - application/core/plugins/customToken/config.xml Diff File
mod - application/core/plugins/customToken/customToken.php Diff File

Issue History

Date Modified Username Field Change
2020-02-24 15:00 DenisChenu New Issue
2020-02-24 15:00 DenisChenu Status new => assigned
2020-02-24 15:00 DenisChenu Assigned To => DenisChenu
2020-02-24 15:00 DenisChenu File Added: dontDeleteMySettings.zip
2020-02-24 15:01 DenisChenu Changeset attached => LimeSurvey master 7cc80005
2020-02-24 15:01 DenisChenu Note Added: 56168
2020-02-24 15:01 DenisChenu Resolution open => fixed
2020-02-24 15:01 DenisChenu Status assigned => resolved
2020-02-24 15:01 DenisChenu Fixed in Version => 4.1.6
2020-02-24 17:31 lime_release_bot Note Added: 56182
2020-02-24 17:31 lime_release_bot Status resolved => closed