View Issue Details

Related ChangesetsJump to NotesJump to History
This issue affects 1 person(s).
 6
IDProjectCategoryView StatusDate SubmittedLast Update
15859Bug reportsImport/Exportpublic2020-02-13 08:182020-02-17 11:22
ReporterTonisOrmisson Assigned ToTonisOrmisson  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version4.1.2 
Target Version4.0.x 
Summary15859: Token can be truncated in SPSS export
Description

Token length is wrong. Or can be wrong in many cases. Token column in survey is set to 'string(36)'. Tokens can be imported or created via API in a longer format than set in the survey settings. So We are ending up truncated tokens in SPSS file. The survey->tokenlength should be also used while creating the token field in DB (and API/import length check) OR the SPSS should generate a field allowing max length that can come from DB (32).

TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build)Version 4.1.4
I will donate to the project if issue is resolvedNo
Browser
Database type & versionNA
Server OS (if known)
Webserver software & version (if known)
PHP VersionNA

Users monitoring this issue

There are no users monitoring this issue.

Activities

TonisOrmisson

TonisOrmisson

2020-02-13 08:22

developer   ~55932

https://github.com/LimeSurvey/LimeSurvey/pull/1387
TonisOrmisson

TonisOrmisson

2020-02-13 09:03

developer   ~55933

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=29557
ollehar

ollehar

2020-02-13 11:53

administrator   ~55941

Thanks!
lime_release_bot

lime_release_bot

2020-02-17 11:22

administrator   ~56048

Fixed in Release 4.1.5+200217

Related Changesets

LimeSurvey: master 03840d34

2020-02-13 10:03

TonisOrmisson

Committer: GitHub


Details Diff		 Fixed issue 15859: Token can be truncated in SPSS export (#1387) Affected Issues
15859
mod - application/helpers/admin/activate_helper.php Diff File
mod - application/helpers/export_helper.php Diff File
mod - application/models/SurveyActivator.php Diff File
mod - application/models/Token.php Diff File

Issue History

Date Modified Username Field Change
2020-02-13 08:18 TonisOrmisson New Issue
2020-02-13 08:18 TonisOrmisson Status new => assigned
2020-02-13 08:18 TonisOrmisson Assigned To => TonisOrmisson
2020-02-13 08:22 TonisOrmisson Status assigned => ready for code review
2020-02-13 08:22 TonisOrmisson Note Added: 55932
2020-02-13 09:03 TonisOrmisson Changeset attached => LimeSurvey master 03840d34
2020-02-13 09:03 TonisOrmisson Note Added: 55933
2020-02-13 09:03 TonisOrmisson Resolution open => fixed
2020-02-13 11:53 ollehar Status ready for code review => resolved
2020-02-13 11:53 ollehar Note Added: 55941
2020-02-17 11:22 lime_release_bot Note Added: 56048
2020-02-17 11:22 lime_release_bot Status resolved => closed