Is the same survey working fine in LS3?

Another weird thing is the "empty" question in the failing group. See screenshot.

Selection_992.png (53,205 bytes)   

Selection_992.png (53,205 bytes)   

No, nevermind, that bug is in every group.

Hm, since the survey was created in LS4, it cannot be imported in LS3.

I haven't tested it myself, but fwiw the user that created the survey reported it was working fine before the upgrade. I don't have that LS3 instance anymore. I might be able to dig up a database backup from before the update and see what I can test.

@ollehar : maybe try to export as txt/tsv ?
And check if you have the issue in 4.X with the TSV ?

Then : we can check if it's a logic issue …

Unfortunately I don't have a backup anymore of the LS3 db, so I can't provide the LS3 export

I did some digging, and it seems to me that the bug is located here:
https://github.com/LimeSurvey/LimeSurvey/blob/4.1.0+200128/application/helpers/frontend_helper.php#L1597

Changing

$result = QuestionGroup::model()->findAllByAttributes(['sid'=>$surveyid]);

to

$result = QuestionGroup::model()->findAllByAttributes(['sid'=>$surveyid], ['order' => 'group_order ASC']);

Seems to fix it for me. I don't know what kind of repercussions this might have, so it needs to be verified, but it at least seems to fix this particular issue. Could you guys please confirm? :)

I went ahead and created a PR.

Thanks : +1 for your PR :)

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=29517

Fixed in Release 4.1.2+200210