 |
|
 |
This option happens in multiple places (e.g., create a survey , start the qcode with a number, click save -> same error) |
|
|
I confirm issue for 4.0.0 : same action . I don't understand why this happen : this javascript is too complex for me… Capture d’écran du 2020-01-15 17-47-26.png (63,077 bytes) |
|
|
> start the qcode with a number I think i already reported this one … less important : we have Save and add new ;) |
|
|
Yea, will have to talk to |
|
|
An issue is here : https://github.com/LimeSurvey/LimeSurvey/blob/4f18b7a1cd3a14347693968129ceea9ef4d71ec0/assets/packages/adminbasics/src/parts/save.js#L97 (maybe) : this check only required value. Most complete : `$form[0].checkValidity();` or `$form.checkValidity();` |
 |
After the VueJS withdraw, this seems to got fixed. Numeric field is type numeric now, so no letters allowed. Mail is validated on the server side. I can't reproduce issue anymore, not here nor in LS4 |
|
|
Still have the issue in 3.25.20 1. Go to token 2. Add a single token 3. Enter "ddd" in use left 4. Click on Save 5. OK : can not submit (HTML5 validation) 6. Correct the use left 7. Can not click on save : it was disable … |
|
|
(OK in 4.X: save in not disabled) |
|
|
> Numeric field is type numeric now, so no letters allowed. You can enter something else, but can not submit The issue is to disable action on submit button on click and not on submit … |
|
|
The issue is as follows: - Firefox has a different interpretation on what to do with non numeric values. - It does allow to enter them, but not to submit them - Due to"general LS standards for handling forms" - After top bar save button is clicked, + The form submit button is clicked + The topbar save button is added the spinning wheel and disabled. - After trying to submit, the form is invalidated. But the button still has the spining wheel and is not restablished. Suggested approach short term: - Add invalid handler on the form --> Will do this. Suggested approach long temr: - Open new ticket to only trigger form submit if form is valid using reportValidity. This has a general impact on many forms. This is not IE compatible. https://developer.mozilla.org/en-US/docs/Web/API/HTMLFormElement/reportValidity - We should do this as spinning wheel works for "add new survey"forms only. - Alternative approach enable custom form validations through form attributes which are checked during topbar save button. |
|
|
Yes : https://bugs.limesurvey.org/view.php?id=15712#c60375 > Most complete : `$form[0].checkValidity();` or `$form.checkValidity();` |
|
|
PR: https://github.com/LimeSurvey/LimeSurvey/pull/1839 Added ability to trigger html5 internal form validation from form attribute ("data-trigger-validation") Some browsers don't show html5 internal validation errors by default. Eventually, this triggering that would be std for all LS forms. But for now, and make a smaller impact, we are tigerring this on a case by case basis. Also, using the invalid event (https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement/invalid_event) to restore the save button to its original state after being clicked and an error found. |
|
|
Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=31560 |
 |
Release done. |
- Anonymous
