View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 15566 | Bug reports | Theme editor | public | 2019-11-14 19:18 | 2019-11-18 13:53 |
| Reporter | DenisChenu | Assigned To | DenisChenu | ||
| Priority | none | Severity | minor | ||
| Status | closed | Resolution | fixed | ||
| Product Version | 3.20.x | ||||
| Fixed in Version | 3.20.x | ||||
| Summary | 15566: Potential PHP Notice with some theme | ||||
| Description | When theme didn't have ajaxmode, when extend it, option can not be updated if debug > 1 | ||||
| Steps To Reproduce | Import (SkelVanilla)[https://extensions.sondages.pro/themes-and-templates/skelvanilla-a11y-and-usuability/], extend | ||||
| Additional Information | I'm not sure what happen with core theme, but think it same since they don't have ajaxmode now. | ||||
| Tags | No tags attached. | ||||
| Attached Files | PHP notice.html (18,665 bytes)
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en"><head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<title>PHP notice</title>
<style type="text/css">
/*<![CDATA[*/
html,body,div,span,applet,object,iframe,h1,h2,h3,h4,h5,h6,p,blockquote,pre,a,abbr,acronym,address,big,cite,code,del,dfn,em,font,img,ins,kbd,q,s,samp,small,strike,strong,sub,sup,tt,var,b,u,i,center,dl,dt,dd,ol,ul,li,fieldset,form,label,legend,table,caption,tbody,tfoot,thead,tr,th,td{border:0;outline:0;font-size:100%;vertical-align:baseline;background:transparent;margin:0;padding:0;}
body{line-height:1;}
ol,ul{list-style:none;}
blockquote,q{quotes:none;}
blockquote:before,blockquote:after,q:before,q:after{content:none;}
:focus{outline:0;}
ins{text-decoration:none;}
del{text-decoration:line-through;}
table{border-collapse:collapse;border-spacing:0;}
body {
font: normal 9pt "Verdana";
color: #000;
background: #fff;
}
h1 {
font: normal 18pt "Verdana";
color: #f00;
margin-bottom: .5em;
}
h2 {
font: normal 14pt "Verdana";
color: #800000;
margin-bottom: .5em;
}
h3 {
font: bold 11pt "Verdana";
}
pre {
font: normal 11pt Menlo, Consolas, "Lucida Console", Monospace;
}
pre span.error {
display: block;
background: #fce3e3;
}
pre span.ln {
color: #999;
padding-right: 0.5em;
border-right: 1px solid #ccc;
}
pre span.error-ln {
font-weight: bold;
}
.container {
margin: 1em 4em;
}
.version {
color: gray;
font-size: 8pt;
border-top: 1px solid #aaa;
padding-top: 1em;
margin-bottom: 1em;
}
.message {
color: #000;
padding: 1em;
font-size: 11pt;
background: #f3f3f3;
-webkit-border-radius: 10px;
-moz-border-radius: 10px;
border-radius: 10px;
margin-bottom: 1em;
line-height: 160%;
}
.source {
margin-bottom: 1em;
}
.code pre {
background-color: #ffe;
margin: 0.5em 0;
padding: 0.5em;
line-height: 125%;
border: 1px solid #eee;
}
.source .file {
margin-bottom: 1em;
font-weight: bold;
}
.traces {
margin: 2em 0;
}
.trace {
margin: 0.5em 0;
padding: 0.5em;
}
.trace.app {
border: 1px dashed #c00;
}
.trace .number {
text-align: right;
width: 2em;
padding: 0.5em;
}
.trace .content {
padding: 0.5em;
}
.trace .plus,
.trace .minus {
display:inline;
vertical-align:middle;
text-align:center;
border:1px solid #000;
color:#000;
font-size:10px;
line-height:10px;
margin:0;
padding:0 1px;
width:10px;
height:10px;
}
.trace.collapsed .minus,
.trace.expanded .plus,
.trace.collapsed pre {
display: none;
}
.trace-file {
cursor: pointer;
padding: 0.2em;
}
.trace-file:hover {
background: #f0ffff;
}
/*]]>*/
</style>
</head>
<body>
<div class="container">
<h1>PHP notice</h1>
<p class="message">
Undefined index: ajaxmode </p>
<div class="source">
<p class="file">/mnt/data/shnoulle/nginx/www/master/application/controllers/admin/themeoptions.php(117)</p>
<div class="code"><pre><span class="ln">105</span> * @return TemplateConfiguration
<span class="ln">106</span> */
<span class="ln">107</span> public function turnAjaxmodeOffAsDefault(TemplateConfiguration $templateConfiguration)
<span class="ln">108</span> {
<span class="ln">109</span> $attributes = $templateConfiguration->getAttributes();
<span class="ln">110</span> $hasOptions = isset($attributes['options']);
<span class="ln">111</span> if ($hasOptions) {
<span class="ln">112</span> $options = $attributes['options'];
<span class="ln">113</span> $optionsJSON = json_decode($options, true);
<span class="ln">114</span>
<span class="ln">115</span> if ($options !== 'inherit' && $optionsJSON !== null) {
<span class="ln">116</span> $hasAjaxMode = isset($optionsJSON['ajaxmode']);
<span class="error"><span class="ln error-ln">117</span> $ajaxModeOn = ($optionsJSON['ajaxmode'] == 'on');
</span><span class="ln">118</span>
<span class="ln">119</span> if ($hasAjaxMode && $ajaxModeOn) {
<span class="ln">120</span> $optionsJSON['ajaxmode'] = 'off';
<span class="ln">121</span> $options = json_encode($optionsJSON);
<span class="ln">122</span> $templateConfiguration->setAttribute('options', $options);
<span class="ln">123</span> }
<span class="ln">124</span> }
<span class="ln">125</span> }
<span class="ln">126</span> return $templateConfiguration;
<span class="ln">127</span> }
<span class="ln">128</span> /**
<span class="ln">129</span> * Updates a particular model.
</pre></div> </div>
<div class="traces">
<h2>Stack Trace</h2>
<table style="width:100%;">
<tbody><tr class="trace app expanded">
<td class="number">
#0 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/mnt/data/shnoulle/nginx/www/master/application/controllers/admin/themeoptions.php(84): <strong>themeoptions</strong>-><strong>turnAjaxmodeOffAsDefault</strong>(TemplateConfiguration) </div>
<div class="code"><pre><span class="ln">79</span> public function update($id)
<span class="ln">80</span> {
<span class="ln">81</span> $model = $this->loadModel($id);
<span class="ln">82</span> if (Permission::model()->hasTemplatePermission($model->template_name, 'update')) {
<span class="ln">83</span> // Turn Ajax off as defualt save it after.
<span class="error"><span class="ln error-ln">84</span> $model = $this->turnAjaxmodeOffAsDefault($model);
</span><span class="ln">85</span> $model->save();
<span class="ln">86</span>
<span class="ln">87</span> if (isset($_POST['TemplateConfiguration'])) {
<span class="ln">88</span> $model->attributes = $_POST['TemplateConfiguration'];
<span class="ln">89</span> if ($model->save()) {
</pre></div> </td>
</tr>
<tr class="trace core collapsed">
<td class="number">
#1 </td>
<td class="content">
<div class="trace-file">
unknown(0): <strong>themeoptions</strong>-><strong>update</strong>("2796") </div>
</td>
</tr>
<tr class="trace core collapsed">
<td class="number">
#2 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/mnt/data/shnoulle/nginx/www/master/framework/web/actions/CAction.php(109): <strong>ReflectionMethod</strong>-><strong>invokeArgs</strong>(themeoptions, array("2796")) </div>
<div class="code"><pre><span class="ln">104</span> elseif($param->isDefaultValueAvailable())
<span class="ln">105</span> $ps[]=$param->getDefaultValue();
<span class="ln">106</span> else
<span class="ln">107</span> return false;
<span class="ln">108</span> }
<span class="error"><span class="ln error-ln">109</span> $method->invokeArgs($object,$ps);
</span><span class="ln">110</span> return true;
<span class="ln">111</span> }
<span class="ln">112</span> }
</pre></div> </td>
</tr>
<tr class="trace app expanded">
<td class="number">
#3 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/mnt/data/shnoulle/nginx/www/master/application/core/Survey_Common_Action.php(83): <strong>CAction</strong>-><strong>runWithParamsInternal</strong>(themeoptions, ReflectionMethod, array("id" => "2796", "sa" => "update", "iId" => "2796")) </div>
<div class="code"><pre><span class="ln">78</span> $oMethod = new ReflectionMethod($this, $sDefault);
<span class="ln">79</span> }
<span class="ln">80</span>
<span class="ln">81</span> // We're all good to go, let's execute it
<span class="ln">82</span> // runWithParamsInternal would automatically get the parameters of the method and populate them as required with the params
<span class="error"><span class="ln error-ln">83</span> return parent::runWithParamsInternal($this, $oMethod, $params);
</span><span class="ln">84</span> }
<span class="ln">85</span>
<span class="ln">86</span> /**
<span class="ln">87</span> * Some functions have different parameters, which are just an alias of the
<span class="ln">88</span> * usual parameters we're getting in the url. This function just populates
</pre></div> </td>
</tr>
<tr class="trace core collapsed">
<td class="number">
#4 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/mnt/data/shnoulle/nginx/www/master/framework/web/CController.php(308): <strong>Survey_Common_Action</strong>-><strong>runWithParams</strong>(array("id" => "2796", "sa" => "update", "iId" => "2796")) </div>
<div class="code"><pre><span class="ln">303</span> {
<span class="ln">304</span> $priorAction=$this->_action;
<span class="ln">305</span> $this->_action=$action;
<span class="ln">306</span> if($this->beforeAction($action))
<span class="ln">307</span> {
<span class="error"><span class="ln error-ln">308</span> if($action->runWithParams($this->getActionParams())===false)
</span><span class="ln">309</span> $this->invalidActionParams($action);
<span class="ln">310</span> else
<span class="ln">311</span> $this->afterAction($action);
<span class="ln">312</span> }
<span class="ln">313</span> $this->_action=$priorAction;
</pre></div> </td>
</tr>
<tr class="trace core collapsed">
<td class="number">
#5 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/mnt/data/shnoulle/nginx/www/master/framework/web/CController.php(286): <strong>CController</strong>-><strong>runAction</strong>(themeoptions) </div>
<div class="code"><pre><span class="ln">281</span> * @see runAction
<span class="ln">282</span> */
<span class="ln">283</span> public function runActionWithFilters($action,$filters)
<span class="ln">284</span> {
<span class="ln">285</span> if(empty($filters))
<span class="error"><span class="ln error-ln">286</span> $this->runAction($action);
</span><span class="ln">287</span> else
<span class="ln">288</span> {
<span class="ln">289</span> $priorAction=$this->_action;
<span class="ln">290</span> $this->_action=$action;
<span class="ln">291</span> CFilterChain::create($this,$action,$filters)->run();
</pre></div> </td>
</tr>
<tr class="trace core collapsed">
<td class="number">
#6 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/mnt/data/shnoulle/nginx/www/master/framework/web/CController.php(265): <strong>CController</strong>-><strong>runActionWithFilters</strong>(themeoptions, array()) </div>
<div class="code"><pre><span class="ln">260</span> {
<span class="ln">261</span> if(($parent=$this->getModule())===null)
<span class="ln">262</span> $parent=Yii::app();
<span class="ln">263</span> if($parent->beforeControllerAction($this,$action))
<span class="ln">264</span> {
<span class="error"><span class="ln error-ln">265</span> $this->runActionWithFilters($action,$this->filters());
</span><span class="ln">266</span> $parent->afterControllerAction($this,$action);
<span class="ln">267</span> }
<span class="ln">268</span> }
<span class="ln">269</span> else
<span class="ln">270</span> $this->missingAction($actionID);
</pre></div> </td>
</tr>
<tr class="trace app expanded">
<td class="number">
#7 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/mnt/data/shnoulle/nginx/www/master/application/controllers/AdminController.php(158): <strong>CController</strong>-><strong>run</strong>("themeoptions") </div>
<div class="code"><pre><span class="ln">153</span> $this->redirect(array('/admin/authentication/sa/login'));
<span class="ln">154</span> }
<span class="ln">155</span> }
<span class="ln">156</span> }
<span class="ln">157</span>
<span class="error"><span class="ln error-ln">158</span> return parent::run($action);
</span><span class="ln">159</span> }
<span class="ln">160</span>
<span class="ln">161</span> /**
<span class="ln">162</span> * Routes all the actions to their respective places
<span class="ln">163</span> *
</pre></div> </td>
</tr>
<tr class="trace core collapsed">
<td class="number">
#8 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/mnt/data/shnoulle/nginx/www/master/framework/web/CWebApplication.php(282): <strong>AdminController</strong>-><strong>run</strong>("themeoptions") </div>
<div class="code"><pre><span class="ln">277</span> {
<span class="ln">278</span> list($controller,$actionID)=$ca;
<span class="ln">279</span> $oldController=$this->_controller;
<span class="ln">280</span> $this->_controller=$controller;
<span class="ln">281</span> $controller->init();
<span class="error"><span class="ln error-ln">282</span> $controller->run($actionID);
</span><span class="ln">283</span> $this->_controller=$oldController;
<span class="ln">284</span> }
<span class="ln">285</span> else
<span class="ln">286</span> throw new CHttpException(404,Yii::t('yii','Unable to resolve the request "{route}".',
<span class="ln">287</span> array('{route}'=>$route===''?$this->defaultController:$route)));
</pre></div> </td>
</tr>
<tr class="trace core collapsed">
<td class="number">
#9 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/mnt/data/shnoulle/nginx/www/master/framework/web/CWebApplication.php(141): <strong>CWebApplication</strong>-><strong>runController</strong>("admin/themeoptions/sa/update") </div>
<div class="code"><pre><span class="ln">136</span> foreach(array_splice($this->catchAllRequest,1) as $name=>$value)
<span class="ln">137</span> $_GET[$name]=$value;
<span class="ln">138</span> }
<span class="ln">139</span> else
<span class="ln">140</span> $route=$this->getUrlManager()->parseUrl($this->getRequest());
<span class="error"><span class="ln error-ln">141</span> $this->runController($route);
</span><span class="ln">142</span> }
<span class="ln">143</span>
<span class="ln">144</span> /**
<span class="ln">145</span> * Registers the core application components.
<span class="ln">146</span> * This method overrides the parent implementation by registering additional core components.
</pre></div> </td>
</tr>
<tr class="trace core collapsed">
<td class="number">
#10 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/mnt/data/shnoulle/nginx/www/master/framework/base/CApplication.php(185): <strong>CWebApplication</strong>-><strong>processRequest</strong>() </div>
<div class="code"><pre><span class="ln">180</span> public function run()
<span class="ln">181</span> {
<span class="ln">182</span> if($this->hasEventHandler('onBeginRequest'))
<span class="ln">183</span> $this->onBeginRequest(new CEvent($this));
<span class="ln">184</span> register_shutdown_function(array($this,'end'),0,false);
<span class="error"><span class="ln error-ln">185</span> $this->processRequest();
</span><span class="ln">186</span> if($this->hasEventHandler('onEndRequest'))
<span class="ln">187</span> $this->onEndRequest(new CEvent($this));
<span class="ln">188</span> }
<span class="ln">189</span>
<span class="ln">190</span> /**
</pre></div> </td>
</tr>
<tr class="trace app collapsed">
<td class="number">
#11 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/mnt/data/shnoulle/nginx/www/master/index.php(194): <strong>CApplication</strong>-><strong>run</strong>() </div>
<div class="code"><pre><span class="ln">189</span> require_once APPPATH . 'core/LSYii_Application' . EXT;
<span class="ln">190</span>
<span class="ln">191</span> $config = require_once(APPPATH . 'config/internal' . EXT);
<span class="ln">192</span>
<span class="ln">193</span> Yii::$enableIncludePath = false;
<span class="error"><span class="ln error-ln">194</span> Yii::createApplication('LSYii_Application', $config)->run();
</span><span class="ln">195</span>
<span class="ln">196</span> /* End of file index.php */
<span class="ln">197</span> /* Location: ./index.php */
</pre></div> </td>
</tr>
</tbody></table>
</div>
<div class="version">
2019-11-14 18:15:21 nginx/1.16.1 <a href="http://www.yiiframework.com/">Yii Framework</a>/1.1.21 </div>
</div>
<script type="text/javascript">
/*<![CDATA[*/
var traceReg = new RegExp("(^|\\s)trace-file(\\s|$)");
var collapsedReg = new RegExp("(^|\\s)collapsed(\\s|$)");
var e = document.getElementsByTagName("div");
for(var j=0,len=e.length;j<len;j++){
if(traceReg.test(e[j].className)){
e[j].onclick = function(){
var trace = this.parentNode.parentNode;
if(collapsedReg.test(trace.className))
trace.className = trace.className.replace("collapsed", "expanded");
else
trace.className = trace.className.replace("expanded", "collapsed");
}
}
}
/*]]>*/
</script>
</body></html> | ||||
| Bug heat | 4 | ||||
| Complete LimeSurvey version number (& build) | 3.20.0 | ||||
| I will donate to the project if issue is resolved | No | ||||
| Browser | not relevant | ||||
| Database type & version | not relevant | ||||
| Server OS (if known) | not relevant | ||||
| Webserver software & version (if known) | not relevant | ||||
| PHP Version | not relevant | ||||
 |
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=29254 |
 |
Fixed in Release 4.0.0-RC8+191118 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2019-11-14 19:18 | DenisChenu | New Issue | |
| 2019-11-14 19:18 | DenisChenu | File Added: PHP notice.html | |
| 2019-11-14 19:18 | DenisChenu | Assigned To | => DenisChenu |
| 2019-11-14 19:18 | DenisChenu | Status | new => assigned |
| 2019-11-14 19:23 | DenisChenu | Changeset attached | => LimeSurvey master df09a505 |
| 2019-11-14 19:23 | DenisChenu | Note Added: 54593 | |
| 2019-11-14 19:23 | DenisChenu | Resolution | open => fixed |
| 2019-11-14 19:24 | DenisChenu | Status | assigned => resolved |
| 2019-11-14 19:24 | DenisChenu | Fixed in Version | => 3.20.x |
| 2019-11-18 13:53 | lime_release_bot | Note Added: 54644 | |
| 2019-11-18 13:53 | lime_release_bot | Status | resolved => closed |
