"2" > "18" is not really different (bvecause you can 't have it in JS)

With Q00 as single choice with number Q00 as 5 : Q00 < "10" is different in PHP and JS …
Seems i made an error in https://github.com/LimeSurvey/LimeSurvey/blob/93455a7c64c78793375acb4e2eed6963c6cc6334/application/helpers/expressions/em_core_helper.php#L327

Maybe must be STRING for both ?

'A2' > 'A18' : no issue in my point of view (no diff in JS and PHP) … but send a warning is better.

@ollehar : in my opinion : must separate the issue

1. PHP vs JS compare must be equal ( Q00 < "18") : 1st issue
2. intuition/ default answer code

PS : since 2.05 : my advice when compare number is always do intval(Q00) before ;)

But we agree: Warning (or error) when doing "18", e.g. [0-9]* in quote?

Yes : my opinion :

1. We must fix JS vs PHP (or if not able to fix : send an error) for Q00 < "18"
2. Send a warning about usage of "[0-9]" and "" (adding "" to force string) and '[0-9]' and ''

The A2 > A10 is another issue :)

Related: Lots of people (except Denis) agree answer codes should be numeric as default, not alphanumeric.

My real opinion : empty default answer code (for the 1st)
If have number : seond can be number +1

Same for subquestion code
Same for question code

:D

@ollehar : can we list the real part wher it's broken : i mean compare is different between PHP and JS ?

"2" > "18" is different in PHP and JS.

But : did you have a Survey for this.

I know it's different, but since we have an hacked compare with PHP : maybe we can try to dix it .
No ?

I think i do an error :
If both can be number AND and are string : sometimes it‘s OK sometimes not.

For example (in JS)

1. Q00 < "18" => compare as number ( WORD vs FORCED STRING)
2. Q00 + "" < "18" => compare as string ( FORCED STRING vs FORCED STRING)

Please, don't try to hack EM more - it's already too complex. The best solution is a warning message, IMO.

Not for this part : since code are already updated since some year now …
https://github.com/LimeSurvey/LimeSurvey/blob/033b995ee5698109120694479a391b3e2ec59ad5/application/helpers/expressions/em_core_helper.php#L353-L362

The fix can be use && here : https://github.com/LimeSurvey/LimeSurvey/blob/033b995ee5698109120694479a391b3e2ec59ad5/application/helpers/expressions/em_core_helper.php#L328

Again, I disagree. Writing < "18" is always a conceptual error from the users side.

Yes, it can be. But the biggest issue : JS must be same than PHP.

Since it's hard ( impossible ?) to fix 2 < '18' and '2' < '18' in JS :

1. PHP must have the same behaviour :)
2. A warning must be shown on admin part each time a user have "[0-9 ]" or '[0-9 ]' inside equation :)

1. Don't know how to fix
2. Yes, for this BUT also for answer codes BECAUSE "A2" < "A18", so still unintuitive behvaiour. Question is: What is users intention? Anyway, let's discuss next team meeting? With Carsten.