View Issue Details

IDProjectCategoryView StatusLast Update
15004Bug reports[All Projects] Survey participants (Tokens)public2019-06-28 12:27
ReportereventlyAssigned ToDenisChenu 
PrioritynoneSeverityminor 
Status resolvedResolutionfixed 
Product Version3.17.x 
Target VersionFixed in Version3.17.x 
Summary15004: Attribute fields on registration form have incorrect ID
Description

All additional attributes on the public registration form have an ID of "register_{$key}", due the following line in the vanilla theme: (Both on 3.17 as in the 4.*;

File: views/subviews/registration/register_form.twig, line 58

{{ C.Html.textField(registerKey, aSurveyInfo.aAttribute[key],({'id' : "register_{$key}",'class' : 'form-control input-sm'})) }}

but should be:

{{ C.Html.textField(registerKey, aAttribute[key],({'id' : registerKey,'class' : 'form-control input-sm'})) }}

I will create a pull request to fix this later today.

Steps To Reproduce

Create a new survey, use vanilla theme or any extended theme based on vanilla, add additional attributes for the tokens and allow public registration. On the registration form all additional attributes will have the string "register_{$key}" as ID.

TagsNo tags attached.
Complete LimeSurvey version number (& build)Version 3.17.6+190624, and v4.*
I will donate to the project if issue is resolvedNo
Browser
Database & DB-Version190624?
Server OS (if known)
Webserver software & version (if known)
PHP Version7.0, 7.2

Related Changesets

LimeSurvey: master 1f565ce8

2019-06-25 16:02:24

evently


Committer: DenisChenu Details Diff
Fixed issue 15004 show correct id attribute for additional attributes Affected Issues
15004
mod - themes/survey/vanilla/views/subviews/registration/register_form.twig Diff File

Issue History

Date Modified Username Field Change
2019-06-25 14:15 evently New Issue
2019-06-25 15:28 evently Note Added: 52545
2019-06-25 16:03 DenisChenu Status new => resolved
2019-06-25 16:03 DenisChenu Resolution open => fixed
2019-06-25 16:03 DenisChenu Fixed in Version => 3.17.x
2019-06-25 16:03 DenisChenu Note Added: 52547
2019-06-28 12:27 DenisChenu Changeset attached => LimeSurvey master 1f565ce8
2019-06-28 12:27 DenisChenu Note Added: 52622
2019-06-28 12:27 DenisChenu Assigned To => DenisChenu