14998: Usage of self.NAOK insique all question part are broken

This issue affects 1 person(s).

ID	Project	Category	View Status	Date Submitted	Last Update
14998	Bug reports	Survey taking	public	2019-06-21 14:09	2020-03-09 15:36

Reporter	DenisChenu	Assigned To	DenisChenu
Priority	none	Severity	partial_block
Status	closed	Resolution	fixed
Product Version	3.17.x
Fixed in Version	3.17.x

Summary	14998: Usage of self.NAOK insique all question part are broken
Description	self.NAOK return the 1st value in page
Steps To Reproduce	Import included survey Check logic of Q01 : see Q01 Check logic of survey : see Q00 everywhere Launch survey : all {self.NAOK} use {Q00.NAOK}
Additional Information	3.17.4+190529 broken 3.17.3+190429 OK
Tags	No tags attached.
Attached Files	Capture d’écran du 2019-06-21 14-04-58.png (19,344 bytes) Capture d’écran du 2019-06-21 14-04-58.png (19,344 bytes) limesurvey_survey_selfBroken.lss (20,416 bytes)

Bug heat	4
Complete LimeSurvey version number (& build)	3.17.5 github & 3.17.4
I will donate to the project if issue is resolved	No
Browser	ff
Database type & version	mariadb
Server OS (if known)	fedora/linux
Webserver software & version (if known)	nginx
PHP Version	PHP7

User List	There are no users monitoring this issue.

DenisChenu 2019-06-21 14:19 developer ~52488 Last edited: 2019-06-21 14:19	@ollehar Dev: Memoize result from ExpandThisVar (not 100% sure this is a bottleneck) is the issue must be disabled for self and this at minima … https://github.com/LimeSurvey/LimeSurvey/commit/445313913cbfec6addc85618108e728a13f81794

DenisChenu 2019-06-21 14:23 developer ~52489	Must be disable if HAVE self or this `((sum(!(!is_empty(self.NAOK))) == 0)) and ((sum(!(!is_empty(self.NAOK))) == 0))` goes into cache

DenisChenu 2019-06-21 23:14 developer ~52491	https://github.com/LimeSurvey/LimeSurvey/commit/7a0112999b2dff5a54e51e0c28ac562ef3992150

DenisChenu 2019-06-28 12:27 developer ~52624	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=29007

ollehar 2019-07-01 10:15 administrator ~52646	Thanks, Denis! Very good catch.

ollehar 2019-07-01 10:16 administrator ~52647	I can make a regression test for this bug.

DenisChenu 2019-07-01 10:57 developer ~52648	I have this one : https://bugs.limesurvey.org/view.php?id=14995 to do too (relevance on preview).

ollehar 2019-07-01 11:04 administrator ~52649	Group preview? Hm.

DenisChenu 2019-07-01 12:07 developer ~52653	Question preview too (for subquestion and prefilling via URL)

Date Modified	Username	Field	Change
2019-06-21 14:09	DenisChenu	New Issue
2019-06-21 14:09	DenisChenu	Status	new => assigned
2019-06-21 14:09	DenisChenu	Assigned To	=> DenisChenu
2019-06-21 14:09	DenisChenu	File Added: Capture d’écran du 2019-06-21 14-04-58.png
2019-06-21 14:09	DenisChenu	File Added: limesurvey_survey_selfBroken.lss
2019-06-21 14:19	DenisChenu	Note Added: 52488
2019-06-21 14:19	DenisChenu	Note Edited: 52488
2019-06-21 14:23	DenisChenu	Note Added: 52489
2019-06-21 23:14	DenisChenu	Status	assigned => resolved
2019-06-21 23:14	DenisChenu	Resolution	open => fixed
2019-06-21 23:14	DenisChenu	Fixed in Version	=> 3.17.x
2019-06-21 23:14	DenisChenu	Note Added: 52491
2019-06-28 12:27	DenisChenu	Changeset attached	=> LimeSurvey master 7a011299
2019-06-28 12:27	DenisChenu	Note Added: 52624
2019-07-01 10:15	ollehar	Note Added: 52646
2019-07-01 10:16	ollehar	Note Added: 52647
2019-07-01 10:57	DenisChenu	Note Added: 52648
2019-07-01 11:04	ollehar	Note Added: 52649
2019-07-01 12:07	DenisChenu	Note Added: 52653
2020-03-09 15:36	c_schmitz	Status	resolved => closed

LimeSurvey: master 7a011299 2019-06-21 16:28 DenisChenu Details Diff	Fixed issue 14998: Usage of self.NAOK insique all question part are broken Dev: this disable static cache if self or this are in string		Affected Issues 14998
	mod - application/helpers/expressions/em_core_helper.php		Diff File