View Issue Details

IDProjectCategoryView StatusLast Update
14839Feature requests[All Projects] Otherpublic2019-05-07 16:56
ReporterDenisChenu Assigned ToDenisChenu  
PrioritynoneSeverityfeature 
Status assignedResolutionopen 
Product Version 
Target Version4.0.0devFixed in Version 
Summary14839: Allow to update export file base name
Description

When export survey or question or group : it was exported as limesurvey_survey, limesurvey_group or limesurvey_question
A client of mine want to offer a complete solution to a client of him but with removing LimeSurvey part.

Easy in admin theme + some JS

But not for export

Additional Information

An idea :

$config['toolname'] = 'LimeSurvey' and using this (with strtolower or not) hen needed.

It's easy

TagsNo tags attached.

Activities

DenisChenu

DenisChenu

2019-05-02 16:42

developer   ~51739

@c_schmitz : i make a fork for this client , but are you OK for such feature in 4.X ?

c_schmitz

c_schmitz

2019-05-02 16:50

administrator   ~51740

Sure, fine for me. But maybe a bit more generic, like 'download_base_name'

DenisChenu

DenisChenu

2019-05-02 17:14

developer   ~51743

Last edited: 2019-05-02 17:20

View 4 revisions

i think too of some other part :

  1. Tutorial «Welcome on %ToolName»
  2. System Information : «LimeSurvey version» , but this one is only for super-admin, then less needed, maybe keep it.
  3. About Link : support and donate ? I replace/replace it in fork but , OK too ? (else : JS is OK for me)

Then in config-default:

$config['toolname'] = 'LimeSurvey';
$config['download_base_name'] = strtolower($config['toolname']);
$config['manual_url'] = 'https://manual.limesurvey.org/';
$config['donate_link'] = true; // Just show or hide
$config['home_url'] = 'https://www.limesurvey.org/';

And maybe $config['donate_link'] is forced to true for forced super admin ;)

PS : maybe some can be moved to admin theme

<config>
    <metadata>
        <name>PersonalTheme</name>
        <presentation>A adpated tool for surveys</presentation>
        <manual_url>A adpated tool for surveys</manual_url>
    </metadata>
<config>

Like you prefer :)

dominikvitt

dominikvitt

2019-05-07 15:12

developer   ~51795

@DenisChenu: Are you interested to make PR in develop branch?
At least for export filename to start with.

DenisChenu

DenisChenu

2019-05-07 15:34

developer   ~51798

Yes, it's what i ask : are you OK for a PR . And if yes, with what inside.

Currently :

  1. filename_kkk.lss : can not be done without hard workaround (must replace all action)
  2. Limesurvey logo and icon : OK in admin template, can be done in user template
  3. Limesurvey string in Tutorial : ? Must disable tutorial in DB
  4. Limesurvey link : ? Javascript can do it, but maybe it's best in Admin theme (see the config.xml proposition)
  5. Review if coretemplatedir can be set or not (it's OK in 2.6, unsure since 2.50)

Personnaly : i think it must be done only for non super admin : then in Admin theme it's seems OK.
If you think it must be only the "server admin" system : the all in config.php

dominikvitt

dominikvitt

2019-05-07 16:42

developer   ~51801

Yes, no problem, you can do this feature request to PR in develop.
You can implement as many settings as you like, because any setting would be very useful.

Whenever is possible, it is best to have settings in config.php.
If something is different per survey, then setting should be part of survey settings.
If it is theme related, it should go to theme config.xml.

c_schmitz

c_schmitz

2019-05-07 16:43

administrator   ~51803

Last edited: 2019-05-07 16:43

View 2 revisions

I am okay with settings that hides the LimeSurvey name/logo. I am not okay with settings that change the LimeSurvey name/logo to something else.

c_schmitz

c_schmitz

2019-05-07 16:45

administrator   ~51805

@dominikvitt: I disagree with 'Any setting would be useful'. Settings have to be thought over thoroughly, especially long-term effects of implementing something new.

DenisChenu

DenisChenu

2019-05-07 16:52

developer   ~51807

Last edited: 2019-05-07 16:53

View 2 revisions

@c_schmitz : then Only file name export + limesurvey_links_show to TRUE

Like i said : other can be done in JS theme, and i think it's more related to Theme (except for the Tutorial). Then only export file name in config.php is OK for me :)

c_schmitz

c_schmitz

2019-05-07 16:53

administrator   ~51808

sounds fine.

Issue History

Date Modified Username Field Change
2019-05-02 16:37 DenisChenu New Issue
2019-05-02 16:42 DenisChenu Note Added: 51739
2019-05-02 16:50 c_schmitz Note Added: 51740
2019-05-02 17:14 DenisChenu Note Added: 51743
2019-05-02 17:15 DenisChenu Note Edited: 51743 View Revisions
2019-05-02 17:15 DenisChenu Note Edited: 51743 View Revisions
2019-05-02 17:20 DenisChenu Note Edited: 51743 View Revisions
2019-05-07 15:12 dominikvitt Note Added: 51795
2019-05-07 15:34 DenisChenu Note Added: 51798
2019-05-07 16:42 dominikvitt Note Added: 51801
2019-05-07 16:43 c_schmitz Note Added: 51803
2019-05-07 16:43 c_schmitz Note Edited: 51803 View Revisions
2019-05-07 16:45 c_schmitz Note Added: 51805
2019-05-07 16:52 DenisChenu Note Added: 51807
2019-05-07 16:53 DenisChenu Note Edited: 51807 View Revisions
2019-05-07 16:53 c_schmitz Note Added: 51808
2019-05-07 16:56 DenisChenu Assigned To => DenisChenu
2019-05-07 16:56 DenisChenu Status new => assigned
2019-05-07 16:56 DenisChenu Target Version => 4.0.0dev