View Issue Details

IDProjectCategoryView StatusLast Update
14747Bug reports[All Projects] Otherpublic2019-04-08 11:28
ReporterDenisChenuAssigned Todominikvitt 
PrioritynoneSeveritymajor 
Status resolvedResolutionfixed 
Product Version4.0.0dev 
Target VersionFixed in Version4.0.0dev 
Summary14747: Don't set encryptionkey in a git managed file
Description

See when commiting
And git reset --hard origin/develop broke key.

Additional Information

I think it must be set in config.php file only ? No ?

TagsNo tags attached.
Complete LimeSurvey version number (& build)4.0.0 github
I will donate to the project if issue is resolvedNo
Browserff
Database & DB-Versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Activities

DenisChenu

DenisChenu

2019-04-05 13:32

developer   ~51381

Oups … the screenshot



dominikvitt

dominikvitt

2019-04-05 15:46

developer   ~51394

Separate file is used to prevent being accidentally deleted when editing config file.

I set this file in .gitignore file in root, but it seems that it isn't working.
See here: https://github.com/LimeSurvey/LimeSurvey/commit/5a5685d72783fc8f7635ac9e706e55099cd55793
Do you have any idea how to make it to be ignored by git?

DenisChenu

DenisChenu

2019-04-05 16:34

developer   ~51395

Oh, i prefer to have config-security.php then :) or i really like security-locale.php (some linux too do this : locale is for … locale … ;) )

Strange i think it mus work …
I check

DenisChenu

DenisChenu

2019-04-05 16:37

developer   ~51396

PS : i think to work on installer ,
One of the reason it's application directory must be set up as READ only after install.

Maybe : ./config/ and have it inside ./config/config.php + ./config/security.php + ./config/ldap.php ?
Create it by copying existing when setup.

For old install : if(!is_file(./config/config.php) [ try to read ./appliaction/config/config.ph ]

You opinion ?
Denis

dominikvitt

dominikvitt

2019-04-08 11:28

developer   ~51403

I just removed this file from git index, so you can try again.
If it doesn't work, you would have to delete security.php file and recreate it again.

https://github.com/LimeSurvey/LimeSurvey/commit/b8d7fc3ba1c29faa31b4e3f82ff7c79bfc84a718

Issue History

Date Modified Username Field Change
2019-04-05 13:32 DenisChenu New Issue
2019-04-05 13:32 DenisChenu Status new => assigned
2019-04-05 13:32 DenisChenu Assigned To => dominikvitt
2019-04-05 13:32 DenisChenu File Added: Capture d’écran du 2019-04-05 13-31-08.png
2019-04-05 13:32 DenisChenu Note Added: 51381
2019-04-05 15:46 dominikvitt Note Added: 51394
2019-04-05 16:34 DenisChenu Note Added: 51395
2019-04-05 16:37 DenisChenu Note Added: 51396
2019-04-08 11:28 dominikvitt Status assigned => resolved
2019-04-08 11:28 dominikvitt Resolution open => fixed
2019-04-08 11:28 dominikvitt Fixed in Version => 4.0.0dev
2019-04-08 11:28 dominikvitt Note Added: 51403