14661: Plugin developemnt need a "Don't disable plugin" - LimeSurvey bugs and feature requests

This bug affects 1 person(s).

ID	Project	Category	View Status	Date Submitted	Last Update

14661	Feature requests	Plugins	public	2019-03-18 18:35	2024-03-11 15:21

Reporter	DenisChenu	Assigned To	DenisChenu
Priority	none	Severity	feature
Status	closed	Resolution	fixed

Summary	14661: Plugin developemnt need a "Don't disable plugin"
Description	I work currently on https://github.com/Shnoulle/LimeSurvey-Shnoulle/tree/develop_mailer (adding a class for mailer ,and all beforeEmail event) I do a sample plugin, but this one break a lot … Then each time it break : i add to activate it again … It can be cool to have a "don't disable plugin"
Additional Information	debug>2 mean plugin not disable (or anything not disable) or a specific debug ? debugPlugin, debugTemplate, debugTheme (we don't have a disbalme theme currently, but when we have one. Have only one debug : more easy for dev, but can be complicated on mantis (see plugin debug too) BUT : plugin can cause transparent bug on core (if they set a string to an array event for example). Then : maybe better debug>2 mean debug all :)
Tags	No tags attached.

Bug heat	6
Story point estimate	0
Users affected %	0

User List	There are no users monitoring this issue.

DenisChenu 2024-01-22 18:44 developer ~79283	@ollehar i make a draft, i create a PR.

tibor.pacalat 2024-02-14 09:29 administrator ~79487	PR for 5.x: https://github.com/LimeSurvey/LimeSurvey/pull/3709/files

tibor.pacalat 2024-02-14 09:29 administrator ~79488	@DenisChenu how can I test this?

DenisChenu 2024-02-14 09:47 developer ~79489	@DenisChenu how can I test this? I search for a methodology, but you need to broke a plugin ;) I do the master before.

DenisChenu 2024-02-29 16:52 developer ~79693	https://github.com/LimeSurvey/LimeSurvey/pull/3770

DenisChenu 2024-02-29 16:59 developer ~79694	Test method : Set debug = 2 Scan file on plugin manager http://php8.1.local/master/index.php?r=admin/pluginmanager&sa=scanFiles 3.remove last ; at https://github.com/LimeSurvey/LimeSurvey/blob/26110d029e4b2921fd294a017368478bddba1c7f/application/core/plugins/FunctionStatic/FunctionStatic.php#L25 Load the page reload the page Expected result Page show `syntax error, unexpected token "protected", expecting "," or ";"` Actual result No error shown, plugin can not be activated

DenisChenu 2024-03-06 15:26 developer ~79744	Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=36168

DenisChenu 2024-03-06 15:26 developer ~79745	Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=36167

LimeBot 2024-03-11 15:21 administrator ~79773	Fixed in Release 5.6.57+240312

LimeSurvey: 5.x e0c06744 2024-03-06 15:26:48 DenisChenu Committer: GitHub Details Diff	Fixed issue 14661: Plugin development need a "Don't disable plugin" (#3709)	Affected Issues 14661
	mod - application/controllers/admin/PluginManagerController.php	Diff File
	mod - application/libraries/PluginManager/PluginManager.php	Diff File
	mod - application/libraries/PluginManager/PluginManagerShutdownFunction.php	Diff File
	mod - application/models/Plugin.php	Diff File
LimeSurvey: 5.x e0c06744 2024-03-06 15:26:48 DenisChenu Committer: GitHub Details Diff	Fixed issue 14661: Plugin development need a "Don't disable plugin" (#3709)	Affected Issues 14661
	mod - application/controllers/admin/PluginManagerController.php	Diff File
	mod - application/libraries/PluginManager/PluginManager.php	Diff File
	mod - application/libraries/PluginManager/PluginManagerShutdownFunction.php	Diff File
	mod - application/models/Plugin.php	Diff File

Date Modified	Username	Field	Change
2019-03-18 18:35	DenisChenu	New Issue
2019-03-18 18:35	DenisChenu	Status	new => assigned
2019-03-18 18:35	DenisChenu	Assigned To	=> ollehar
2024-01-22 18:44	DenisChenu	Note Added: 79283
2024-01-22 18:44	DenisChenu	Bug heat	0 => 2
2024-02-12 13:45	gabrieljenik	Status	assigned => ready for testing
2024-02-14 09:29	tibor.pacalat	Note Added: 79487
2024-02-14 09:29	tibor.pacalat	Bug heat	2 => 4
2024-02-14 09:29	tibor.pacalat	Note Added: 79488
2024-02-14 09:47	DenisChenu	Note Added: 79489
2024-02-29 16:52	DenisChenu	Note Added: 79693
2024-02-29 16:59	DenisChenu	Note Added: 79694
2024-02-29 16:59	DenisChenu	Assigned To	ollehar => tibor.pacalat
2024-03-06 15:26	DenisChenu	Changeset attached	=> LimeSurvey 5.x e0c06744
2024-03-06 15:26	DenisChenu	Changeset attached	=> LimeSurvey 5.x e0c06744
2024-03-06 15:26	DenisChenu	Note Added: 79744
2024-03-06 15:26	DenisChenu	Note Added: 79745
2024-03-06 15:26	DenisChenu	Assigned To	tibor.pacalat => DenisChenu
2024-03-06 15:26	DenisChenu	Assigned To	tibor.pacalat => DenisChenu
2024-03-06 15:26	DenisChenu	Resolution	open => fixed
2024-03-06 15:26	DenisChenu	Resolution	open => fixed
2024-03-06 15:28	tibor.pacalat	Status	ready for testing => resolved
2024-03-06 15:28	tibor.pacalat	Story point estimate	=> 0
2024-03-06 15:28	tibor.pacalat	Users affected %	=> 0
2024-03-11 15:21	LimeBot	Note Added: 79773
2024-03-11 15:21	LimeBot	Status	resolved => closed
2024-03-11 15:21	LimeBot	Bug heat	4 => 6