View Issue Details

This bug affects 1 person(s).
 4
IDProjectCategoryView StatusLast Update
14661Feature requestsPluginspublic2024-02-29 16:59
ReporterDenisChenu Assigned Totibor.pacalat  
PrioritynoneSeverityfeature 
Status ready for testingResolutionopen 
Summary14661: Plugin developemnt need a "Don't disable plugin"
Description

I work currently on https://github.com/Shnoulle/LimeSurvey-Shnoulle/tree/develop_mailer (adding a class for mailer ,and all beforeEmail event)
I do a sample plugin, but this one break a lot …
Then each time it break : i add to activate it again …
It can be cool to have a "don't disable plugin"

Additional Information

debug>2 mean plugin not disable (or anything not disable) or a specific debug ? debugPlugin, debugTemplate, debugTheme (we don't have a disbalme theme currently, but when we have one.

Have only one debug : more easy for dev, but can be complicated on mantis (see plugin debug too)
BUT : plugin can cause transparent bug on core (if they set a string to an array event for example).
Then : maybe better debug>2 mean debug all :)

TagsNo tags attached.
Bug heat4
Story point estimate
Users affected %

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2024-01-22 18:44

developer   ~79283

@ollehar i make a draft, i create a PR.

tibor.pacalat

tibor.pacalat

2024-02-14 09:29

administrator   ~79487

PR for 5.x: https://github.com/LimeSurvey/LimeSurvey/pull/3709/files

tibor.pacalat

tibor.pacalat

2024-02-14 09:29

administrator   ~79488

@DenisChenu how can I test this?

DenisChenu

DenisChenu

2024-02-14 09:47

developer   ~79489

@DenisChenu how can I test this?

I search for a methodology, but you need to broke a plugin ;)
I do the master before.

DenisChenu

DenisChenu

2024-02-29 16:52

developer   ~79693

https://github.com/LimeSurvey/LimeSurvey/pull/3770

DenisChenu

DenisChenu

2024-02-29 16:59

developer   ~79694

Test method :

  1. Set debug = 2
  2. Scan file on plugin manager http://php8.1.local/master/index.php?r=admin/pluginmanager&sa=scanFiles
    3.remove last ; at https://github.com/LimeSurvey/LimeSurvey/blob/26110d029e4b2921fd294a017368478bddba1c7f/application/core/plugins/FunctionStatic/FunctionStatic.php#L25
  3. Load the page
  4. reload the page

Expected result

Page show syntax error, unexpected token "protected", expecting "," or ";"

Actual result

No error shown, plugin can not be activated

Issue History

Date Modified Username Field Change
2019-03-18 18:35 DenisChenu New Issue
2019-03-18 18:35 DenisChenu Status new => assigned
2019-03-18 18:35 DenisChenu Assigned To => ollehar
2024-01-22 18:44 DenisChenu Note Added: 79283
2024-01-22 18:44 DenisChenu Bug heat 0 => 2
2024-02-12 13:45 gabrieljenik Status assigned => ready for testing
2024-02-14 09:29 tibor.pacalat Note Added: 79487
2024-02-14 09:29 tibor.pacalat Bug heat 2 => 4
2024-02-14 09:29 tibor.pacalat Note Added: 79488
2024-02-14 09:47 DenisChenu Note Added: 79489
2024-02-29 16:52 DenisChenu Note Added: 79693
2024-02-29 16:59 DenisChenu Note Added: 79694
2024-02-29 16:59 DenisChenu Assigned To ollehar => tibor.pacalat