View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 6
IDProjectCategoryView StatusDate SubmittedLast Update
14661Feature requestsPluginspublic2019-03-18 18:352024-11-19 18:15
ReporterDenisChenu Assigned Togabrieljenik  
PrioritynoneSeverityfeature 
Status closedResolutionfixed 
Summary14661: Plugin developemnt need a "Don't disable plugin"
Description

I work currently on https://github.com/Shnoulle/LimeSurvey-Shnoulle/tree/develop_mailer (adding a class for mailer ,and all beforeEmail event)
I do a sample plugin, but this one break a lot …
Then each time it break : i add to activate it again …
It can be cool to have a "don't disable plugin"

Additional Information

debug>2 mean plugin not disable (or anything not disable) or a specific debug ? debugPlugin, debugTemplate, debugTheme (we don't have a disbalme theme currently, but when we have one.

Have only one debug : more easy for dev, but can be complicated on mantis (see plugin debug too)
BUT : plugin can cause transparent bug on core (if they set a string to an array event for example).
Then : maybe better debug>2 mean debug all :)

TagsNo tags attached.
Bug heat6
Story point estimate0
Users affected %0

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2024-01-22 18:44

developer   ~79283

@ollehar i make a draft, i create a PR.
tibor.pacalat

tibor.pacalat

2024-02-14 09:29

administrator   ~79487

PR for 5.x: https://github.com/LimeSurvey/LimeSurvey/pull/3709/files
tibor.pacalat

tibor.pacalat

2024-02-14 09:29

administrator   ~79488

@DenisChenu how can I test this?
DenisChenu

DenisChenu

2024-02-14 09:47

developer   ~79489

@DenisChenu how can I test this?

I search for a methodology, but you need to broke a plugin ;)
I do the master before.
DenisChenu

DenisChenu

2024-02-29 16:52

developer   ~79693

https://github.com/LimeSurvey/LimeSurvey/pull/3770
DenisChenu

DenisChenu

2024-02-29 16:59

developer   ~79694

Test method :

  1. Set debug = 2
  2. Scan file on plugin manager http://php8.1.local/master/index.php?r=admin/pluginmanager&sa=scanFiles
    3.remove last ; at https://github.com/LimeSurvey/LimeSurvey/blob/26110d029e4b2921fd294a017368478bddba1c7f/application/core/plugins/FunctionStatic/FunctionStatic.php#L25
  3. Load the page
  4. reload the page

Expected result

Page show syntax error, unexpected token "protected", expecting "," or ";"

Actual result

No error shown, plugin can not be activated
DenisChenu

DenisChenu

2024-03-06 15:26

developer   ~79744

Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=36168
DenisChenu

DenisChenu

2024-03-06 15:26

developer   ~79745

Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=36167
LimeBot

LimeBot

2024-03-11 15:21

administrator   ~79773

Fixed in Release 5.6.57+240312
DenisChenu

DenisChenu

2024-06-21 12:37

developer   ~80411

5.X merged
Not master : https://github.com/LimeSurvey/LimeSurvey/pull/3770
DenisChenu

DenisChenu

2024-06-24 10:11

developer   ~80433

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=36423
LimeBot

LimeBot

2024-06-24 13:17

administrator   ~80446

Fixed in Release 6.5.14+240624
tibor.pacalat

tibor.pacalat

2024-06-27 10:35

administrator   ~80482

@DenisChenu there is a bug in your PR, all plugins look deactivated which causes additional issues.
DenisChenu

DenisChenu

2024-06-27 10:36

developer   ~80483

I check now.
You can revert ?
DenisChenu

DenisChenu

2024-06-27 10:54

developer   ~80484

Not needed, i have it
DenisChenu

DenisChenu

2024-06-27 10:56

developer   ~80485

https://github.com/LimeSurvey/LimeSurvey/pull/3899

Related Changesets

LimeSurvey: 5.x e0c06744

2024-03-06 16:26

DenisChenu

Committer: GitHub


Details Diff		 Fixed issue 14661: Plugin development need a "Don't disable plugin" (#3709) Affected Issues
14661
mod - application/controllers/admin/PluginManagerController.php Diff File
mod - application/libraries/PluginManager/PluginManager.php Diff File
mod - application/libraries/PluginManager/PluginManagerShutdownFunction.php Diff File
mod - application/models/Plugin.php Diff File

LimeSurvey: 5.x e0c06744

2024-03-06 16:26

DenisChenu

Committer: GitHub


Details Diff		 Fixed issue 14661: Plugin development need a "Don't disable plugin" (#3709) Affected Issues
14661
mod - application/controllers/admin/PluginManagerController.php Diff File
mod - application/libraries/PluginManager/PluginManager.php Diff File
mod - application/libraries/PluginManager/PluginManagerShutdownFunction.php Diff File
mod - application/models/Plugin.php Diff File

LimeSurvey: master e347d9d2

2024-06-24 12:01

DenisChenu

Committer: GitHub


Details Diff		 Fixed issue 14661: Plugin development need a "Don't disable plugin" (#3770) Affected Issues
14661
mod - application/controllers/admin/PluginManagerController.php Diff File
mod - application/libraries/PluginManager/PluginManager.php Diff File
mod - application/libraries/PluginManager/PluginManagerShutdownFunction.php Diff File
mod - application/models/Plugin.php Diff File

Issue History

Date Modified Username Field Change
2019-03-18 18:35 DenisChenu New Issue
2019-03-18 18:35 DenisChenu Status new => assigned
2019-03-18 18:35 DenisChenu Assigned To => ollehar
2024-01-22 18:44 DenisChenu Note Added: 79283
2024-01-22 18:44 DenisChenu Bug heat 0 => 2
2024-02-12 13:45 gabrieljenik Status assigned => ready for testing
2024-02-14 09:29 tibor.pacalat Note Added: 79487
2024-02-14 09:29 tibor.pacalat Bug heat 2 => 4
2024-02-14 09:29 tibor.pacalat Note Added: 79488
2024-02-14 09:47 DenisChenu Note Added: 79489
2024-02-29 16:52 DenisChenu Note Added: 79693
2024-02-29 16:59 DenisChenu Note Added: 79694
2024-02-29 16:59 DenisChenu Assigned To ollehar => tibor.pacalat
2024-03-06 15:26 DenisChenu Changeset attached => LimeSurvey 5.x e0c06744
2024-03-06 15:26 DenisChenu Changeset attached => LimeSurvey 5.x e0c06744
2024-03-06 15:26 DenisChenu Note Added: 79744
2024-03-06 15:26 DenisChenu Note Added: 79745
2024-03-06 15:26 DenisChenu Assigned To tibor.pacalat => DenisChenu
2024-03-06 15:26 DenisChenu Assigned To tibor.pacalat => DenisChenu
2024-03-06 15:26 DenisChenu Resolution open => fixed
2024-03-06 15:26 DenisChenu Resolution open => fixed
2024-03-06 15:28 tibor.pacalat Status ready for testing => resolved
2024-03-06 15:28 tibor.pacalat Story point estimate => 0
2024-03-06 15:28 tibor.pacalat Users affected % => 0
2024-03-11 15:21 LimeBot Note Added: 79773
2024-03-11 15:21 LimeBot Status resolved => closed
2024-03-11 15:21 LimeBot Bug heat 4 => 6
2024-06-21 12:37 DenisChenu Assigned To DenisChenu => gabrieljenik
2024-06-21 12:37 DenisChenu Status closed => feedback
2024-06-21 12:37 DenisChenu Resolution fixed => reopened
2024-06-21 12:37 DenisChenu Note Added: 80411
2024-06-21 12:37 DenisChenu Status feedback => ready for code review
2024-06-21 22:04 gabrieljenik Assigned To gabrieljenik => tibor.pacalat
2024-06-21 22:04 gabrieljenik Status ready for code review => ready for testing
2024-06-24 10:01 tibor.pacalat Status ready for testing => resolved
2024-06-24 10:11 DenisChenu Changeset attached => LimeSurvey master e347d9d2
2024-06-24 10:11 DenisChenu Note Added: 80433
2024-06-24 10:11 DenisChenu Assigned To tibor.pacalat => DenisChenu
2024-06-24 10:11 DenisChenu Resolution reopened => fixed
2024-06-24 13:17 LimeBot Note Added: 80446
2024-06-24 13:17 LimeBot Status resolved => closed
2024-06-27 10:34 tibor.pacalat Status closed => assigned
2024-06-27 10:35 tibor.pacalat Note Added: 80482
2024-06-27 10:36 DenisChenu Note Added: 80483
2024-06-27 10:54 DenisChenu Note Added: 80484
2024-06-27 10:56 DenisChenu Assigned To DenisChenu => gabrieljenik
2024-06-27 10:56 DenisChenu Status assigned => ready for code review
2024-06-27 10:56 DenisChenu Note Added: 80485
2024-06-27 11:22 tibor.pacalat Status ready for code review => resolved
2024-11-19 18:15 c_schmitz Status resolved => closed