View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|14541||Bug reports||[All Projects] Theme editor||public||2019-02-18 10:08||2019-06-12 12:37|
|Target Version||Fixed in Version|
|Summary||14541: Regression: "Next" and "Submit" buttons use same IDs and classes|
Currently it is pretty complex styling the "Next" and "Submit" buttons properly because they use the same ID and mostly the same classes:
Both are using ID "ls-button-submit". At LS 2.7x the next button used its own ID ("movenextbtn") which made it pretty straightforward to style them differently based on the ID.
|Steps To Reproduce|
Test a short 2 page survey and check IDs and classes of the Next and Submit buttons
I suggest adding classes "nextbutton" and "submitbutton" at https://github.com/LimeSurvey/LimeSurvey/blob/master/themes/survey/vanilla/views/subviews/navigation/navigator.twig#L47 and https://github.com/LimeSurvey/LimeSurvey/blob/master/themes/survey/vanilla/views/subviews/navigation/navigator.twig#L52
|Tags||No tags attached.|
|Complete LimeSurvey version number (& build)||3.15.9+190214|
|I will donate to the project if issue is resolved||No|
|Database & DB-Version||MySQL 5|
|Server OS (if known)||Ubuntu 14 TLS|
|Webserver software & version (if known)||Apache 2|
Using navigator directly ;).
Else maube we can remove ls-move-submit-btn from next button.
@markusfluer: we will provide a pull request which adds classes "nextbutton" and "submitbutton".
This totally redundant, and not a regression.
@markusfluer : yes : move next have
Yes : you can do
Mazi, don't commit just something before we all agreed what is to be done. That is not helping. I reverted your commit.
As per the topic:
What do you think, Markus?
Hi Carsten, I agree that this is not the best approach but, to be honest, I was a little tired of the discussion. The problem can be solved easily by adding additional. unique classes. Removing a class is something I am not in favor of because, as you pointed out, these may already be used by others.
What is your preferred approach, Carsten?
Mazi, regarding your last question: Please read what I wrote in my previous comment.
Something i don't understand : make own navigator.twig is really easy in template …
I need an id for each navigator, i add it in my theme, not in core : https://gitlab.com/SondagesPro/SurveyThemes/skelvanilla/blob/master/views/subviews/navigation/navigator.twig#L7
Denis, you are not the average Limesurvey user. You are an experienced developer, you can do great stuff. But we need to view such issues from the default user point of view and check what the easiest solution would be for them.
@Mazi : you sell theme, you distribute free theme on LimeStore. I distribute free theme too ans we wait more theme.
I'm OK we need to get the user point of view, but here : if user didn't know anything of CSS : use
No big difference …
@Mazi : i didn't see any forum post related to this mantis …
|2019-02-18 10:08||Mazi||New Issue|
|2019-02-18 10:08||Mazi||Status||new => assigned|
|2019-02-18 10:08||Mazi||Assigned To||=> LouisGac|
|2019-02-18 10:15||DenisChenu||Note Added: 50592|
|2019-05-07 17:19||Mazi||Note Added: 51811|
|2019-05-07 17:39||markusfluer||Note Added: 51813|
|2019-05-07 18:28||DenisChenu||Note Added: 51815|
|2019-06-12 09:17||Mazi||Note Added: 52350|
|2019-06-12 09:38||c_schmitz||Note Added: 52352|
|2019-06-12 09:39||c_schmitz||Note Edited: 52352||View Revisions|
|2019-06-12 09:43||Mazi||Note Added: 52353|
|2019-06-12 09:45||c_schmitz||Note Added: 52354|
|2019-06-12 10:02||c_schmitz||Note Edited: 52354||View Revisions|
|2019-06-12 11:29||DenisChenu||Note Added: 52355|
|2019-06-12 11:33||Mazi||Note Added: 52356|
|2019-06-12 12:36||DenisChenu||Note Added: 52359|
|2019-06-12 12:37||DenisChenu||Note Added: 52360|