Hello,
I found a bug on today master branch. You can see the steps to reproduce it.
SQ001 ; SQ001 légitime SQ001comment ; SQ001 injection comment ; injectionseule
So you can't fix it with the button "Click here to fix"
realitix
2019-02-06 16:52
reporter ~50427
Here the pull request: https://github.com/LimeSurvey/LimeSurvey/pull/1213
DenisChenu
2019-02-06 23:21
developer ~50428
Last edited: 2019-02-06 23:25
1: must fix it in model : see https://github.com/LimeSurvey/LimeSurvey/blob/0c0cf2bb2fab25146c38858fc0b897787e031188/application/models/Question.php#L132 2: must fix only https://github.com/LimeSurvey/LimeSurvey/blob/51f685f31172bee68802a0885600568377d89845/application/helpers/admin/activate_helper.php#L22
Not in database.php
for model since ending with comment seems to broke Expression manager (check survey logic file) disable ending code with comment directly
2019-02-07 11:48
reporter ~50434
I have to understand the rule logic. Is there a guide to explain how it works ?
2019-02-07 12:02
developer ~50435
Last edited: 2019-02-07 12:03
https://www.yiiframework.com/wiki/56/reference-model-rules-validation
But LimeSurvey Question model have some really complex rules.
Something like this
if ($oParentQuestion->type == "P") { $aRules[] = /* todo */ }
Maybe some match rules ? https://www.yiiframework.com/wiki/56/reference-model-rules-validation#match-cregularexpressionvalidator https://www.yiiframework.com/doc/api/1.1/CRegularExpressionValidator
2019-02-07 14:40
reporter ~50442
I updated the pull request with your indication.
2019-02-09 17:05
developer ~50481
https://github.com/LimeSurvey/LimeSurvey/commit/a47c09d18bf47b1205b5586d451ee6d2002cef4b
2019-02-19 10:54
reporter ~50622
I added a new pull request to enforce the filter, to avoid 'comment'
https://github.com/LimeSurvey/LimeSurvey/pull/1228
