View Issue Details

IDProjectCategoryView StatusLast Update
14362Bug reports[All Projects] Theme editorpublic2019-04-30 09:11
ReporterDenisChenu Assigned ToDenisChenu  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version3.15.x 
Target VersionFixed in Version3.15.x 
Summary14362: Template can throw error with invalid image
Description

If an image don't exist : template throw error PHP Warning with debug set to 2 and 500 error with debug=0

Steps To Reproduce

Import a global file
Set it at logo
See a survey with default inherit
Remove image or rename
See survey : PHP warning

Additional Information

All path must be checked if exist before doing something :)

Maybe add an error in template editor only ?

TagsNo tags attached.
Complete LimeSurvey version number (& build)3.15.5 github
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database & DB-Versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Activities

DenisChenu

DenisChenu

2018-12-19 18:12

developer  

PHP warning.html (47,732 bytes)
DenisChenu

DenisChenu

2018-12-19 18:13

developer   ~50011

Happen with debug at 0 too



500 : Erreur interne au serveur.html (15,261 bytes)
DenisChenu

DenisChenu

2018-12-19 18:14

developer   ~50012

Last edited: 2018-12-19 18:14

View 2 revisions

Why this error is in french and not german … :( …

default lang is french, OK, but survey is in german : the language must be set in German …

DenisChenu

DenisChenu

2018-12-20 00:18

developer   ~50016

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=28665

ollehar

ollehar

2019-01-16 17:30

administrator   ~50239

Fix committed to develop branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=28766

Related Changesets

LimeSurvey: master 05aa0a34

2018-12-20 00:18:29

DenisChenu

Details Diff
Fixed issue 14362: Template can throw error with invalid image
Dev: test if file exist before send it to imageValidator
Dev: add commment on validateImage function (this can be updated if needed, but not really the task of a image validation)
Dev: or did image validation must test if file exist ?
Affected Issues
14362
mod - application/core/LSYii_ImageValidator.php Diff File
mod - application/core/LS_Twig_Extension.php Diff File

LimeSurvey: develop 513ce2c7

2018-12-20 00:18:29

DenisChenu


Committer: ollehar Details Diff
Fixed issue 14362: Template can throw error with invalid image
Dev: test if file exist before send it to imageValidator
Dev: add commment on validateImage function (this can be updated if needed, but not really the task of a image validation)
Dev: or did image validation must test if file exist ?
Affected Issues
14362
mod - application/core/LSYii_ImageValidator.php Diff File
mod - application/core/LS_Twig_Extension.php Diff File

Issue History

Date Modified Username Field Change
2018-12-19 18:12 DenisChenu New Issue
2018-12-19 18:12 DenisChenu File Added: PHP warning.html
2018-12-19 18:13 DenisChenu File Added: 500 : Erreur interne au serveur.html
2018-12-19 18:13 DenisChenu Note Added: 50011
2018-12-19 18:14 DenisChenu Note Added: 50012
2018-12-19 18:14 DenisChenu Note Edited: 50012 View Revisions
2018-12-20 00:08 DenisChenu Summary Template can throw error aout not exsiting file (PHP Warning) => Template can throw error with invalid image
2018-12-20 00:08 DenisChenu Description Updated View Revisions
2018-12-20 00:08 DenisChenu Assigned To => DenisChenu
2018-12-20 00:08 DenisChenu Status new => assigned
2018-12-20 00:18 DenisChenu Changeset attached => LimeSurvey master 05aa0a34
2018-12-20 00:18 DenisChenu Note Added: 50016
2018-12-20 00:18 DenisChenu Resolution open => fixed
2018-12-20 00:18 DenisChenu Status assigned => resolved
2018-12-20 00:18 DenisChenu Fixed in Version => 3.15.x
2019-01-16 17:30 ollehar Changeset attached => LimeSurvey develop 513ce2c7
2019-01-16 17:30 ollehar Note Added: 50239
2019-04-30 09:11 c_schmitz Status resolved => closed