View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 14219 | Bug reports | Response browsing | public | 2018-11-06 18:19 | 2018-11-12 17:20 |
| Reporter | DenisChenu | Assigned To | DenisChenu | ||
| Priority | none | Severity | minor | ||
| Status | closed | Resolution | fixed | ||
| Product Version | 3.15.x | ||||
| Summary | 14219: Unable to quick delete reponse with urlFormat to get | ||||
| Description | When use 'urlFormat' => 'get', for urlManager (ngynx for example) : the delete button didn't work. | ||||
| Steps To Reproduce | Set your 'urlFormat' => 'get' in config. | ||||
| Additional Information | I try to fix url, but with convertGETtoPOST(App()->createUrl("admin/responses/sa/actionDelete",array('surveyid' => self::$sid,'sResponseId' => $this->id))) this goes to a broken link (400 error) => no route are set I really think convertGETtoPOST function must be avoided it's really an old function (and broken). | ||||
| Tags | No tags attached. | ||||
| Bug heat | 2 | ||||
| Complete LimeSurvey version number (& build) | 3.15.1 github | ||||
| I will donate to the project if issue is resolved | No | ||||
| Browser | not relevant | ||||
| Database type & version | not relevant | ||||
| Server OS (if known) | not relevant | ||||
| Webserver software & version (if known) | not relevant | ||||
| PHP Version | not relevant | ||||
| related to | 14221 | closed | DenisChenu | No XSS control when delete a token |
| related to | 14222 | closed | DenisChenu | When deleting a single response : all page is reloaded and current filter lost |
| related to | 14159 | closed | DenisChenu | Cannot delete response |
|
Remind to use POST value :) |
|
|
Fix committed to master_fixDeleteResponse_urlget branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=28502 |
|
|
LimeSurvey: master_fixDeleteResponse_urlget a2c478e6 2018-11-08 10:30 Details Diff |
Fixed issue 14219: Unable to quick delete reponse with urlFormat to get Fixed issue 14222: When deleting a single response : all page is reloaded (not only grid) Dev: usage of CButtonColumn Dev: return real error, show it in alert Dev: LS need a system to show result after ajax … Dev: i don't find it |
Affected Issues 14219, 14222 |
|
| mod - application/controllers/admin/responses.php | Diff File | ||
| mod - application/helpers/admin/ajax_helper.php | Diff File | ||
| mod - application/models/SurveyDynamic.php | Diff File | ||
| mod - application/views/admin/responses/listResponses_view.php | Diff File | ||
| mod - assets/scripts/admin/listresponse.js | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2018-11-06 18:19 | DenisChenu | New Issue | |
| 2018-11-06 22:49 | DenisChenu | Relationship added | related to 14221 |
| 2018-11-06 22:50 | DenisChenu | Note Added: 49560 | |
| 2018-11-06 22:55 | DenisChenu | Relationship added | related to 14222 |
| 2018-11-09 18:35 | DenisChenu | Relationship added | related to 14159 |
| 2018-11-09 19:24 | DenisChenu | Assigned To | => DenisChenu |
| 2018-11-09 19:24 | DenisChenu | Status | new => assigned |
| 2018-11-11 19:09 | DenisChenu | Status | assigned => closed |
| 2018-11-11 19:09 | DenisChenu | Resolution | open => duplicate |
| 2018-11-12 17:20 | DenisChenu | Changeset attached | => LimeSurvey master_fixDeleteResponse_urlget a2c478e6 |
| 2018-11-12 17:20 | DenisChenu | Note Added: 49616 | |
| 2018-11-12 17:20 | DenisChenu | Resolution | duplicate => fixed |