View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
14185 | Bug reports | Theme editor | public | 2018-10-26 10:17 | 2019-04-30 09:12 |
Reporter | tpartner | Assigned To | |||
Priority | none | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 3.15.x | ||||
Target Version | 3.15.x | Fixed in Version | 4.0.0dev | ||
Summary | 14185: Need a clean way to hide custom question theme attributes | ||||
Description | Currently, the only way I can see to hide unnecessary question attributes in a custom question theme is to set the <inputtype> to null in the config.xml file (see attached). This effectively disables the attribute setting but does not totally hide it from the survey author. Is there a way to completely remove the attribute setting from the edit-question view? Sample config file and theme attached. | ||||
Tags | No tags attached. | ||||
Attached Files | |||||
Bug heat | 8 | ||||
Complete LimeSurvey version number (& build) | 3.15.1 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | N/A | ||||
Database type & version | mysqlnd 5.0.12-dev | ||||
Server OS (if known) | Windows 10 | ||||
Webserver software & version (if known) | Apache/2.4.27 (Win32) OpenSSL/1.0.2l PHP/7.1.9 | ||||
PHP Version | 7.1.9 | ||||
related to | 14190 | new | [question template] Some core attribute disable existing template |
You think it's better to hide it in css ? Or totally wipe out in html ? What param : new param 'visible'=> (true|false) (true by default) ? If visible == false : don't display it. Leave readonly like currently : if visible is false, readonly is false : you can add script (in future) to update it. But visible=>false,readonly=>true : didn't display + didn't allow update. |
|
I think it would be safer to completely remove it from the HTML with a new parameter. If you want it displayed but not editable (readonly), you can do something like I have done for "Use slider layout". |
|
«If you want it displayed but not editable (readonly), » just add readonly => true attribute It's done for this and really clean :) since https://github.com/LimeSurvey/LimeSurvey/commit/a875677a03f18b4cc505ef51379deaa29d2e2340#diff-51f80c6491f513287823eb97b46c89f2 it's cleaner in view |
|
Okay, I knew about <readonly_when_active>, but not simply <readonly>. I'll try that for "Use slider layout". |
|
OK, testing currently some code about replace existing attribute … There are a big issue : https://github.com/LimeSurvey/LimeSurvey/pull/1159 with included updated config.xml : ajax relaod didn't show location settings. I see to fix this |
|
Fix committed to master_visibleOrNot_attribute branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=28409 |
|
Question : seems you version remove existing attribute from DB : did this attended behaviour ? |
|
@tpartner : did you try with <types></type> ? I test : it don't work when set template, but it‘s reaaly work after saving it And this fix this issue too : https://bugs.limesurvey.org/view.php?id=14190 |
|
@DenisChenu: yes, it is fixed in develop. |
|
|
|
@tpartner : did you try with <types></types> ? I test it (with autocomplete and location attributes): seems OK.
|
|
Fixed in Version 3.1.7.3 |
|
LimeSurvey: master_visibleOrNot_attribute 3c62f955 2018-10-27 14:21 Details Diff |
New feature 14185: Need a clean way to hide custom question theme attributes Dev: still a little issue, explain in pull request |
Affected Issues 14185 |
|
mod - application/models/QuestionAttribute.php | Diff File | ||
mod - application/views/admin/survey/Question/advanced_settings_view.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2018-10-26 10:17 | tpartner | New Issue | |
2018-10-26 10:17 | tpartner | File Added: sliderWithControls.zip | |
2018-10-26 10:17 | tpartner | File Added: config.xml | |
2018-10-26 10:17 | tpartner | File Added: capture-3.png | |
2018-10-26 10:26 | tpartner | Description Updated | |
2018-10-26 10:53 | DenisChenu | Note Added: 49446 | |
2018-10-26 10:53 | DenisChenu | Assigned To | => DenisChenu |
2018-10-26 10:53 | DenisChenu | Status | new => assigned |
2018-10-26 10:53 | DenisChenu | Note Edited: 49446 | |
2018-10-26 10:54 | DenisChenu | Note Edited: 49446 | |
2018-10-26 11:00 | tpartner | Note Added: 49448 | |
2018-10-26 11:09 | DenisChenu | Note Added: 49449 | |
2018-10-26 11:31 | tpartner | Note Added: 49450 | |
2018-10-27 15:56 | DenisChenu | File Added: config-2.xml | |
2018-10-27 15:56 | DenisChenu | Note Added: 49461 | |
2018-10-27 15:57 | DenisChenu | Note Edited: 49461 | |
2018-10-28 14:30 | DenisChenu | Changeset attached | => LimeSurvey master_visibleOrNot_attribute 3c62f955 |
2018-10-28 14:30 | DenisChenu | Note Added: 49462 | |
2018-10-28 14:30 | DenisChenu | Resolution | open => fixed |
2018-10-28 14:41 | DenisChenu | Relationship added | related to 14190 |
2018-10-30 15:09 | DenisChenu | Assigned To | DenisChenu => dominikvitt |
2018-10-30 15:10 | DenisChenu | Note Added: 49493 | |
2018-10-30 15:42 | DenisChenu | Note Added: 49496 | |
2018-11-02 15:41 |
|
Note Added: 49519 | |
2018-11-03 00:38 | DenisChenu | Status | assigned => resolved |
2018-11-03 00:38 | DenisChenu | Fixed in Version | => 4.0.0dev |
2018-11-03 07:26 | tpartner | Note Added: 49525 | |
2018-11-03 11:42 | DenisChenu | Note Added: 49527 | |
2019-04-30 09:12 | c_schmitz | Note Added: 51662 | |
2019-04-30 09:12 | c_schmitz | Status | resolved => closed |