View Issue Details

Jump to NotesJump to History
This bug affects 1 person(s).
 4
IDProjectCategoryView StatusDate SubmittedLast Update
14126Bug reportsSurvey editingpublic2018-10-04 10:142021-03-11 08:20
ReporterDenisChenu Assigned To 
PrioritynoneSeverityminor 
Status newResolutionopen 
Product Version3.14.x 
Summary14126: google map without API broke
Description

With a question without API key : google map broke. We can not realy fix it … BUT : we must disable google map if not API key is set

Steps To Reproduce

Create a question with google map
test this question
Go to the link shown : https://developers.google.com/maps/documentation/javascript/error-messages?utm_source=maps_js&utm_medium=degraded&utm_campaign=keyless#api-key-and-billing-errors

Additional Information

Best solution : remove Google map and create a "disablme" by default Question theme but need a way to add a "theme setting" for this API key (globally)
Bad and quick solution : add "gmap" only if global setting is set : https://github.com/LimeSurvey/LimeSurvey/blob/91a5cef685f358a85f7cf829d97809a63b68b807/application/helpers/questionHelper.php#L454

With bad and quick solution : we can remove some settings too (about country/town) : https://github.com/LimeSurvey/LimeSurvey/blob/master/application/helpers/questionHelper.php#L358-L404

TagsNo tags attached.
Attached Files
Capture du 2018-10-04 10-09-30.png (188,216 bytes)
Bug heat4
Complete LimeSurvey version number (& build)3.14.11
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Relationships

Relationship GraphDependency Graph
related to 14128 new Feature requests Question theme/template need settings (global and maybe survey) 

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2018-10-04 13:30

developer   ~49234

https://github.com/LimeSurvey/LimeSurvey/pull/1135
ollehar

ollehar

2021-03-10 22:08

administrator   ~63177

Still relevant?
DenisChenu

DenisChenu

2021-03-11 08:19

developer   ~63265

Capture d’écran du 2021-03-11 08-18-24.png (158,601 bytes)
limesurvey_survey_MAP.lss (13,613 bytes)
DenisChenu

DenisChenu

2021-03-11 08:20

developer   ~63266

3.25.17 still broke.

But : if Map questin can be moved to Theme : it's better

Issue History

Date Modified Username Field Change
2018-10-04 10:14 DenisChenu New Issue
2018-10-04 10:14 DenisChenu File Added: Capture du 2018-10-04 10-09-30.png
2018-10-04 11:31 DenisChenu Relationship added related to 14128
2018-10-04 13:30 DenisChenu Note Added: 49234
2019-11-01 17:25 c_schmitz Category Survey design => Survey editing
2021-03-10 22:08 ollehar Status new => feedback
2021-03-10 22:08 ollehar Note Added: 63177
2021-03-11 08:19 DenisChenu Note Added: 63265
2021-03-11 08:19 DenisChenu File Added: Capture d’écran du 2021-03-11 08-18-24.png
2021-03-11 08:19 DenisChenu File Added: limesurvey_survey_MAP.lss
2021-03-11 08:19 DenisChenu Status feedback => new
2021-03-11 08:20 DenisChenu Note Added: 63266