View Issue Details

IDProjectCategoryView StatusLast Update
14126Bug reports[All Projects] Survey editingpublic2018-10-04 13:30
ReporterDenisChenu Assigned To 
PrioritynoneSeverityminor 
Status newResolutionopen 
Product Version3.14.x 
Target VersionFixed in Version 
Summary14126: google map without API broke
Description

With a question without API key : google map broke. We can not realy fix it … BUT : we must disable google map if not API key is set

Steps To Reproduce

Create a question with google map
test this question
Go to the link shown : https://developers.google.com/maps/documentation/javascript/error-messages?utm_source=maps_js&utm_medium=degraded&utm_campaign=keyless#api-key-and-billing-errors

Additional Information

Best solution : remove Google map and create a "disablme" by default Question theme but need a way to add a "theme setting" for this API key (globally)
Bad and quick solution : add "gmap" only if global setting is set : https://github.com/LimeSurvey/LimeSurvey/blob/91a5cef685f358a85f7cf829d97809a63b68b807/application/helpers/questionHelper.php#L454

With bad and quick solution : we can remove some settings too (about country/town) : https://github.com/LimeSurvey/LimeSurvey/blob/master/application/helpers/questionHelper.php#L358-L404

TagsNo tags attached.
Complete LimeSurvey version number (& build)3.14.11
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database & DB-Versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Relationships

related to 14128 new Feature requests Question theme/template need settings (global and maybe survey) 

Activities

DenisChenu

DenisChenu

2018-10-04 10:14

developer  

Capture du 2018-10-04 10-09-30.png (188,216 bytes)
DenisChenu

DenisChenu

2018-10-04 13:30

developer   ~49234

https://github.com/LimeSurvey/LimeSurvey/pull/1135

Issue History

Date Modified Username Field Change
2018-10-04 10:14 DenisChenu New Issue
2018-10-04 10:14 DenisChenu File Added: Capture du 2018-10-04 10-09-30.png
2018-10-04 11:31 DenisChenu Relationship added related to 14128
2018-10-04 13:30 DenisChenu Note Added: 49234
2019-11-01 17:25 c_schmitz Category Survey design => Survey editing