is it in relation with this forum post? https://www.limesurvey.org/forum/installation-a-update-issues/116365-passthru-version-3-0#173625

I also hit this problem, anyone knows that the issue is being investigated?

I have the same problem. The get parameter lost if I enable "Use CAPTCHA for survey access"
LS Version 3.25.15+210223

Can we please get an lss file and a detailed step-by-step description on how to reproduce? Developers read and test multiple bug reports per day, and guessing what should be done takes a lot of time. Thank you.

Hi Ollehar,
See attached lss file.

Bug shown on Step 2 and Step 2a.
No bug on Step 1 and Step 1a.

Step 1. Under Publication & Access: Use CAPTCHA for survey access OFF
Step 1a. append "&uid=panelIDebug14039" when testing the survey

example if the survey number is 175717
https://somevalidpath/index.php/175717?newtest=Y&lang=en&uid=panelIDebug14039
text "panelIDebug14039" will be success captured on question Q1 [so as on the response datafile]

Step 2. Under Publication & Access: Use CAPTCHA for survey access ON
Step 2a append "&uid=panelIDebug14039" when testing the survey

Expect text "panelIDebug14039" capture at question Q1
text "panelIDebug14039" failed to captured on question Q1 [blank of response datafile]

What do you think?

Problem Diagnosis

The function that catches URL parameters is not called when showing token form or captcha.
As url parameters are not forwarded to the next screens, they get lost.

Technically Speaking

Prefill values are read from the URL parameters on prefillFromCommandLine(), which is called from buildsurveysession(). But buildsurveysession() is not called when the captcha page needs to be displayed.
So, when prefillFromCommandLine() runs (on captcha form submit), the prefill parameter are not in the URL anymore.

Solution Alternative A

Add URL parameters to the captcha form, so they are included in the next request:

• On renderRenderWayForm(), retrieve the additional URL parameters (except reserved ones) and add them to the survey url (which is used as the form's action).

• Modify prefillFromCommandLine() to also work on POST requests (it only processes GET requests, and the captcha form uses the POST method)

Solution Alternative B

If the captcha form needs to be displayed, store the additional URL parameter in the session:

• On renderRenderWayForm(), retrieve the additional URL parameters (except reserved ones) and put them on $SESSION['survey'.$surveyid]['queryParams'].

• On prefillFromCommandLine(), if the session has the 'queryParams' key, use them. Basically changing this:

if (Yii::app()->getRequest()->getRequestType()=='GET') {
    $getValues = array_diff_key($_GET,array_combine($reservedGetValues, $reservedGetValues));
    if(!empty($getValues)) {
        ...
    }
}

into this:

$params = [];
if (!empty($_SESSION['survey_'.$surveyid]['queryParams'])) {
    $params = $_SESSION['survey_'.$surveyid]['queryParams'];
    unset($_SESSION['survey_'.$surveyid]['queryParams']);
}
if (Yii::app()->getRequest()->getRequestType()=='GET') {
    $params = array_merge($params, $_GET);
}

if (!empty($params)) {
        $getValues = array_diff_key($params,array_combine($reservedGetValues, $reservedGetValues));
        if(!empty($getValues)) {
            ...
        }
    }

Option B caveats: If the captcha form is displayed and, instead of submitting the form, the user goes to a different page, the "saved" query parameters will remain in the session.

Solution Alternative C

Same as A but, parameters wouldn't forwarded in the URL but in hidden. We would need to create a specific twig extension that creates hidden inputs for query string parameters.

Downside: Custom themes would need amendment.

Solution A sounds to be the most reasonable to me.

PR: https://github.com/LimeSurvey/LimeSurvey/pull/1896

@jelo Time to test this PR?

Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=31951

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=31952

Release done.